Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth github with token #149

Open
tgrrr opened this issue Sep 10, 2020 · 3 comments
Open

Auth github with token #149

tgrrr opened this issue Sep 10, 2020 · 3 comments

Comments

@tgrrr
Copy link

tgrrr commented Sep 10, 2020

Hi,

Big fan of Markdown Preview Enhanced, crossnote looks great

It would be great to be able to provide a github auth token rather than username and password.

All of the usual reasons, plus using the password means I can't use the github sync feature because of 2fa.

@shd101wyy
Copy link
Contributor

Hi @tgrrr , you can simply put your access token in username field and leave password field empty and it would work. Thank you!

@tgrrr
Copy link
Author

tgrrr commented Sep 21, 2020

Hi @shd101wyy,

I've updated the Tutorial template with this PR: 0xGG/welcome-notebook#5

I looked at the https://github.com/0xGG/crossnote/blob/develop/src/components/AddNotebookDialog.tsx file, and was wondering if it's worth adding a toggle / tabbed menu between the 2 auth methods?

@shd101wyy
Copy link
Contributor

I've updated the Tutorial template with this PR: 0xGG/welcome-notebook#5

Merged now. Thank you for your contribution!

I looked at the https://github.com/0xGG/crossnote/blob/develop/src/components/AddNotebookDialog.tsx file, and was wondering if it's worth adding a toggle / tabbed menu between the 2 auth methods?

Yes it could be changed in the future 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants