Merge pull request #481 from 0xMiden/greenhat/deny-warnings-add-check-release

bitwalker · web-flow · commit f633c53e614c · 2025-04-07T21:14:29.000-04:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -6,14 +6,14 @@ on:
       - main
       - next
     paths-ignore:
-      - '**.md'
-      - '**.txt'
-      - 'docs/**'
+      - "**.md"
+      - "**.txt"
+      - "docs/**"
   pull_request:
     paths-ignore:
-      - '**.md'
-      - '**.txt'
-      - 'docs/**'
+      - "**.md"
+      - "**.txt"
+      - "docs/**"
 
 jobs:
   lint:
@@ -96,6 +96,11 @@ jobs:
         # error occurs
         run: |
           cargo make check --tests
+      - name: Check(release)
+        # We run `check` with `--release` to check the release build (without
+        # `debug_assertions`, etc.)
+        run: |
+          cargo make check --release --tests
       - name: Test
         run: |
           cargo make test -E 'not (package(miden-integration-tests) or package(cargo-miden))'
diff --git a/codegen/masm/src/lib.rs b/codegen/masm/src/lib.rs
@@ -4,6 +4,7 @@
 #![feature(array_chunks)]
 #![feature(iter_array_chunks)]
 #![feature(iterator_try_collect)]
+#![deny(warnings)]
 
 extern crate alloc;
 
diff --git a/dialects/arith/src/lib.rs b/dialects/arith/src/lib.rs
@@ -5,6 +5,7 @@
 #![feature(ptr_metadata)]
 #![feature(specialization)]
 #![allow(incomplete_features)]
+#![deny(warnings)]
 
 extern crate alloc;
 
diff --git a/dialects/cf/src/lib.rs b/dialects/cf/src/lib.rs
@@ -5,6 +5,7 @@
 #![feature(ptr_metadata)]
 #![feature(specialization)]
 #![allow(incomplete_features)]
+#![deny(warnings)]
 
 extern crate alloc;
 
diff --git a/dialects/hir/src/lib.rs b/dialects/hir/src/lib.rs
@@ -5,6 +5,7 @@
 #![feature(specialization)]
 #![allow(incomplete_features)]
 #![no_std]
+#![deny(warnings)]
 
 extern crate alloc;
 
diff --git a/dialects/scf/src/lib.rs b/dialects/scf/src/lib.rs
@@ -5,6 +5,7 @@
 #![feature(ptr_metadata)]
 #![feature(specialization)]
 #![allow(incomplete_features)]
+#![deny(warnings)]
 
 extern crate alloc;
 
diff --git a/dialects/ub/src/lib.rs b/dialects/ub/src/lib.rs
@@ -5,6 +5,7 @@
 #![feature(ptr_metadata)]
 #![feature(specialization)]
 #![allow(incomplete_features)]
+#![deny(warnings)]
 
 extern crate alloc;
 
diff --git a/eval/src/lib.rs b/eval/src/lib.rs
@@ -1,5 +1,6 @@
 #![no_std]
 #![feature(debug_closure_helpers)]
+#![deny(warnings)]
 
 #[cfg(any(feature = "std", test))]
 extern crate std;
diff --git a/hir-analysis/src/lib.rs b/hir-analysis/src/lib.rs
@@ -7,6 +7,7 @@
 #![feature(unsize)]
 // Specialization
 #![allow(incomplete_features)]
+#![deny(warnings)]
 
 extern crate alloc;
 #[cfg(test)]
diff --git a/hir-macros/src/lib.rs b/hir-macros/src/lib.rs
@@ -1,3 +1,5 @@
+#![deny(warnings)]
+
 extern crate proc_macro;
 
 mod operation;
diff --git a/hir-symbol/src/lib.rs b/hir-symbol/src/lib.rs
@@ -1,4 +1,5 @@
 #![no_std]
+#![deny(warnings)]
 
 extern crate alloc;
 #[cfg(feature = "std")]
diff --git a/hir-transform/src/lib.rs b/hir-transform/src/lib.rs
@@ -1,5 +1,6 @@
 #![no_std]
 #![feature(new_range_api)]
+#![deny(warnings)]
 
 extern crate alloc;
 #[cfg(test)]
diff --git a/hir-type/src/lib.rs b/hir-type/src/lib.rs
@@ -1,4 +1,5 @@
 #![no_std]
+#![deny(warnings)]
 
 extern crate alloc;
 
diff --git a/hir/src/ir/loops.rs b/hir/src/ir/loops.rs
@@ -14,7 +14,7 @@ use crate::{
     adt::{SmallDenseMap, SmallSet},
     cfg::{Graph, Inverse, InvertibleGraph},
     pass::Analysis,
-    BlockRef, EntityWithId, Operation, OperationRef, PostOrderBlockIter, Report,
+    BlockRef, Operation, OperationRef, PostOrderBlockIter, Report,
 };
 
 /// Represents the results of analyzing an [Operation] and computing the [LoopForest] for each of
@@ -537,6 +537,8 @@ impl LoopForest {
         other_l: Rc<Loop>,
         other_loop_headers: &mut SmallDenseMap<BlockRef, Rc<Loop>, 8>,
     ) -> Result<(), Report> {
+        use crate::EntityWithId;
+
         let header = l.header();
         let other_header = other_l.header();
         if header != other_header {
@@ -1275,7 +1277,9 @@ impl Loop {
     }
 
     #[cfg(not(debug_assertions))]
-    pub fn verify_loop(&self) {}
+    pub fn verify_loop(&self) -> Result<(), Report> {
+        Ok(())
+    }
 
     /// Verify loop structure of this loop and all nested loops.
     pub fn verify_loop_nest(
diff --git a/hir/src/lib.rs b/hir/src/lib.rs
@@ -41,6 +41,7 @@
 // Some of the above features require us to disable these warnings
 #![allow(incomplete_features)]
 #![allow(internal_features)]
+#![deny(warnings)]
 
 extern crate alloc;
 
diff --git a/midenc-compile/src/lib.rs b/midenc-compile/src/lib.rs
@@ -1,4 +1,5 @@
 #![no_std]
+#![deny(warnings)]
 
 extern crate alloc;
 #[cfg(feature = "std")]
diff --git a/midenc-driver/src/lib.rs b/midenc-driver/src/lib.rs
@@ -1,3 +1,5 @@
+#![deny(warnings)]
+
 mod midenc;
 
 pub use clap::Error as ClapError;
diff --git a/midenc-session/src/lib.rs b/midenc-session/src/lib.rs
@@ -4,6 +4,7 @@
 #![feature(slice_split_once)]
 // Specialization
 #![allow(incomplete_features)]
+#![deny(warnings)]
 
 extern crate alloc;
 #[cfg(feature = "std")]
diff --git a/midenc-session/src/libs.rs b/midenc-session/src/libs.rs
@@ -1,3 +1,5 @@
+#![deny(warnings)]
+
 use alloc::{borrow::Cow, format, str::FromStr, sync::Arc};
 #[cfg(feature = "std")]
 use alloc::{boxed::Box, string::ToString};
diff --git a/sdk/alloc/src/lib.rs b/sdk/alloc/src/lib.rs
@@ -1,4 +1,5 @@
 #![no_std]
+#![deny(warnings)]
 
 extern crate alloc;
 
diff --git a/sdk/base-sys/src/lib.rs b/sdk/base-sys/src/lib.rs
@@ -1,5 +1,6 @@
 // Enable no_std for the bindings module
 #![no_std]
+#![deny(warnings)]
 
 #[cfg(feature = "bindings")]
 pub mod bindings;
diff --git a/sdk/sdk/src/lib.rs b/sdk/sdk/src/lib.rs
@@ -1,4 +1,5 @@
 #![no_std]
+#![deny(warnings)]
 
 pub use miden_base_sys::bindings::*;
 pub use miden_sdk_alloc::BumpAlloc;
diff --git a/sdk/stdlib-sys/src/lib.rs b/sdk/stdlib-sys/src/lib.rs
@@ -1,4 +1,5 @@
 #![no_std]
+#![deny(warnings)]
 
 mod intrinsics;
 mod stdlib;
diff --git a/tools/cargo-miden/src/lib.rs b/tools/cargo-miden/src/lib.rs
@@ -1,3 +1,5 @@
+#![deny(warnings)]
+
 use std::path::PathBuf;
 
 use anyhow::bail;

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+#![deny(warnings)]`
	`2`	`+`
`1`	`3`	`extern crate proc_macro;`
`2`	`4`
`3`	`5`	`mod operation;`