Skip to content

Commit d5326f2

Browse files
committed
remove BUILD_PROTO makefile and env
1 parent 3fe630e commit d5326f2

2 files changed

Lines changed: 7 additions & 9 deletions

File tree

Makefile

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ help:
77
# -- variables ------------------------------------------------------------------------------------
88

99
WARNINGS=RUSTDOCFLAGS="-D warnings"
10-
BUILD_PROTO=BUILD_PROTO=1
1110
CONTAINER_RUNTIME ?= docker
1211
STRESS_TEST_DATA_DIR ?= stress-test-store-$(shell date +%Y%m%d-%H%M%S)
1312

@@ -86,7 +85,7 @@ test: ## Runs all tests
8685

8786
.PHONY: check
8887
check: ## Check all targets and features for errors without code generation
89-
${BUILD_PROTO} cargo check --all-features --all-targets --locked --workspace
88+
cargo check --all-features --all-targets --locked --workspace
9089

9190
.PHONY: check-features
9291
check-features: ## Checks all feature combinations compile without warnings using cargo-hack
@@ -96,22 +95,22 @@ check-features: ## Checks all feature combinations compile without warnings usin
9695

9796
.PHONY: build
9897
build: ## Builds all crates and re-builds protobuf bindings for proto crates
99-
${BUILD_PROTO} cargo build --locked --workspace
100-
${BUILD_PROTO} cargo build --locked -p miden-remote-prover-client --target wasm32-unknown-unknown --no-default-features --features batch-prover,block-prover,tx-prover # no-std compatible build
98+
cargo build --locked --workspace
99+
cargo build --locked -p miden-remote-prover-client --target wasm32-unknown-unknown --no-default-features --features batch-prover,block-prover,tx-prover # no-std compatible build
101100

102101
# --- installing ----------------------------------------------------------------------------------
103102

104103
.PHONY: install-node
105104
install-node: ## Installs node
106-
${BUILD_PROTO} cargo install --path bin/node --locked
105+
cargo install --path bin/node --locked
107106

108107
.PHONY: install-remote-prover
109108
install-remote-prover: ## Install remote prover's CLI
110-
$(BUILD_PROTO) cargo install --path bin/remote-prover --bin miden-remote-prover --locked
109+
cargo install --path bin/remote-prover --bin miden-remote-prover --locked
111110

112111
.PHONY: stress-test-smoke
113112
stress-test: ## Runs stress-test benchmarks
114-
${BUILD_PROTO} cargo build --release --locked -p miden-node-stress-test
113+
cargo build --release --locked -p miden-node-stress-test
115114
@mkdir -p $(STRESS_TEST_DATA_DIR)
116115
./target/release/miden-node-stress-test seed-store --data-directory $(STRESS_TEST_DATA_DIR) --num-accounts 500 --public-accounts-percentage 50
117116
./target/release/miden-node-stress-test benchmark-store --data-directory $(STRESS_TEST_DATA_DIR) --iterations 10 --concurrency 1 sync-state

scripts/check-features.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,8 @@ set -euo pipefail
77

88
echo "Checking all feature combinations with cargo-hack..."
99

10-
# Set environment variables to treat warnings as errors and build protos
10+
# Set environment variables to treat warnings as errors
1111
export RUSTFLAGS="-D warnings"
12-
export BUILD_PROTO=1
1312

1413
# Run cargo-hack with comprehensive feature checking
1514
cargo hack check \

0 commit comments

Comments
 (0)