Skip to content

Improve example documentation #117

@197g

Description

@197g

Project Improvement

The lack of comments and the complexity in the setup leads to bad understanding of the examples, especially without prior knowledge of OAuth2's inner workings. In particular:

  • It's unclear which portions of the examples belong to the server and must be provided.
  • Which are purely for the sake of the example client. This being an increased concern for rocket where we must use the same server as the library only allows 'launching one Rocket'.
  • The example structures differ quite a bit. (See also Example with iron framework should use generic client #111)

Comment

Original report (through another channel) also says this:

what was unclear in the examples what are the required parts of example for the server side of the authentication in particular the Client Fairing impl and whats just for the client side in the two files names rocket.rs, something that would be helpful would just adding comments where they are missing in the those two files

Tracking pull request

  • A pull request does not yet exist

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions