fix broken got timeout config for starlink updater

Author: jakewmeyer

app.js

@@ -1,13 +1,17 @@
 import conditional from 'koa-conditional-get';
 import etag from 'koa-etag';
 import cors from 'koa2-cors';
+import dotenv from 'dotenv';
 import helmet from 'koa-helmet';
 import Koa from 'koa';
 import bodyParser from 'koa-bodyparser';
 import mongoose from 'mongoose';
 import { responseTime, errors, logger } from './middleware/index.js';
 import routes from './routes/index.js';
 
+// Env init
+dotenv.config();
+
 const app = new Koa();
 
 mongoose.connect(process.env.SPACEX_MONGO, {

jobs/payloads.js

@@ -40,7 +40,7 @@ export default async () => {
     });
 
     const updates = payloads.docs.map(async (payload) => {
-      const noradId = payload.norad_ids.shift() || null;
+      const noradId = payload.norad_ids.shift() ?? null;
       const specificOrbit = data.find((sat) => parseInt(sat.NORAD_CAT_ID, 10) === noradId);
       if (specificOrbit) {
         await got.patch(`${API}/payloads/${payload.id}`, {

jobs/starlink.js

@@ -53,13 +53,14 @@ export default async () => {
     });
 
     const data = await got('https://www.space-track.org/basicspacedata/query/class/gp/OBJECT_NAME/~~STARLINK,~~TINTIN/orderby/NORAD_CAT_ID', {
-      resolveBodyOnly: true,
       responseType: 'json',
-      timeout: 480000, // 8 minutes
+      timeout: {
+        request: 480000, // 8 minutes
+      },
       cookieJar,
     });
 
-    const starlinkSats = data.filter((sat) => /starlink|tintin/i.test(sat.OBJECT_NAME));
+    const starlinkSats = data.body.filter((sat) => /starlink|tintin/i.test(sat.OBJECT_NAME));
 
     const updates = starlinkSats.map(async (sat) => {
       const date = moment.utc(sat.LAUNCH_DATE, 'YYYY-MM-DD');
@@ -94,14 +95,14 @@ export default async () => {
       await got.patch(`${API}/starlink/${sat.NORAD_CAT_ID}`, {
         json: {
           version: starlinkVersion(
-            launches?.docs[0]?.date_utc || null,
-            launches?.docs[0]?.name || null,
+            launches?.docs[0]?.date_utc ?? null,
+            launches?.docs[0]?.name ?? null,
           ),
-          launch: launches?.docs[0]?.id || null,
-          longitude: position?.lng || null,
-          latitude: position?.lat || null,
-          height_km: position?.height || null,
-          velocity_kms: position?.velocity || null,
+          launch: launches?.docs[0]?.id ?? null,
+          longitude: position?.lng ?? null,
+          latitude: position?.lat ?? null,
+          height_km: position?.height ?? null,
+          velocity_kms: position?.velocity ?? null,
           spaceTrack: {
             CCSDS_OMM_VERS: sat.CCSDS_OMM_VERS,
             COMMENT: sat.COMMENT,
@@ -162,6 +163,7 @@ export default async () => {
       await got(HEALTHCHECK);
     }
   } catch (error) {
+    console.error(error);
     console.log(`Starlink Error: ${error.message}`);
   }
 };

jobs/worker.js

@@ -1,4 +1,5 @@
 import { CronJob } from 'cron';
+import dotenv from 'dotenv';
 import { logger } from '../middleware/index.js';
 import launches from './launches.js';
 import payloads from './payloads.js';
@@ -12,6 +13,9 @@ import starlink from './starlink.js';
 import webcast from './webcast.js';
 import launchLibrary from './launch-library.js';
 
+// Env init
+dotenv.config();
+
 // Every 10 minutes
 const launchesJob = new CronJob('*/10 * * * *', launches);
 

middleware/cache.js

@@ -81,7 +81,7 @@ export default (ttl) => async (ctx, next) => {
 
   // Set cache
   try {
-    if ((ctx.response.status !== 200) || !responseBody) {
+    if ((ctx?.response?.status !== 200) || !responseBody) {
       return;
     }
     await redis.set(key, responseBody, 'EX', ttl);

middleware/errors.js

@@ -12,7 +12,7 @@ export default async (ctx, next) => {
     if (err?.kind === 'ObjectId') {
       err.status = 404;
     } else {
-      ctx.status = err.status || 500;
+      ctx.status = err.status ?? 500;
       ctx.body = err.message;
     }
   }

package-lock.json

@@ -33,6 +33,7 @@
     "blake3": "^2.1.7",
     "cheerio": "^1.0.0-rc.12",
     "cron": "^2.0.0",
+    "dotenv": "^16.0.1",
     "fuzzball": "^2.1.2",
     "got": "^12.1.0",
     "ioredis": "^5.1.0",