Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

New endpoint: owned safes across networks #449

Closed
katspaugh opened this issue Jun 29, 2021 · 6 comments
Closed

New endpoint: owned safes across networks #449

katspaugh opened this issue Jun 29, 2021 · 6 comments
Labels
Later Issue that have been closed, but might be relevant at a later point of time again

Comments

@katspaugh
Copy link
Member

katspaugh commented Jun 29, 2021

Overview

For the "In-app Network Switching" epic, we'll need to display the safes owned by a user across multiple networks in the app sidebar.

Requirements

We'd like to be able to receive is a list of records like this:

[{
  "address": "0x79E0ec6c7AecFecC7D03E8565837fB5Bf0BB691f",
  "chainId": "4"
  "dateCreated": "2021-06-21"
},
{
  "address": "0x79E0ec6c7AecFecC7D03E8565837fB5Bf0BB691f",
  "chainId": "1"
  "dateCreated": "2021-06-29"
}]

The request parameters should be:

  • ownerAddress
  • chainIds – comma-separated list of chain ids

☝️ chainIds is supposed to reduce the scope of the request to not fetch safes on all the networks.

Existing endpoints

There's already a transaction-service endpoint to fetch the list of owner's safes but it returns only the addresses:

https://safe-transaction.rinkeby.gnosis.io/api/v1/owners/0x474e5Ded6b5D078163BFB8F6dBa355C3aA5478C8/safes/

Screens

Screenshot 2021-06-29 at 15 21 37

Figma screens

@katspaugh katspaugh changed the title New endpoint: owned safes with balances across networks New endpoint: owned safes across networks Jun 29, 2021
@jpalvarezl
Copy link
Contributor

Judging by the discussion on slack, it seems that this issue should be on not now but maybe there is still something that needs to be mentioned on the subject, therefore left it in specs to review

@rmeissner rmeissner added the Later Issue that have been closed, but might be relevant at a later point of time again label Jul 6, 2021
@katspaugh
Copy link
Member Author

Update: added a chainId parameter in the specs, to make the endpoint "lighter".
We'll pass a list of chains that the user has used.

@rmeissner rmeissner added this to the Version 3.15.0 milestone Feb 8, 2022
@sche
Copy link

sche commented Apr 11, 2022

As part of the Owner keys are confusing and not safe to use problem statement, we want to implement suggesting to import owned safes when importing a key by a seed phrase.
We would like to start working on improving key import flow in roughly three weeks. Would it be possible to implement this endpoint in the following 2-4 weeks?

@rmeissner
Copy link
Member

I would not do this before we have safe-global/safe-transaction-service#763 in place. Once it is done the performance overhead should be manageable.

@katspaugh
Copy link
Member Author

Please feel free to close this, as we currently only display owned safes on a given chain.

@fmrsabino
Copy link
Contributor

Will do. We can reopen later it needed.

Closing as not planned.

@fmrsabino fmrsabino closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Later Issue that have been closed, but might be relevant at a later point of time again
Projects
None yet
Development

No branches or pull requests

5 participants