Refatorings

Author: Lucas Romano

README.md

@@ -99,7 +99,7 @@ class DocumentAssignedEmail extends Notification implements ShouldQueue
 #### 2 - Create the notification event for the intended notification:
 
 ```
-Batch_Notification_Event::makeOne(
+BatchNotificationEvent::queue(
     Auth::user(), /* The notifiable model instance. This can be any Notifiable Eloquent model */
     $document, /* The eventable instance you want to attach to the notification. All batch's eventables will be present on your notification constructor. This can be any Eloquent model. */
     DocumentAssignedEmail::class, /* The fully qualified name of your notification class */

src/Console/DispatchBatchNotifications.php

@@ -2,8 +2,8 @@
 
 namespace R64\BatchNotifications\Console;
 
-use R64\BatchNotifications\Models\Batch_Notification;
-use R64\BatchNotifications\Models\Batch_Notification_Event;
+use R64\BatchNotifications\Models\BatchNotification;
+use R64\BatchNotifications\Models\BatchNotificationEvent;
 use Illuminate\Console\Command;
 use Illuminate\Notifications\Notifiable;
 
@@ -38,15 +38,15 @@ public function __construct()
      */
     public function handle()
     {
-        $notifications = Batch_Notification::where('dispatched', false)
+        $notifications = BatchNotification::where('dispatched', false)
             ->where('dispatch_at', '<=', now()->toDateTimeString())
             ->get();
 
-        /** @var Batch_Notification $notification */
+        /** @var BatchNotification $notification */
         foreach ($notifications as $notification) {
 
             $eventables = collect();
-            /** @var Batch_Notification_Event $event */
+            /** @var BatchNotificationEvent $event */
             foreach ($notification->events as $event) {
                 $eventables->push($event->eventable);
             }

src/Models/Batch_Notification.php renamed to src/Models/BatchNotification.php

@@ -4,7 +4,7 @@
 
 use Illuminate\Database\Eloquent\Model;
 
-class Batch_Notification extends Model
+class BatchNotification extends Model
 {
     protected $table = 'batch_notifications';
     protected $guarded = ['id'];
@@ -26,6 +26,6 @@ public function notifiable()
 
     public function events()
     {
-        return $this->hasMany(Batch_Notification_Event::class, 'batch_notification_id');
+        return $this->hasMany(BatchNotificationEvent::class, 'batch_notification_id');
     }
 }

src/Models/Batch_Notification_Event.php renamed to src/Models/BatchNotificationEvent.php

@@ -5,7 +5,7 @@
 use Carbon\Carbon;
 use Illuminate\Database\Eloquent\Model;
 
-class Batch_Notification_Event extends Model
+class BatchNotificationEvent extends Model
 {
     protected $table = 'batch_notification_events';
     protected $guarded = ['id'];
@@ -23,7 +23,7 @@ public function eventable()
 
     public function batchNotification()
     {
-        return $this->belongsTo(Batch_Notification::class, 'batch_notification_id');
+        return $this->belongsTo(BatchNotification::class, 'batch_notification_id');
     }
 
     /***************************************************************************************
@@ -32,7 +32,7 @@ public function batchNotification()
 
     public static function queue(Model $notifiable, Model $eventable, string $notification_class, Carbon $dispatch_at)
     {
-        $batch_notification = Batch_Notification::firstOrCreate([
+        $batch_notification = BatchNotification::firstOrCreate([
             'notifiable_id' => $notifiable->id,
             'notifiable_type' => get_class($notifiable),
             'notification_class' => $notification_class,
@@ -41,7 +41,7 @@ public static function queue(Model $notifiable, Model $eventable, string $notifi
             'dispatch_at' => $dispatch_at
         ]);
 
-        $event = new Batch_Notification_Event();
+        $event = new BatchNotificationEvent();
         $event->batchNotification()->associate($batch_notification);
         $event->eventable()->associate($eventable);