Kill get global hack in favour of define plugin. Resolves pusher#168

Author: jpatel531

src/core/base64.ts

@@ -1,5 +1,3 @@
-const global = Function("return this")();
-
 export default function encode (s : any) : string {
   return btoa(utob(s));
 }

src/core/events/dispatcher.ts

@@ -1,6 +1,5 @@
 import CallbackRegistry from './callback_registry';
 import Callback from './callback';
-const global = Function("return this")();
 
 /** Manages callback bindings and event emitting.
  *

src/core/logger.ts

@@ -10,7 +10,6 @@ const Logger = {
   },
   warn(...args : any[]) {
     var message = safeJSONStringify.apply(this, arguments);
-    const global = Function("return this")();
     if (global.console) {
       if (global.console.warn) {
         global.console.warn(message);

src/core/pusher.ts

@@ -39,7 +39,6 @@ export default class Pusher {
   }
 
   static log(message : any) {
-    const global = Function("return this")();
     if (Pusher.logToConsole && global.console && global.console.log) {
       global.console.log(message);
     }

src/core/utils/collections.ts

@@ -1,6 +1,5 @@
 import base64encode from '../base64';
 import Util from '../util';
-const global = Function("return this")();
 
 /** Merges multiple objects into the target argument.
 *

src/d.ts/global/global.d.ts

@@ -0,0 +1 @@
+declare const global : any;

tsconfig.json

@@ -9,6 +9,7 @@
   },
   "files": [
     "src/core/pusher.ts",
+    "src/d.ts/global/global.d.ts",
     "src/d.ts/faye-websocket/faye-websocket.d.ts",
     "src/d.ts/xmlhttprequest/xmlhttprequest.d.ts",
     "src/d.ts/window/websocket.d.ts",

webpack/config.web.js

@@ -21,7 +21,12 @@ var config = objectAssign(require('./config.shared'),{
   },
   resolve: {
     modulesDirectories: ['src/', 'src/runtimes/web', 'src/runtimes']
-  }
+  },
+  plugins: [
+    new webpack.DefinePlugin({
+      global: "window"
+    })
+  ]
 });
 
 module.exports = config;

webpack/config.worker.js

@@ -2,6 +2,7 @@ var path = require("path");
 var NormalModuleReplacementPlugin = require('webpack').NormalModuleReplacementPlugin;
 var version = require('../package').version;
 var objectAssign = require('object-assign-deep');
+var webpack = require('webpack');
 
 /*
   Upon importing the 'runtime' module, this worker build is made to look at
@@ -20,7 +21,12 @@ var config = objectAssign(require('./config.shared'),{
   },
   resolve: {
     modulesDirectories: ['src/', 'src/runtimes/worker', 'src/runtimes']
-  }
+  },
+  plugins: [
+    new webpack.DefinePlugin({
+      global: "self"
+    })
+  ]
 });
 
 /*