fix: harden async/leak paths and complete i18n across TUI, SDK, and engine

Author: 7723qqq

apps/kimi-code/src/cli/options.ts

@@ -88,13 +88,13 @@ export function validateOptions(
     throw new OptionConflictError(t('cli.errors.cannotCombinePromptAndPlan'));
   }
   if (opts.agent !== undefined && opts.agent.trim().length === 0) {
-    throw new OptionConflictError('Agent cannot be empty.');
+    throw new OptionConflictError(t('cli.errors.agentEmpty'));
   }
   if (opts.agentFiles.length > 1) {
     throw new OptionConflictError(t('cli.errors.agentFileOnlyOnce'));
   }
   if (opts.agentFiles.some((file) => file.trim().length === 0)) {
-    throw new OptionConflictError('Agent file path cannot be empty.');
+    throw new OptionConflictError(t('cli.errors.agentFilePathEmpty'));
   }
   if (opts.agent !== undefined && opts.agentFiles.length > 0) {
     throw new OptionConflictError('Cannot combine --agent with --agent-file.');

apps/kimi-code/src/cli/run-prompt.ts

@@ -35,6 +35,11 @@ import type { CLIOptions } from './options';
  * cleanup is still bounded by `timeoutMs`, so this can't hang the run forever.
  */
 export async function raceWithTimeout(promise: Promise<void>, timeoutMs: number): Promise<void> {
+  // A non-positive timeout would make the timer fire immediately and silently
+  // skip waiting entirely — reject clearly-invalid values instead.
+  if (timeoutMs < 0) {
+    throw new RangeError(`raceWithTimeout: timeoutMs must be >= 0, got ${timeoutMs}`);
+  }
   let timedOut = false;
   let timer: ReturnType<typeof setTimeout> | undefined;
   // Attach the catch eagerly (synchronously) so `promise` is always consumed and
@@ -109,6 +114,8 @@ export function installPromptTerminationCleanup(
     try {
       await cleanup();
     } finally {
+      // Exit regardless of cleanup outcome; the cleanup rejection propagates to
+      // the (already-exiting) caller.
       promptProcess.exit(signalExitCode(signal));
     }
   };
@@ -129,5 +136,6 @@ export function signalExitCode(signal: NodeJS.Signals): number {
   if (signal === 'SIGINT') return 128 + os.constants.signals.SIGINT;
   if (signal === 'SIGHUP') return 128 + os.constants.signals.SIGHUP;
   if (signal === 'SIGTERM') return 128 + os.constants.signals.SIGTERM;
-  return 143;
+  // Fall back to the SIGTERM convention (128 + 15) for any unhandled signal.
+  return 128 + (os.constants.signals.SIGTERM ?? 15);
 }

apps/kimi-code/src/i18n/locales/en.json

@@ -122,7 +122,9 @@
       "cannotCombineContinueAndSession": "Cannot combine --continue, --session.",
       "cannotCombineYoloAndAuto": "Cannot combine --yolo with --auto.",
       "agentOnlyOnce": "--agent may only be specified once.",
-      "agentFileOnlyOnce": "--agent-file may only be specified once."
+      "agentFileOnlyOnce": "--agent-file may only be specified once.",
+      "agentEmpty": "Agent cannot be empty.",
+      "agentFilePathEmpty": "Agent file path cannot be empty."
     }
   },
   "startup": {
@@ -1728,6 +1730,9 @@
       "bgAgentStarted": "{{subject}} started in background",
       "bgAgentCompleted": "{{subject}} completed in background",
       "bgAgentFailed": "{{subject}} failed in background",
+      "bgAgentLost": "{{subject}} lost in background",
+      "bgAgentKilled": "{{subject}} stopped",
+      "bgAgentTimedOut": "{{subject}} timed out",
       "mcpStatusFailed": "{{count}} failed",
       "mcpStatusNeedsAuth": "{{count}} need auth",
       "mcpStatusConnecting": "{{count}} connecting",

apps/kimi-code/src/i18n/locales/en.ts

@@ -139,6 +139,8 @@ export default {
       cannotCombineYoloAndAuto: 'Cannot combine --yolo with --auto.',
       agentOnlyOnce: '--agent may only be specified once.',
       agentFileOnlyOnce: '--agent-file may only be specified once.',
+      agentEmpty: 'Agent cannot be empty.',
+      agentFilePathEmpty: 'Agent file path cannot be empty.',
     },
   },
   startup: {
@@ -1879,6 +1881,9 @@ export default {
       bgAgentStarted: '{{subject}} started in background',
       bgAgentCompleted: '{{subject}} completed in background',
       bgAgentFailed: '{{subject}} failed in background',
+      bgAgentLost: '{{subject}} lost in background',
+      bgAgentKilled: '{{subject}} stopped',
+      bgAgentTimedOut: '{{subject}} timed out',
       // tui/utils/mcp-server-status.ts
       mcpStatusFailed: '{{count}} failed',
       mcpStatusNeedsAuth: '{{count}} need auth',

apps/kimi-code/src/i18n/locales/zh.json

@@ -122,7 +122,9 @@
       "cannotCombineContinueAndSession": "--continue 不能与 --session 同时使用。",
       "cannotCombineYoloAndAuto": "--yolo 不能与 --auto 同时使用。",
       "agentOnlyOnce": "--agent 只能指定一次。",
-      "agentFileOnlyOnce": "--agent-file 只能指定一次。"
+      "agentFileOnlyOnce": "--agent-file 只能指定一次。",
+      "agentEmpty": "Agent 不能为空。",
+      "agentFilePathEmpty": "Agent 文件路径不能为空。"
     }
   },
   "startup": {
@@ -1728,6 +1730,9 @@
       "bgAgentStarted": "{{subject}} 已在后台启动",
       "bgAgentCompleted": "{{subject}} 已在后台完成",
       "bgAgentFailed": "{{subject}} 在后台失败",
+      "bgAgentLost": "{{subject}} 在后台失联",
+      "bgAgentKilled": "{{subject}} 已停止",
+      "bgAgentTimedOut": "{{subject}} 在后台超时",
       "mcpStatusFailed": "{{count}} 个失败",
       "mcpStatusNeedsAuth": "{{count}} 个需要认证",
       "mcpStatusConnecting": "{{count}} 个连接中",

apps/kimi-code/src/i18n/locales/zh.ts

@@ -137,6 +137,8 @@ export default {
       cannotCombineYoloAndAuto: '--yolo 不能与 --auto 同时使用。',
       agentOnlyOnce: '--agent 只能指定一次。',
       agentFileOnlyOnce: '--agent-file 只能指定一次。',
+      agentEmpty: 'Agent 不能为空。',
+      agentFilePathEmpty: 'Agent 文件路径不能为空。',
     },
   },
   startup: {
@@ -1835,6 +1837,9 @@ export default {
       bgAgentStarted: '{{subject}} 已在后台启动',
       bgAgentCompleted: '{{subject}} 已在后台完成',
       bgAgentFailed: '{{subject}} 在后台失败',
+      bgAgentLost: '{{subject}} 在后台失联',
+      bgAgentKilled: '{{subject}} 已停止',
+      bgAgentTimedOut: '{{subject}} 在后台超时',
       // tui/utils/mcp-server-status.ts
       mcpStatusFailed: '{{count}} 个失败',
       mcpStatusNeedsAuth: '{{count}} 个需要认证',

apps/kimi-code/src/tui/controllers/editor-keyboard.ts

@@ -102,7 +102,7 @@ export class EditorKeyboardController {
         return entry.slice(1);
       }
       editor.setInputMode('prompt');
-      return undefined;
+      return;
     };
 
     // Save/restore the input mode alongside pi-tui's history draft. Without
@@ -314,12 +314,15 @@ export class EditorKeyboardController {
         ) {
           return;
         }
-        host.state.queuedMessages = queued.filter((m) => m.mode === 'bash');
-        if (!editorIsBash) editor.setText('');
         const session = host.session;
         if (host.state.appState.model.trim().length === 0 || session === undefined) {
           host.showError(getLlmNotSetMessage());
         } else {
+          // Mutate the queue/editor only after the guard passes, so an
+          // early-return here never drops the user's queued non-bash items or
+          // the draft text.
+          host.state.queuedMessages = queued.filter((m) => m.mode === 'bash');
+          if (!editorIsBash) editor.setText('');
           host.steerMessage(session, items);
         }
       }

apps/kimi-code/src/tui/controllers/session-event-handler.ts

@@ -7,6 +7,7 @@ import type {
   SessionMetaUpdatedEvent,
   TokenUsage,
 } from '@moonshot-ai/kimi-code-sdk';
+import { log } from '@moonshot-ai/kimi-code-sdk';
 
 /** Narrowed event shapes consumed by the private handlers below. */
 type StatusUpdatedEvent = Extract<Event, { type: 'agent.status.updated' }>;
@@ -747,6 +748,7 @@ export class SessionEventHandler {
         kind: 'assistant',
         renderMode: 'markdown',
         content: buildGoalCompletionMessage(event.snapshot),
+        goalCompletionData: true,
       });
       state.ui.requestRender();
       return;
@@ -806,6 +808,15 @@ export class SessionEventHandler {
           }
           this.goalCompletionTurnEnded = false;
         })
+        .catch((error) => {
+          // An unexpected failure must not surface as an unhandled rejection;
+          // reset the pending state so a later turn can retry the promotion.
+          this.queuedGoalPromotionPending = false;
+          this.goalCompletionTurnEnded = false;
+          log.error('Failed to promote queued goal', {
+            error: error instanceof Error ? error.message : String(error),
+          });
+        })
         .finally(() => {
           this.queuedGoalPromotionInFlight = false;
           this.scheduleQueuedGoalPromotion();

apps/kimi-code/src/tui/controllers/session-replay.ts

@@ -18,6 +18,7 @@ import type { TUIState } from '../tui-state';
 import type {
   AppState,
   BackgroundAgentMetadata,
+  BackgroundAgentStatusPhase,
   ToolResultBlockData,
   TranscriptEntry,
 } from '../types';
@@ -513,14 +514,15 @@ export class SessionReplayRenderer {
         });
         return;
       case 'completion':
-        this.host.appendTranscriptEntry(
-          replayEntry(
+        this.host.appendTranscriptEntry({
+          ...replayEntry(
             context,
             'assistant',
             buildGoalCompletionMessage(record.snapshot),
             'markdown',
           ),
-        );
+          goalCompletionData: true,
+        });
         return;
       case 'lifecycle': {
         const lifecycleChange: GoalReplayLifecycleChange = { ...change, kind: 'lifecycle' };
@@ -735,26 +737,15 @@ export class SessionReplayRenderer {
           ? undefined
           : task.thinkingEffort,
     };
-    let status = formatBackgroundAgentTranscript(
-      origin.status === 'completed' ? 'completed' : 'failed',
-      meta,
-    );
-    if (origin.status === 'lost') {
-      status = {
-        ...status,
-        headline: status.headline.replace(' failed in background', ' lost in background'),
-      };
-    } else if (origin.status === 'killed') {
-      status = {
-        ...status,
-        headline: status.headline.replace(' failed in background', ' stopped'),
-      };
-    } else if (origin.status === 'timed_out') {
-      status = {
-        ...status,
-        headline: status.headline.replace(' failed in background', ' timed out'),
-      };
-    }
+    const phase: BackgroundAgentStatusPhase =
+      origin.status === 'completed' ||
+      origin.status === 'failed' ||
+      origin.status === 'lost' ||
+      origin.status === 'killed' ||
+      origin.status === 'timed_out'
+        ? origin.status
+        : 'failed';
+    const status = formatBackgroundAgentTranscript(phase, meta);
     this.host.appendTranscriptEntry({
       ...replayEntry(context, 'status', status.headline, 'plain'),
       detail: status.detail,

apps/kimi-code/src/tui/controllers/tasks-browser.ts

@@ -345,7 +345,10 @@ export class TasksBrowserController {
       return;
     }
     const current = state.tasksBrowser;
-    if (current === undefined || current !== browser) return;
+    // Re-validate after the await: a second concurrent open may have already
+    // attached a viewer while we were fetching, and overwriting it here would
+    // leak its poll timer and leave its UI children dangling.
+    if (current === undefined || current !== browser || current.viewer !== undefined) return;
 
     const info = this.host.backgroundTasks.get(taskId);
     const viewer = new TaskOutputViewer(