Fix errors reported by static analysis

Author: ADmad

.editorconfig

@@ -11,5 +11,7 @@ insert_final_newline = true
 trim_trailing_whitespace = true
 
 [*.yml]
-indent_style = space
 indent_size = 2
+
+[*.neon]
+indent_style = tab

.gitattributes

@@ -5,3 +5,5 @@
 phpunit.xml export-ignore
 .travis.yml export-ignore
 tests export-ignore
+.phpstan.neon export-ignore
+.psalm.xml export-ignore

phpstan.neon

@@ -1,8 +1,5 @@
 parameters:
-    level: 6
-    checkMissingIterableValueType: false
-    ignoreErrors:
-        -
-            message: "#^Ternary operator condition is always true\\.$#"
-            count: 1
-            path: src/Auth/JwtAuthenticate.php
+	level: 6
+	checkMissingIterableValueType: false
+	paths:
+		- src/

psalm.xml

@@ -0,0 +1,18 @@
+<?xml version="1.0"?>
+<psalm
+    errorLevel="2"
+    resolveFromConfigFile="true"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xmlns="https://getpsalm.org/schema/config"
+    xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
+>
+    <projectFiles>
+        <directory name="src" />
+        <ignoreFiles>
+            <directory name="vendor" />
+        </ignoreFiles>
+    </projectFiles>
+    <issueHandlers>
+        <PropertyNotSetInConstructor errorLevel="suppress"/>
+    </issueHandlers>
+</psalm>

src/Auth/JwtAuthenticate.php

@@ -52,7 +52,7 @@ class JwtAuthenticate extends BaseAuthenticate
     /**
      * Exception.
      *
-     * @var \Exception
+     * @var \Throwable|null
      */
     protected $_error;
 
@@ -115,7 +115,7 @@ public function __construct(ComponentRegistry $registry, array $config)
      *
      * @param \Cake\Http\ServerRequest $request The request object.
      * @param \Cake\Http\Response $response Response object.
-     * @return bool|array User record array or false on failure.
+     * @return false|array User record array or false on failure.
      */
     public function authenticate(ServerRequest $request, Response $response)
     {
@@ -126,7 +126,7 @@ public function authenticate(ServerRequest $request, Response $response)
      * Get user record based on info available in JWT.
      *
      * @param \Cake\Http\ServerRequest $request Request object.
-     * @return bool|array User record array or false on failure.
+     * @return false|array User record array or false on failure.
      */
     public function getUser(ServerRequest $request)
     {
@@ -198,6 +198,7 @@ public function getToken(?ServerRequest $request = null)
         if (!empty($this->_config['cookie'])) {
             $token = $request->getCookie($this->_config['cookie']);
             if ($token !== null) {
+                /** @psalm-suppress PossiblyInvalidCast */
                 $token = (string)$token;
             }
 
@@ -207,6 +208,7 @@ public function getToken(?ServerRequest $request = null)
         if (!empty($this->_config['parameter'])) {
             $token = $request->getQuery($this->_config['parameter']);
             if ($token !== null) {
+                /** @psalm-suppress PossiblyInvalidCast */
                 $token = (string)$token;
             }
 
@@ -264,6 +266,7 @@ public function unauthenticated(ServerRequest $request, Response $response)
             ? $this->_error->getMessage()
             : $this->_registry->get('Auth')->getConfig('authError');
 
+        /** @var \Throwable $exception */
         $exception = new $this->_config['unauthenticatedException']($message);
         throw $exception;
     }