Skip to content

LOCAL_PROJECT_NAME is a useless variable - just use "ANTS" instead #1949

@eyalroz

Description

@eyalroz

The CMake configuration files for this project use a variable named LOCAL_PROJECT_NAME. It's defined in CMakeLists.txt, and used in that file and in SuperBuild.cmake, and once in Common.cmake.

The thing is - this variable is only set in one place; and in that one place it is set to a constant fixed string: ANTS.

So, ${LOCAL_PROJECT_NAME} simply expands to ANTS. Period, end of story. It's not as though that variable is part of some, oh, multi-CMake-project convention, and appears in modules that are also used elsewhere, and thus the variable might sometimes be useful. No, it just isn't.

I therefore suggest this variable just be dropped. It's useless pseudo-abstraction. This change will simplify the CMake files a bit and will make readers who don't know the project scratch their heads less trying to figure out what's the mysterious motivation for it - when there is none.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions