-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set lossless mode on alpha channel when encoding rav1e, when supported #19
Comments
Well, what could be done, is that you add a codec flag SUPPORTS_LOSSLESS. And based on that flag you select the available codec if you want to use lossless. |
I understand that libavif always use highest quality (~lossless) for alpha channel. |
libavif spends 0 bytes on alpha for a fully opaque alpha channel, and I think the alpha payload on a uniform lossless alpha channel is maybe 50 bytes (top-of-head). My opinion is any other alpha channel (masks, gradients, vignettes, etc) are a huge mistake to encode lossy as you will see the artifacts of it in the oddest ways, but as long as the alpha QP defaults are lossless, I don't mind exposing an option to users. |
I agree, the default for alpha must remain lossless. |
It will probably be minQuantizerAlpha/maxQuantizerAlpha, with a big warning
of a comment above them.
…On Tue, Mar 3, 2020, 7:41 AM novomesk ***@***.***> wrote:
I agree, the default for alpha must remain lossless.
How it is going to look like?
int maxAlphaQuantizer;
in avifEncoder?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19?email_source=notifications&email_token=AACRENT7IGOLB4PANIJCR53RFUQKVA5CNFSM4JHASJ52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENT7OWQ#issuecomment-594016090>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACRENX4BPKIUBDEZU522QDRFUQKVANCNFSM4JHASJ5Q>
.
|
I added these today. |
I decided to not leave a big comment in that the default is lossless for both color and alpha anyway, and people can decide for themselves which artifacts they want to live with. |
It doesn't appear rav1e has a lossless flag on encode:
xiph/rav1e#151
When this is added, hook up alpha encoding to always use it, and enable it when QP[0,0] is passed in for color as well.
The text was updated successfully, but these errors were encountered: