Skip to content

Fix drawing lags and allow drawing dots to canvas #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shubertm wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix drawing lags and allow drawing dots to canvas #107

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2663f9e
Fix lags when drawing graphical notes
shubertm Sep 28, 2025
2811af7
Allow drawing dots
shubertm Sep 28, 2025
36c661d
SVG dot
shubertm Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions app/src/main/java/dev/arkbuilders/arkmemo/ui/views/NotesCanvas.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ class NotesCanvas(context: Context, attrs: AttributeSet) : View(context, attrs)
return false
}

var finishDrawing = false
when (event.action) {
MotionEvent.ACTION_DOWN -> {
path.moveTo(x, y)
Expand All @@ -56,7 +55,10 @@ class NotesCanvas(context: Context, attrs: AttributeSet) : View(context, attrs)
}
currentX = x
currentY = y
val drawPath = DrawPath(path, viewModel.paint)
viewModel.onDrawPath(drawPath)
}

MotionEvent.ACTION_MOVE -> {
val x2 = (currentX + x) / 2
val y2 = (currentY + y) / 2
Expand All @@ -72,17 +74,14 @@ class NotesCanvas(context: Context, attrs: AttributeSet) : View(context, attrs)
currentX = x
currentY = y
}

MotionEvent.ACTION_UP, MotionEvent.ACTION_CANCEL -> {
if (x == currentX && y == currentY) path.lineTo(x, y)
path = Path()
finishDrawing = true
}
}

if (!finishDrawing) {
val drawPath = DrawPath(path, viewModel.paint)
viewModel.onDrawPath(drawPath)
invalidate()
}
invalidate()

return true
}
Expand Down