Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute replacement falling back to property and it shouldn't #347

Closed
bob2517 opened this issue Dec 18, 2023 · 1 comment
Closed

Attribute replacement falling back to property and it shouldn't #347

bob2517 opened this issue Dec 18, 2023 · 1 comment
Assignees
Labels
bug There is definitely a bug. Definitely. done on branch This issue has been committed to the latest branch, and will get merged with the next release
Milestone

Comments

@bob2517
Copy link
Member

bob2517 commented Dec 18, 2023

Getting the property id of the body node returns a type of "string" even when not explicitly set, which breaks inherited attribute replacement in the core because it thinks an id property is actually there. An id property must be being set internally in the browser.

I've split up the attr and prop return function as it was falling back to getting the property when it wasn't actually being asked for - which is unnecessary, and put in a better check for attribute existence, and the fix is now on the branch.

This fix will definitely need testing on a variety of production code before official release.

@bob2517 bob2517 added the bug There is definitely a bug. Definitely. label Dec 18, 2023
@bob2517 bob2517 added this to the 2.16.0 milestone Dec 18, 2023
@bob2517 bob2517 self-assigned this Dec 18, 2023
@bob2517 bob2517 added the done on branch This issue has been committed to the latest branch, and will get merged with the next release label Dec 18, 2023
@bob2517
Copy link
Member Author

bob2517 commented Dec 18, 2023

Closing pending release.

@bob2517 bob2517 closed this as completed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug There is definitely a bug. Definitely. done on branch This issue has been committed to the latest branch, and will get merged with the next release
Projects
None yet
Development

No branches or pull requests

1 participant