diff --git a/app/Http/Controllers/Api/V1/CurrikiGo/ExtractXAPIJSONController.php b/app/Http/Controllers/Api/V1/CurrikiGo/ExtractXAPIJSONController.php index 6fbe9ed1f..80001c8d7 100644 --- a/app/Http/Controllers/Api/V1/CurrikiGo/ExtractXAPIJSONController.php +++ b/app/Http/Controllers/Api/V1/CurrikiGo/ExtractXAPIJSONController.php @@ -54,7 +54,6 @@ public function runJob( ->where('id', '>', $max_statement_id) ->orderby('id', 'ASC') ->get(); - try { $service = new LearnerRecordStoreService(); foreach ($xapiStatements as $row) { @@ -281,13 +280,19 @@ public function runJob( } } } catch (Exception $e) { - Log::error('Summary page Cronjob crashed on row id ' . $row->id . ' - ' . $e->getMessage() . ' / Line = ' . $e->getLine()); + Log::channel('cronjob')->error('Summary page Cronjob crashed on row id ' . $row->id . ' - ' . $e->getMessage() . ' / Line = ' . $e->getLine()); + $errors = true; } } - \Log::info(date('Y-m-d h:i:s') . ' - Extract XAPI script ended'); + if($errors && $errors == true){ + return response()->json([ + 'message' => 'LRS cronjob has errors, please check LRS-Cronjob.log file.' + ], 404); + } + Log::info(date('Y-m-d h:i:s') . ' - Extract XAPI script ended'); return 'Extract XAPI JSON Cron run successfully.'; } catch (Exception $e) { - \Log::error($e->getMessage()); + Log::error($e->getMessage()); } } } diff --git a/config/logging.php b/config/logging.php index 088c204e2..b5d1f4361 100644 --- a/config/logging.php +++ b/config/logging.php @@ -47,6 +47,12 @@ 'level' => 'debug', ], + 'cronjob' => [ + 'driver' => 'single', + 'path' => storage_path('logs/LRS-Cronjob.log'), + 'level' => 'debug', + ], + 'daily' => [ 'driver' => 'daily', 'path' => storage_path('logs/laravel.log'),