chore: linter fixes and code quality improvements

- Use errors.As() instead of type assertions for error checking
- Check return values from fmt.Fprintln calls
- Simplify regex patterns (remove unnecessary escapes in char classes)
- Use idiomatic variable declarations (var x []T vs x := []T{})
- Name unused parameters with underscore (_)
- Improve comment grammar
- Standardize shell script indentation

Signed-off-by: Jose Alekhinne <alekhinejose@gmail.com>

Author: josealekhine

cmd/ctx/main.go

@@ -46,7 +46,10 @@ func init() {
 
 func main() {
 	if err := rootCmd.Execute(); err != nil {
-		fmt.Fprintln(os.Stderr, err)
+		_, err := fmt.Fprintln(os.Stderr, err)
+		if err != nil {
+			return
+		}
 		os.Exit(1)
 	}
 }

hack/build-all.sh

@@ -23,12 +23,12 @@ MODULE_PATH="./cmd/ctx"
 
 # Build targets: OS/ARCH pairs
 TARGETS=(
-    "darwin/amd64"
-    "darwin/arm64"
-    "linux/amd64"
-    "linux/arm64"
-    "windows/amd64"
-    "windows/arm64"
+  "darwin/amd64"
+  "darwin/arm64"
+  "linux/amd64"
+  "linux/arm64"
+  "windows/amd64"
+  "windows/arm64"
 )
 
 echo "Building Context CLI v${VERSION}"
@@ -40,20 +40,20 @@ mkdir -p "${OUTPUT_DIR}"
 
 # Build for each target
 for target in "${TARGETS[@]}"; do
-    GOOS="${target%/*}"
-    GOARCH="${target#*/}"
+  GOOS="${target%/*}"
+  GOARCH="${target#*/}"
 
-    output_name="${BINARY_NAME}-${GOOS}-${GOARCH}"
-    if [ "${GOOS}" = "windows" ]; then
-        output_name="${output_name}.exe"
-    fi
+  output_name="${BINARY_NAME}-${GOOS}-${GOARCH}"
+  if [ "${GOOS}" = "windows" ]; then
+    output_name="${output_name}.exe"
+  fi
 
-    echo "Building ${GOOS}/${GOARCH}..."
+  echo "Building ${GOOS}/${GOARCH}..."
 
-    CGO_ENABLED=0 GOOS="${GOOS}" GOARCH="${GOARCH}" go build \
-        -ldflags="-s -w -X main.Version=${VERSION}" \
-        -o "${OUTPUT_DIR}/${output_name}" \
-        "${MODULE_PATH}"
+  CGO_ENABLED=0 GOOS="${GOOS}" GOARCH="${GOARCH}" go build \
+    -ldflags="-s -w -X main.Version=${VERSION}" \
+    -o "${OUTPUT_DIR}/${output_name}" \
+    "${MODULE_PATH}"
 done
 
 echo ""
@@ -65,9 +65,9 @@ echo ""
 echo "Creating checksums..."
 cd "${OUTPUT_DIR}"
 if command -v sha256sum &> /dev/null; then
-    sha256sum ctx-* > checksums.txt
+  sha256sum ctx-* > checksums.txt
 elif command -v shasum &> /dev/null; then
-    shasum -a 256 ctx-* > checksums.txt
+  shasum -a 256 ctx-* > checksums.txt
 fi
 cd ..
 

hack/start-dogfood.sh

@@ -138,7 +138,8 @@ echo ""
 if [ -d "${SOURCE_DIR}/specs" ]; then
   echo "Copying specs/ for reference..."
   cp -r "${SOURCE_DIR}/specs" "./specs"
-  echo -e "${GREEN}Installed:${NC} specs/ ($(find specs -maxdepth 1 -name "*.md" 2>/dev/null | wc -l) spec files)"
+  echo -e "${GREEN}Installed:${NC} specs/ \
+    ($(find specs -maxdepth 1 -name "*.md" 2>/dev/null | wc -l) spec files)"
   echo ""
 fi
 

internal/cli/add.go

@@ -73,7 +73,7 @@ func runAdd(cmd *cobra.Command, args []string) error {
 
 	filePath := filepath.Join(contextDirName, fileName)
 
-	// Check if file exists
+	// Check if the file exists
 	if _, err := os.Stat(filePath); os.IsNotExist(err) {
 		return fmt.Errorf("context file %s not found. Run 'ctx init' first", filePath)
 	}

internal/cli/agent.go

@@ -8,6 +8,7 @@ package cli
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	"regexp"
 	"strings"
@@ -59,10 +60,11 @@ type AgentPacket struct {
 	Decisions    []string `json:"decisions"`
 }
 
-func runAgent(cmd *cobra.Command, args []string) error {
+func runAgent(cmd *cobra.Command, _ []string) error {
 	ctx, err := context.Load("")
 	if err != nil {
-		if _, ok := err.(*context.NotFoundError); ok {
+		var notFoundError *context.NotFoundError
+		if errors.As(err, &notFoundError) {
 			return fmt.Errorf("no .context/ directory found. Run 'ctx init' first")
 		}
 		return err
@@ -151,7 +153,7 @@ func outputAgentMarkdown(cmd *cobra.Command, ctx *context.Context) error {
 }
 
 func getReadOrder(ctx *context.Context) []string {
-	order := []string{}
+	var order []string
 	for _, name := range fileReadOrder {
 		for _, f := range ctx.Files {
 			if f.Name == name && !f.IsEmpty {
@@ -200,7 +202,7 @@ func extractRecentDecisions(ctx *context.Context, limit int) []string {
 }
 
 func extractCheckboxItems(content string) []string {
-	re := regexp.MustCompile(`(?m)^-\s*\[[ x]\]\s*(.+)$`)
+	re := regexp.MustCompile(`(?m)^-\s*\[[ x]]\s*(.+)$`)
 	matches := re.FindAllStringSubmatch(content, -1)
 	items := make([]string, 0, len(matches))
 	for _, m := range matches {
@@ -210,7 +212,7 @@ func extractCheckboxItems(content string) []string {
 }
 
 func extractUncheckedTasks(content string) []string {
-	re := regexp.MustCompile(`(?m)^-\s*\[\s*\]\s*(.+)$`)
+	re := regexp.MustCompile(`(?m)^-\s*\[\s*]\s*(.+)$`)
 	matches := re.FindAllStringSubmatch(content, -1)
 	items := make([]string, 0, len(matches))
 	for _, m := range matches {
@@ -237,7 +239,7 @@ func extractBulletItems(content string, limit int) []string {
 }
 
 func extractDecisionTitles(content string, limit int) []string {
-	re := regexp.MustCompile(`(?m)^##\s+\[[\d-]+\]\s*(.+)$`)
+	re := regexp.MustCompile(`(?m)^##\s+\[[\d-]+]\s*(.+)$`)
 	matches := re.FindAllStringSubmatch(content, -1)
 	items := make([]string, 0, limit)
 	// Get the most recent (last) decisions

internal/cli/compact.go

@@ -7,6 +7,7 @@
 package cli
 
 import (
+	"errors"
 	"fmt"
 	"os"
 	"path/filepath"
@@ -47,10 +48,11 @@ Use --archive to create .context/archive/ for old content.`,
 	return cmd
 }
 
-func runCompact(cmd *cobra.Command, args []string) error {
+func runCompact(cmd *cobra.Command, _ []string) error {
 	ctx, err := context.Load("")
 	if err != nil {
-		if _, ok := err.(*context.NotFoundError); ok {
+		var notFoundError *context.NotFoundError
+		if errors.As(err, &notFoundError) {
 			return fmt.Errorf("no .context/ directory found. Run 'ctx init' first")
 		}
 		return err
@@ -120,7 +122,7 @@ func compactTasks(cmd *cobra.Command, ctx *context.Context, archive bool) (int,
 	content := string(tasksFile.Content)
 	lines := strings.Split(content, "\n")
 
-	completedPattern := regexp.MustCompile(`^-\s*\[x\]\s*(.+)$`)
+	completedPattern := regexp.MustCompile(`^-\s*\[x]\s*(.+)$`)
 
 	var completedTasks []string
 	var newLines []string
@@ -140,7 +142,7 @@ func compactTasks(cmd *cobra.Command, ctx *context.Context, archive bool) (int,
 			inCompletedSection = false
 		}
 
-		// If completed task outside Completed section, collect it
+		// If completed task outside the Completed section, collect it
 		if !inCompletedSection && completedPattern.MatchString(line) {
 			matches := completedPattern.FindStringSubmatch(line)
 			if len(matches) > 1 {
@@ -216,7 +218,7 @@ func removeEmptySections(content string) (string, int) {
 
 		// Check if this is a section header
 		if strings.HasPrefix(line, "## ") {
-			// Look ahead to see if section is empty
+			// Look ahead to see if the section is empty
 			sectionStart := i
 			i++
 
@@ -225,7 +227,7 @@ func removeEmptySections(content string) (string, int) {
 				i++
 			}
 
-			// Check if we hit another section or end of file
+			// Check if we hit another section or end of the file
 			if i >= len(lines) || strings.HasPrefix(lines[i], "## ") || strings.HasPrefix(lines[i], "# ") {
 				// Section is empty, skip it
 				removed++
@@ -269,7 +271,7 @@ func preCompactAutoSave(cmd *cobra.Command) error {
 	// Build minimal session content
 	content := buildPreCompactSession(now)
 
-	// Write file
+	// Write the file
 	if err := os.WriteFile(filePath, []byte(content), 0644); err != nil {
 		return fmt.Errorf("failed to write session file: %w", err)
 	}

internal/cli/complete.go

@@ -56,7 +56,7 @@ func runComplete(cmd *cobra.Command, args []string) error {
 
 	// Parse tasks and find matching one
 	lines := strings.Split(string(content), "\n")
-	taskPattern := regexp.MustCompile(`^(\s*)-\s*\[\s*\]\s*(.+)$`)
+	taskPattern := regexp.MustCompile(`^(\s*)-\s*\[\s*]\s*(.+)$`)
 
 	var taskNumber int
 	isNumber := false

internal/cli/drift.go

@@ -8,6 +8,7 @@ package cli
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	"time"
 
@@ -54,10 +55,11 @@ type DriftJSONOutput struct {
 	Passed     []string      `json:"passed"`
 }
 
-func runDrift(cmd *cobra.Command, args []string) error {
+func runDrift(cmd *cobra.Command, _ []string) error {
 	ctx, err := context.Load("")
 	if err != nil {
-		if _, ok := err.(*context.NotFoundError); ok {
+		var notFoundError *context.NotFoundError
+		if errors.As(err, &notFoundError) {
 			return fmt.Errorf("no .context/ directory found. Run 'ctx init' first")
 		}
 		return err
@@ -118,9 +120,9 @@ func outputDriftText(cmd *cobra.Command, report *drift.Report) error {
 		cmd.Printf("%s WARNINGS (%d)\n\n", yellow("⚠️ "), len(report.Warnings))
 
 		// Group by type
-		pathRefs := []drift.Issue{}
-		staleness := []drift.Issue{}
-		other := []drift.Issue{}
+		var pathRefs []drift.Issue
+		var staleness []drift.Issue
+		var other []drift.Issue
 
 		for _, w := range report.Warnings {
 			switch w.Type {

internal/cli/load.go

@@ -7,6 +7,7 @@
 package cli
 
 import (
+	"errors"
 	"fmt"
 	"sort"
 	"strings"
@@ -62,10 +63,11 @@ var fileReadOrder = []string{
 	"AGENT_PLAYBOOK.md",
 }
 
-func runLoad(cmd *cobra.Command, args []string) error {
+func runLoad(cmd *cobra.Command, _ []string) error {
 	ctx, err := context.Load("")
 	if err != nil {
-		if _, ok := err.(*context.NotFoundError); ok {
+		var notFoundError *context.NotFoundError
+		if errors.As(err, &notFoundError) {
 			return fmt.Errorf("no .context/ directory found. Run 'ctx init' first")
 		}
 		return err
@@ -110,15 +112,15 @@ func outputAssembled(cmd *cobra.Command, ctx *context.Context, budget int) error
 			continue
 		}
 
-		// Check if we have budget for this file
+		// Check if we have the budget for this file
 		fileTokens := f.Tokens
 		if tokensUsed+fileTokens > budget {
-			// Add truncation notice
+			// Add a truncation notice
 			sb.WriteString(fmt.Sprintf("\n---\n\n*[Truncated: %s and remaining files excluded due to token budget]*\n", f.Name))
 			break
 		}
 
-		// Add file section
+		// Add the file section
 		sb.WriteString(fmt.Sprintf("## %s\n\n", fileNameToTitle(f.Name)))
 		sb.Write(f.Content)
 		if !strings.HasSuffix(string(f.Content), "\n") {