Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importer calling FabIO #8

Open
briantoby opened this issue Apr 5, 2024 · 4 comments
Open

Importer calling FabIO #8

briantoby opened this issue Apr 5, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed In progress this is being addressed but is not complete

Comments

@briantoby
Copy link
Collaborator

FabIO reads lots of image types that GSAS-II does not. An importer could call FabIO. This requires matching FabIO metadata reporting to the GSAS-II input needs.

@briantoby
Copy link
Collaborator Author

@briantoby: note 3/7/24 e-mail from Siwei Chen

@kif
Copy link

kif commented Jul 11, 2024

If you need a hand ... I could probably help.

@briantoby
Copy link
Collaborator Author

briantoby commented Jul 11, 2024

i would love to get some help on this. My thought is that I open a branch for this and outline a new importer. Once I do that, it will be more clear what is needed (which will be to map output from FabIO into places where GSAS-II needs the input.)

I'll try to get to this soon, but it might take a week...

@briantoby briantoby added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 11, 2024
@briantoby
Copy link
Collaborator Author

briantoby commented Jul 29, 2024

@kif A week was only a bit optimistic, but I wanted to change the way that Importers report errors for needed packages and provide a mechanism for installing them from the GUI (since I don't think most users can manage conda or pip directly.) Also, I have updated the doc's on how importers are expected to work (https://gsas-ii.readthedocs.io/en/latest/imports.html#writing-an-importer-routine).

In any case, I have created a branch (FabIO) with a shell for a new importer, https://github.com/AdvancedPhotonSource/GSAS-II/blob/FabIO/GSASII/imports/G2img_FabIO.py. If you would be willing to take a stab at filling out that code, it would be very much appreciated. You might want to fork it and create a PR so we can both work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed In progress this is being addressed but is not complete
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants