Merge pull request #16 from gnustep/TShelf_cleanup

Tabbed Shelf Icon cleanup - split  with proper inheritance, cleanup of now common code and cleanup of the View. Uniform drag-drop operations.

Author: rmottola

GWorkspace/Desktop/Dock/DockIcon.m

@@ -312,7 +312,7 @@ - (void)mouseDown:(NSEvent *)theEvent
 				     NSLeftMouseUpMask | NSLeftMouseDraggedMask];
 
 	if ([nextEvent type] == NSLeftMouseUp) {
-	  [[self window] postEvent: nextEvent atStart: NO];
+	  [[self window] postEvent: nextEvent atStart: YES];
 	  [self unselect];
 	  break;
 

GWorkspace/Desktop/GWDesktopIcon.m

@@ -120,7 +120,7 @@ - (void)mouseDown:(NSEvent *)theEvent
 			     NSLeftMouseUpMask | NSLeftMouseDraggedMask];
 
           if ([nextEvent type] == NSLeftMouseUp) {
-            [win postEvent: nextEvent atStart: NO];
+            [win postEvent: nextEvent atStart: YES];
             break;
 
           } else if (([nextEvent type] == NSLeftMouseDragged)

GWorkspace/GNUmakefile.in

@@ -95,9 +95,10 @@ Finder/LiveSearch/LSFEditor.m \
 TShelf/TShelfWin.m \
 TShelf/TShelfView.m \
 TShelf/TShelfViewItem.m \
-TShelf/TShelfIconsView.m \
 TShelf/TShelfIcon.m \
+TShelf/TShelfFileIcon.m \
 TShelf/TShelfPBIcon.m \
+TShelf/TShelfIconsView.m \
 Preferences/PrefController.m \
 Preferences/DefEditorPref.m \
 Preferences/XTermPref.m \

GWorkspace/TShelf/TShelfFileIcon.h

@@ -0,0 +1,68 @@
+/* TShelfIcon.h
+ *  
+ * Copyright (C) 2003-2021 Free Software Foundation, Inc.
+ *
+ * Authors: Enrico Sersale <[email protected]>
+ *          Riccardo Mottola <[email protected]>
+ * Date: November 2021
+ *
+ * This file is part of the GNUstep GWorkspace application
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ * 
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ * 
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111 USA.
+ */
+
+#ifndef TSHELF_FILEICON_H
+#define TSHELF_FILEICON_H
+
+#import "TShelfIcon.h"
+
+@class FSNode;
+@class FSNodeRep;
+@class GWorkspace;
+
+@interface TShelfFileIcon : TShelfIcon
+{
+  NSMutableArray *paths;
+  NSString *hostname;
+  FSNode *node;
+  BOOL singlepath;
+  BOOL isRootIcon;
+  FSNodeRep *fsnodeRep;
+  NSFileManager *fm;
+  GWorkspace *gw;
+
+  BOOL forceCopy;
+}
+
+- (id)initForPaths:(NSArray *)fpaths
+       inIconsView:(TShelfIconsView *)aview;
+
+- (id)initForPaths:(NSArray *)fpaths
+        atPosition:(NSPoint)pos
+       inIconsView:(TShelfIconsView *)aview;
+
+- (id)initForPaths:(NSArray *)fpaths
+	 gridIndex:(NSUInteger)index
+       inIconsView:(TShelfIconsView *)aview;
+
+- (void)setPaths:(NSArray *)fpaths;
+
+- (NSArray *)paths;
+
+- (BOOL)isSinglePath;
+
+@end
+
+#endif // TSHELF_FILEICON_H