Skip to content

[Tech Debt] google-adk 1.28.0 compatibility — EncryptedStorageSession.get_update_marker() #152

@Alberto-Codes

Description

@Alberto-Codes

Type of Debt

Dependencies — upstream breaking change

Description

google-adk 1.28.0 introduces a new get_update_marker() method on storage session objects. EncryptedStorageSession (in services/models.py) does not implement this method, causing AttributeError when append_event() is called.

AttributeError: 'EncryptedStorageSession' object has no attribute 'get_update_marker'

Discovered when uv lock --upgrade bumped google-adk from 1.26.0 to 1.28.0. The lockfile currently pins 1.26.0, so the locked CI matrix passes, but the latest matrix variant will fail.

Location

  • src/adk_secure_sessions/services/models.pyEncryptedStorageSession class
  • google/adk/sessions/database_session_service.py:666 — upstream call site
  • .github/workflows/ci.ymllatest matrix variant

Impact

  • CI: The test (3.12, latest) and test (3.13, latest) matrix jobs will fail
  • Users: Anyone installing with google-adk>=1.28.0 will hit this on append_event()
  • Lock: We cannot upgrade google-adk past 1.26.0 until this is fixed
  • ADK sentinel tests should catch this — verify they do and add coverage if not

Priority

High — blocks dependency upgrades and breaks CI matrix latest variant.

Fix

Add get_update_marker() to EncryptedStorageSession (likely delegates to the wrapped storage session). Check if any other new methods were added in 1.27.0-1.28.0 that need forwarding.

Checklist

  • Location is clearly identified
  • Impact is documented

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions