From 46a1147e552d413abcf733f8b24a776cd6eaef64 Mon Sep 17 00:00:00 2001 From: Jason Date: Fri, 2 Nov 2018 15:33:08 +0800 Subject: [PATCH 1/2] =?UTF-8?q?=E4=BF=AE=E5=A4=8Dbug?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 当设置了强制更新时, 如果没有授予外部文件读写权限, 则会跳过更新 解决方法: 检查权限之前判断我要写的文件夹是否有读写权限, 如果有, 则直接下载 --- .../allenliu/versionchecklib/core/VersionDialogActivity.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/library/src/main/java/com/allenliu/versionchecklib/core/VersionDialogActivity.java b/library/src/main/java/com/allenliu/versionchecklib/core/VersionDialogActivity.java index 4368d8f..1c68c97 100644 --- a/library/src/main/java/com/allenliu/versionchecklib/core/VersionDialogActivity.java +++ b/library/src/main/java/com/allenliu/versionchecklib/core/VersionDialogActivity.java @@ -228,6 +228,11 @@ protected void downloadFile() { protected void requestPermissionAndDownloadFile() { + // if dir is writable, skip checking permission + if (new File(versionParams.getDownloadAPKPath()).canWrite()) { + Log.i(TAG, "requestPermissionAndDownloadFile: " + new File(versionParams.getDownloadAPKPath()).canWrite()); + downloadFile(); + } else // Here, thisActivity is the current activity if (ContextCompat.checkSelfPermission(this, Manifest.permission.WRITE_EXTERNAL_STORAGE) From 87b49efffb8fee715337c7fbc99f6606dd65774f Mon Sep 17 00:00:00 2001 From: Jason Date: Fri, 2 Nov 2018 15:41:46 +0800 Subject: [PATCH 2/2] Update VersionDialogActivity.java --- .../allenliu/versionchecklib/core/VersionDialogActivity.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/library/src/main/java/com/allenliu/versionchecklib/core/VersionDialogActivity.java b/library/src/main/java/com/allenliu/versionchecklib/core/VersionDialogActivity.java index 1c68c97..0ace078 100644 --- a/library/src/main/java/com/allenliu/versionchecklib/core/VersionDialogActivity.java +++ b/library/src/main/java/com/allenliu/versionchecklib/core/VersionDialogActivity.java @@ -232,9 +232,9 @@ protected void requestPermissionAndDownloadFile() { if (new File(versionParams.getDownloadAPKPath()).canWrite()) { Log.i(TAG, "requestPermissionAndDownloadFile: " + new File(versionParams.getDownloadAPKPath()).canWrite()); downloadFile(); - } else + } // Here, thisActivity is the current activity - if (ContextCompat.checkSelfPermission(this, + else if (ContextCompat.checkSelfPermission(this, Manifest.permission.WRITE_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) {