Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app_rpt: RPT_ALINKS / RPT_LINKS + associated l->links evalutation #502

Open
mkmer opened this issue Feb 20, 2025 · 1 comment
Open

app_rpt: RPT_ALINKS / RPT_LINKS + associated l->links evalutation #502

mkmer opened this issue Feb 20, 2025 · 1 comment

Comments

@mkmer
Copy link
Collaborator

mkmer commented Feb 20, 2025

While we have addressed the string size for RPT_ALINKS and RPT_LINKS, l->links are still limited to [5120]-1 characters.

In a large network (somewhere around 510 nodes depending on node name sizes) a network node could receive a link list larger than 5120 which will be truncated.

While not critical, evaluation of how the strings are stored and alternative methods should be reviewed at some point.
Reference PR #474 and PR #470

@InterLinked1
Copy link
Member

Personally, I think this is a great candidate for using an ast_str. A fixed size buffer for something that can vary with essentially no bounds doesn't seem appropriate here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants