Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: anvil, stonecutter, grindstone and others #596

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from
Draft

feat: anvil, stonecutter, grindstone and others #596

wants to merge 22 commits into from
+2,205 −513

Conversation

IWareQ
Copy link
Member

@IWareQ IWareQ commented Mar 6, 2025 •
edited
Loading

Container types

  • Anvil
  • Grindstone
  • Stonecutter
  • Cartography Table
  • Loom
  • Smithing Table

Conatiner and block behavior

  • Anvil
  • Grindstone
  • Stonecutter
  • Smithing Table
    • Transform
    • Trim

Other

  • Validating recipes
  • Fix bug: trim pattern on armor cannot saving

Close #174

@IWareQ IWareQ linked an issue Mar 6, 2025 that may be closed by this pull request
feat: anvil, stonecutter, grindstone and other #174
Open
@IWareQ IWareQ self-assigned this Mar 6, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 39.79849% with 478 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../processor/CraftRecipeOptionalActionProcessor.java 0.00% 82 Missing ⚠️
...ontainer/processor/CraftRecipeActionProcessor.java 0.00% 58 Missing ⚠️
...iner/processor/CraftGrindstoneActionProcessor.java 0.00% 54 Missing ⚠️
...n/java/org/allaymc/api/block/BlockPlaceHelper.java 0.00% 26 Missing ⚠️
...ck/component/BlockGrindstoneBaseComponentImpl.java 8.69% 21 Missing ⚠️
...r/block/component/BlockAnvilBaseComponentImpl.java 13.04% 20 Missing ⚠️
...ntainer/processor/TransferItemActionProcessor.java 0.00% 18 Missing ⚠️
...ver/item/component/ItemTrimmableComponentImpl.java 29.16% 16 Missing and 1 partial ⚠️
...ymc/api/container/impl/SmithingTableContainer.java 0.00% 15 Missing ⚠️
.../org/allaymc/api/container/impl/LoomContainer.java 0.00% 14 Missing ⚠️
... and 46 more
Files with missing lines Coverage Δ Complexity Δ
...a/org/allaymc/api/container/FullContainerType.java 91.13% <100.00%> (+2.82%) 5.00 <0.00> (ø)
.../allaymc/api/container/impl/CraftingContainer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...rg/allaymc/api/item/descriptor/ItemDescriptor.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...g/allaymc/api/item/recipe/impl/CraftingRecipe.java 90.00% <ø> (ø) 2.00 <0.00> (ø)
...ymc/api/item/recipe/input/CraftingRecipeInput.java 71.42% <ø> (ø) 10.00 <0.00> (?)
...aymc/api/item/recipe/input/FurnaceRecipeInput.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...main/java/org/allaymc/api/item/type/ItemTypes.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
server/src/main/java/org/allaymc/server/Allay.java 71.15% <100.00%> (+0.56%) 25.00 <0.00> (ø)
...llaymc/server/block/type/BlockTypeInitializer.java 96.41% <100.00%> (+0.13%) 93.00 <7.00> (+7.00)
...nent/BlockEntityBrewingStandBaseComponentImpl.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
... and 74 more

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

smartcmd
smartcmd requested changes Mar 6, 2025
View reviewed changes
Copy link
Member

@smartcmd smartcmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update CHANGELOG.MD (

IWareQ added 2 commits March 6, 2025 21:46
@IWareQ
feat: stonecutter
93d48ee 
refactor: CraftRecipeActionProcessor
@IWareQ
feat: grindstone
e9674c2
@IWareQ IWareQ marked this pull request as draft March 6, 2025 20:29
@IWareQ IWareQ changed the title feat: anvil, stonecutter, grindstone containers type feat: anvil, stonecutter, grindstone and others Mar 7, 2025
IWareQ and others added 16 commits March 7, 2025 15:21
@IWareQ
feat: smithing table (update items to netherite)
36c25f2
@IWareQ
feat: validate recipes
3bcec06
@IWareQ
feat: smithing table trim (wip)
346989b
@IWareQ
fix: CHANGELOG.md
3755087
@smartcmd
Merge branch 'master' into feat/more-containers
7753da6 
# Conflicts:
#	CHANGELOG.md
@smartcmd
refactor: rename ItemStack#isAir() to ItemStack#isEmptyOrAir()
dcd9230
@IWareQ
feat: armor trimming
c06d91b
@smartcmd
feat: add trim_data.json
7b770d0
@smartcmd
Merge remote-tracking branch 'origin/feat/more-containers' into feat/…
becf3f7 
…more-containers
@smartcmd
feat: warn if client try to trim a non-trimble item
2b7d594
@IWareQ
feat: anvil (renaming and repairing)
f28b01d
@IWareQ
fix: warning when item repaired by anvil
22dd353 
doc: correct docs
@IWareQ
feat: anvil damaging
5137b9c
@IWareQ
fix: trimming save
4ed2a8f
@IWareQ
fix: NullPointerException when equip turtle helmet
76e3e43
@IWareQ
feat: ItemRepairableComponent
462d1bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smartcmd smartcmd smartcmd requested changes

Assignees

@IWareQ IWareQ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: anvil, stonecutter, grindstone and other
2 participants
@IWareQ @smartcmd