Skip to content

Commit 3635448

Browse files
authored
Remove trailing whitespace from all .py and .md files (#351)
* Remove trailing whitespace from all .py and .md files * Add automatic trailing whitespace check to CI * Remove a hidden file that shouldn't be there * Revert "Add automatic trailing whitespace check to CI" This reverts commit d14a7b6. * Use a fork of the whitespace-detector that supports filtering by file extension * Fix regex syntax (i hope) * Remove trailing whitespace from files outside the `software` directory * Remove the whitespace linting
1 parent 8bf3132 commit 3635448

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+351
-351
lines changed

.github/ISSUE_TEMPLATE/documentation-issue.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ assignees: ''
99

1010
# Documentation Suggestion
1111

12-
**Describe the issue or suggestion**
12+
**Describe the issue or suggestion**
1313
Text here
1414

15-
**Images**
15+
**Images**
1616
If applicable, add screenshots or photos to help explain your problem.
1717

18-
**Additional context**
18+
**Additional context**
1919
Add any other context about the problem here.

.github/ISSUE_TEMPLATE/hardware-issue.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,21 @@ assignees: ''
99

1010
# Hardware Issue
1111

12-
**Describe the bug**
12+
**Describe the bug**
1313
A clear and concise description of what the bug is.
1414

15-
**To Reproduce**
15+
**To Reproduce**
1616
Steps to reproduce the behavior:
1717
1. Go to '...'
1818
2. Click on '....'
1919
3. Scroll down to '....'
2020
4. See error
2121

22-
**Expected behavior**
22+
**Expected behavior**
2323
A clear and concise description of what you expected to happen.
2424

25-
**Images**
25+
**Images**
2626
If applicable, add screenshots or photos to help explain your problem.
2727

28-
**Additional context**
28+
**Additional context**
2929
Add any other context about the problem here.

.github/ISSUE_TEMPLATE/project-suggestion.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ assignees: ''
99

1010
# Project Suggestion
1111

12-
**Describe your suggestion or idea**
12+
**Describe your suggestion or idea**
1313
Text here
1414

15-
**Images**
15+
**Images**
1616
If applicable, add screenshots or photos to help explain your problem.

.github/ISSUE_TEMPLATE/question.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ assignees: ''
1212
**Ask your question**
1313
Text here
1414

15-
**Images**
15+
**Images**
1616
If applicable, add screenshots or photos to help explain your question.
1717

1818
**Any other comments**

.github/ISSUE_TEMPLATE/software-bug.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,21 @@ assignees: ''
99

1010
# Bug Report
1111

12-
**Describe the bug**
12+
**Describe the bug**
1313
A clear and concise description of what the bug is.
1414

15-
**To Reproduce**
15+
**To Reproduce**
1616
Steps to reproduce the behavior:
1717
1. Go to '...'
1818
2. Click on '....'
1919
3. Scroll down to '....'
2020
4. See error
2121

22-
**Expected behavior**
22+
**Expected behavior**
2323
A clear and concise description of what you expected to happen.
2424

25-
**Images**
25+
**Images**
2626
If applicable, add screenshots or photos to help explain your problem.
2727

28-
**Additional context**
28+
**Additional context**
2929
Add any other context about the problem here.

.github/workflows/continuous_integration.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99

1010
run_tests:
1111
uses: ./.github/workflows/pytest.yml
12-
12+
1313
build_and_publish:
1414
uses: ./.github/workflows/publish_to_pypi.yml
1515
needs: run_tests

README.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ The EuroPi is a fully user reprogrammable module based on the [Raspberry Pi Pico
1818
<a href="https://github.com/Allen-Synthesis/EuroPi/releases/">
1919
<img alt="GitHub release (latest SemVer)" src="https://img.shields.io/github/v/release/Allen-Synthesis/Europi">
2020
</a>
21-
21+
2222
</p>
2323

2424
---
@@ -64,8 +64,8 @@ The EuroPi firmware API documentation can be found at https://allen-synthesis.gi
6464
If you would like to extend any of the features of the EuroPi software, you can view the firmware source code at [europi.py](software/firmware/europi.py).
6565

6666
### Issues
67-
If you find any bugs, either in the software, the hardware, or the documentation, please create an Issue by clicking the 'Issue' tab along the top.
68-
Please feel free to create any issue you see fit, I'll either attempt to fix it or explain it.
67+
If you find any bugs, either in the software, the hardware, or the documentation, please create an Issue by clicking the 'Issue' tab along the top.
68+
Please feel free to create any issue you see fit, I'll either attempt to fix it or explain it.
6969
There are Issue templates available, so please choose whichever is most relevant, depending on if your Issue is a hardware or software bug, if it's a documentation error or suggestion, if it's a question about the project as a whole, or a suggestion about the project as a whole.
7070

7171

@@ -79,9 +79,9 @@ This module, and any documentation included in this repository, is entirely "fre
7979

8080
Anyone is welcome to design their own versions of the idea, or modify my designs.
8181
The only thing I would ask is that you refrain from using the brand name 'Allen Synthesis' on your DIY builds if they have modified my files in any way, just to prevent any confusion if they end up being re-sold or distributed. This is in line with section 8.2 of the CERN license. You may use the brand name if you have simply copied the files from this repository to replicate without modification.
82-
82+
8383
If you have a bug fix or improvement that you think is worth sharing, then feel free to send over any pictures or documentation and it can be merged with the main project!
84-
84+
8585
### Disclaimer
86-
86+
8787
Recreate any of the files found in this repository at your own risk; I will attempt to solve any issues that you might have with my designs, but I can't guarantee that there are not minor bugs in any of the documents, both hardware and software.

contributing.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ When making changes that you intend to contribute to the EuroPi project it's imp
7777

7878
# What to expect during the PR process
7979
A PR will typically progress through the following steps:
80-
80+
8181
1. PR opened by author
8282
2. Reviewers add comments in the form of questions, discussion points, suggestions, and required changes.
8383
3. PR participants discuss the comments
@@ -93,7 +93,7 @@ The PR process is expected to take time, in the range of days to weeks. This rep
9393

9494
## Comment labels
9595

96-
These labels prefix each of the reviewer's comments in order to indicate their intention.
96+
These labels prefix each of the reviewer's comments in order to indicate their intention.
9797

9898
| Label | |
9999
| ----- | - |
@@ -141,7 +141,7 @@ PRs that make changes to documentation, that is `*.md` files or anything in the
141141
### Markdown must render properly on github
142142

143143
The markdown must use [github's markdown style](https://docs.github.com/en/get-started/writing-on-github) and render properly when viewing the project on [github.com/Allen-Synthesis](https://github.com/Allen-Synthesis)
144-
144+
145145
### Api docs must build successfully
146146

147147
The [API doc site](https://allen-synthesis.github.io/EuroPi/) must build successfully. See the [docs readme](/docs/README.md) for more details.
@@ -163,7 +163,7 @@ Just write any labels that apply to your program, including any not listed here
163163

164164
### File Naming
165165

166-
Please use all lowercase and separate words with underscores for your program names. If additional resources are needed, such as image files, a directory with the same name and suffixed with `docs` can be included. e.g. the files associated with a program for a Sample and Hold function would look as follows:
166+
Please use all lowercase and separate words with underscores for your program names. If additional resources are needed, such as image files, a directory with the same name and suffixed with `docs` can be included. e.g. the files associated with a program for a Sample and Hold function would look as follows:
167167

168168
```
169169
software/contrib

frequently_asked_questions.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# FAQ
22

33
### Frequently asked questions about the EuroPi project. If you can't find the answer to your question here, head over to [The Discord](https://discord.gg/JaQwtCnBV5) and ask it in the support channel!
4-
4+
55
#
6-
6+
77
### Topics:
88

99
### [General Questions](#general-questions)

git_help.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
# Making a Pull Request to submit changes or new scripts to the official repository
2-
1+
# Making a Pull Request to submit changes or new scripts to the official repository
2+
33

44
|||
55
| --- | --- |
@@ -29,4 +29,4 @@
2929
||
3030
| Once the Pull Request is merged, tell everyone about your cool new script or change in the Discord server!|[Join the Allen Synthesis Discord](https://discord.gg/JaQwtCnBV5)|
3131
||
32-
32+

hardware/EuroPi/OLED_Stand/readme.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# 3D printed OLED stands
22

3-
A simple small stand for your OLED display. This helps hold it in place while soldering and keeps it snug against the face of the module.
3+
A simple small stand for your OLED display. This helps hold it in place while soldering and keeps it snug against the face of the module.
44

55
> There are two versions of the stand, one for the CPC style OLED and one for the TPH (the Pi Hut) style OLED.
66
@@ -22,9 +22,9 @@ The TPH (the Pi Hut) OLED needs a different stand because it has a chunky connec
2222

2323
<img src="OLED_Stand_Pi_Hut_01.jpg" width="600" title="OLED Pi Hut style">
2424

25-
- Slide your OLED into the groove.
25+
- Slide your OLED into the groove.
2626
- Place the stand with OLED into position on the PCB (hold in place using bluetack).
27-
- Solder the four vertical wires.
27+
- Solder the four vertical wires.
2828

2929
The stand has a notch to avoid certain soldering points. You should keep the stand permanently in your EuroPi for added stability of the screen.
3030

hardware/EuroPi/bill_of_materials.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
# Bill of Materials
22

33
In addition to the Front Panel, Jack PCB, and Pico PCB (bought from Allen Synthesis or a third-party supplier), you will need the following components to complete your build.
4-
You will also need one 3.5mm cable (normal Eurorack patch cable) to perform the calibration process.
5-
6-
Please note that a few of these are multi-packs of components, and there may well be cheaper alternatives if you are doing a single build, so as long as the specification is the same you can get any of these components from any supplier most accessible to you.
4+
You will also need one 3.5mm cable (normal Eurorack patch cable) to perform the calibration process.
75

8-
You can either add each of these components to your basket using whichever suppliers you prefer, or alternatively use the complete [Mouser Shopping Basket](https://www.mouser.co.uk/ProjectManager/ProjectDetail.aspx?AccessID=b8e6a0d666) and then buy the few components that Mouser doesn't stock (Knobs, OLED, and Eurorack Power Cable) elsewhere.
6+
Please note that a few of these are multi-packs of components, and there may well be cheaper alternatives if you are doing a single build, so as long as the specification is the same you can get any of these components from any supplier most accessible to you.
7+
8+
You can either add each of these components to your basket using whichever suppliers you prefer, or alternatively use the complete [Mouser Shopping Basket](https://www.mouser.co.uk/ProjectManager/ProjectDetail.aspx?AccessID=b8e6a0d666) and then buy the few components that Mouser doesn't stock (Knobs, OLED, and Eurorack Power Cable) elsewhere.
99
If buying in bulk there are likely other suppliers that are cheaper - this BOM is compiled for DIY builders aiming to build 1-5 EuroPis at once.
1010

1111
| Component | Quantity | Value | Description | Suggested Supplier
@@ -40,7 +40,7 @@ If buying in bulk there are likely other suppliers that are cheaper - this BOM i
4040
| | 1 | | Raspberry Pi Pico | [The Pi Hut](https://thepihut.com/products/raspberry-pi-pico)<br>[CPC](https://cpc.farnell.com/raspberry-pi/raspberry-pi-pico/raspberry-pi-pico-rp2040-mcu-board/dp/SC17106)<br>[Mouser](https://www.mouser.co.uk/ProductDetail/Raspberry-Pi/SC0915?qs=T%252BzbugeAwjgnLi4azxXVFA%3D%3D)<br>**Note: Any official version of the Raspberry Pi Pico will work (W, H, or WH). Third party RP2040 boards may work, but there is no guarantee - always double check the pinout**
4141

4242
#### Note about OLED
43-
The OLED has two suppliers listed, each with different pin configurations. The module supports either of these two configurations (the most common), but no others, so make sure that the one you buy, wherever you source it, has one of these two configurations.
43+
The OLED has two suppliers listed, each with different pin configurations. The module supports either of these two configurations (the most common), but no others, so make sure that the one you buy, wherever you source it, has one of these two configurations.
4444
It also *must* be 36mm or less. There are some displays which are 38mm wide, which will not only not fit within the width of the module, but will also leave the display off-centre in relation to the panel cutout. You can check the datasheet of any display before you buy to determine the width, but both of the displays listed in the BOM above are the correct 36mm.
4545

4646
![OLED Pin Configurations](https://user-images.githubusercontent.com/79809962/145800121-2c88d73b-b4d2-4196-baa1-8628dc327467.png)

hardware/EuroPi/build_guide.md

+24-24
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
# Build Guide
22

33
#### Introduction
4-
This document will go through the assembly of the EuroPi module.
5-
If you have bought only a Panel + PCB kit, you will need to also buy all of the components found in the [bill of materials](/hardware/EuroPi/bill_of_materials.md).
6-
7-
This build is entirely through-hole (not even any pre-soldered SMD components!) so don't worry if you're fairly new to DIY, these instructions should be all you need to make your module.
8-
9-
This guide should explain every step in enough detail, but there are some things left out for simplicity's sake, such as the fact that after each step any long legs will need to be snipped using your wire snips or scissors. This is only necessary for components with long legs, so resistors, capacitors, and LEDs. You don't need to snip anything off any of the headers, the 7805, the jacks, potentiometers, or IC sockets.
10-
11-
#### Skiff Friendly Build
4+
This document will go through the assembly of the EuroPi module.
5+
If you have bought only a Panel + PCB kit, you will need to also buy all of the components found in the [bill of materials](/hardware/EuroPi/bill_of_materials.md).
6+
7+
This build is entirely through-hole (not even any pre-soldered SMD components!) so don't worry if you're fairly new to DIY, these instructions should be all you need to make your module.
8+
9+
This guide should explain every step in enough detail, but there are some things left out for simplicity's sake, such as the fact that after each step any long legs will need to be snipped using your wire snips or scissors. This is only necessary for components with long legs, so resistors, capacitors, and LEDs. You don't need to snip anything off any of the headers, the 7805, the jacks, potentiometers, or IC sockets.
10+
11+
#### Skiff Friendly Build
1212
There are two options for some of the build, one of which makes the module more skiff friendly (37mm deep as opposed to 45mm). If you wish to make the thinner version, simply click the links that say [Skiff Friendly Option](), and follow the instructions to guide you back into the normal build at the right points. Simply ignore these links if you don't mind the module being slightly deeper.
1313

1414
![1 all](https://user-images.githubusercontent.com/79809962/147943816-3ac2098c-14cf-4fac-8896-1ba1f2c7397f.jpg)
15-
15+
1616
## Required tools
1717
- Soldering Iron + Solder
1818
- Wire Snips / Scissors
@@ -29,7 +29,7 @@ There are two options for some of the build, one of which makes the module more
2929

3030
## Pico PCB
3131

32-
The 'Pico PCB' is the PCB with the outline of the Pico on it.
32+
The 'Pico PCB' is the PCB with the outline of the Pico on it.
3333
The 'front' of the Pico PCB is the side with the actual Raspberry Pi Pico on it, and the 'back' is the side with the transistor outline on it.
3434

3535
|Front|Back|
@@ -178,14 +178,14 @@ The 'front' of the Pico PCB is the side with the actual Raspberry Pi Pico on it,
178178
[Skiff Friendly Option](skiff_friendly_instructions.md#step-2)
179179

180180
#### Solder the 7805 power regulator to the front, with the metal side in line with the white stripe on the PCB
181-
181+
182182
![_DSC2361](https://user-images.githubusercontent.com/79809962/148646604-5add0541-0e27-4e8b-b558-8c35df24b997.jpg)
183183

184184
---
185185

186186
## Jack PCB
187187

188-
The 'Jack PCB' is the remaining board, with the outlines for the front panel components.
188+
The 'Jack PCB' is the remaining board, with the outlines for the front panel components.
189189
The 'front' of the Jack PCB is the side with the OLED, jack, and button outlines, and the 'back' is the side with the OLED configuration diagram.
190190

191191
|Front|Back|
@@ -233,15 +233,15 @@ The 'front' of the Jack PCB is the side with the OLED, jack, and button outlines
233233
---
234234

235235
#### OLED Configuration
236-
There are two pin configurations that the OLED used in this build commonly comes in, which are labelled on the board 'TPH' (The Pi Hut), and 'CPC' (CPC, AliExpress, most other suppliers).
237-
The Pi Hut display is preferable as it does not have pre-soldered headers, so is easier to mount on the board. However the CPC display is still entirely usable.
238-
239-
This configuration setup allows you to tell the module which display you are using, as their pins are ordered differently:
240-
TPH: VCC, GND, SDA, SCL
236+
There are two pin configurations that the OLED used in this build commonly comes in, which are labelled on the board 'TPH' (The Pi Hut), and 'CPC' (CPC, AliExpress, most other suppliers).
237+
The Pi Hut display is preferable as it does not have pre-soldered headers, so is easier to mount on the board. However the CPC display is still entirely usable.
238+
239+
This configuration setup allows you to tell the module which display you are using, as their pins are ordered differently:
240+
TPH: VCC, GND, SDA, SCL
241241
CPC: SDA, SCL, VCC, GND
242-
242+
243243
Don't ask my why there is still not a standard for I²C pin layout in the year 2021, but here we are, and here is how to tell the module which layout you are using:
244-
244+
245245
#### Snip some resistor legs and bend them over the end of something small and round, such as needle-nose pliers
246246
![_DSC2410](https://user-images.githubusercontent.com/79809962/148679661-a7d45646-1bf8-4c26-bbe6-112b9564b67d.jpg)
247247

@@ -259,9 +259,9 @@ Don't ask my why there is still not a standard for I²C pin layout in the year 2
259259

260260
#### Solder the OLED Display to the front
261261
This is quite an awkward operation as the distance the headers need to occupy is not standard to the lengths that 2.54mm headers come in. If you are using a CPC display, your headers are probably pre-soldered, in which case you need to prop the display up somehow while you solder one pin, then go on to solder the rest once you're sure it's straight.
262-
263-
If your display is CPC, the pins will be flush with the PCB if it's at the correct height, which is difficult but possible to solder.
264-
262+
263+
If your display is CPC, the pins will be flush with the PCB if it's at the correct height, which is difficult but possible to solder.
264+
265265
If your display is TPH, you can either solder pins and do it the same way as the CPC method, or use extra-long pin headers instead which will make the soldering process easier, as they will protrude far enough to get a better solder joint.
266266

267267
![_DSC2375](https://user-images.githubusercontent.com/79809962/148646695-8a2f9e91-3963-4d17-b010-45cf7d577ef7.jpg)
@@ -315,7 +315,7 @@ Don't over-tighten so hard that you damage the PCB, but you also don't want this
315315
![_DSC2389](https://user-images.githubusercontent.com/79809962/148646795-981506b6-4cf5-4c02-a21a-cf87ed0cefc4.jpg)
316316

317317

318-
#### Screw all of the nuts on to hold the components to the front panel.
318+
#### Screw all of the nuts on to hold the components to the front panel.
319319
If your potentiometer came with nuts, use them, otherwise just screw on the jacks.
320320
Also pop on the knobs.
321321
![_DSC2390](https://user-images.githubusercontent.com/79809962/148646798-515a2e9f-a8b3-4853-904e-e0e3da5470fc.jpg)
@@ -342,7 +342,7 @@ If there is continuity on any checks where there shouldn't be then make sure you
342342
![_DSC2396](https://user-images.githubusercontent.com/79809962/148646814-3383e7d1-eda9-4995-a31d-01db47aaaa4e.jpg)
343343

344344
Make sure the cable is connected so that the 'key' on the cable slots into the notch on the header, and the red stripe is on the bottom side of the module.
345-
Turn on your power supply and check for any smoke or discolouration of the PCB around the power connector, and immediately unplug if either occur.
345+
Turn on your power supply and check for any smoke or discolouration of the PCB around the power connector, and immediately unplug if either occur.
346346
If all is groovy, the congratulations, you've finished building your EuroPi!
347347

348348
---

hardware/EuroPi/pcb/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
The PCB files are in two file types:
44
- .pcb files, which can be opened in [DesignSpark](https://www.rs-online.com/designspark/pcb-software) free PCB software
55
- .rar files, which are zipped folders containing the Gerber format PCBs. Each entire .rar folder can be dragged and dropped to a PCB manufacturer such as [JLC PCB](https://jlcpcb.com/) (my personal choice)
6-
6+
77
There are two different options for the panel PCB:
88
- Panel, which is made for JLC aluminium production
99
- Black Panel, which is made for FR4 production by any manufacturer

0 commit comments

Comments
 (0)