Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turing_machine.md bug #392

Closed
RDFRIES opened this issue Nov 21, 2024 · 1 comment
Closed

turing_machine.md bug #392

RDFRIES opened this issue Nov 21, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@RDFRIES
Copy link

RDFRIES commented Nov 21, 2024

turingMachine.md says:
cv5: pulse 2 & 4

SHOULD BE:
cv5: pulse 2 & 3

Because, that's whats in the code

@RDFRIES RDFRIES added the documentation Improvements or additions to documentation label Nov 21, 2024
@chrisib
Copy link
Collaborator

chrisib commented Nov 21, 2024

Both are actually saying the same thing. The code:

cv1 - pulse 1 (or config value cv1_pulse_bit)
cv2 - pulse 2 (or config value cv2_pulse_bit)
cv3 - pulse 4 (or config value cv3_pulse_bit)
cv4 - pulse cv1 & cv2
cv5 - pulse cv2 & cv3
cv6 - sequence out

The documentation:

- **cv1:** pulse 1
- **cv2:** pulse 2
- **cv3:** pulse 4
- **cv4:** pulse 1 & 2
- **cv5:** pulse 2 & 4
- **cv6:** sequence out

The markdown file is referring to pulses, but the comment in the code is referring to the CV outputs, which are not the same thing. CV3 outputs Pulse 4, so the comment in the code about CV5 is correct: it outputs Pulse 2 and Pulse 4 (which are individually output on CV2 and CV3).

@chrisib chrisib closed this as completed Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants