Skip to content

Commit 1a10c79

Browse files
committed
bug that delete the newest backups has been fixed
1 parent 28e48bc commit 1a10c79

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

utils.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ func copyFile(srcFile string, dstFile string) error {
130130
func GetBackupsToDelete(backups []Backup, keep int) []Backup {
131131
if len(backups) > keep {
132132
sort.SliceStable(backups, func(i, j int) bool {
133-
return backups[i].Date.Before(backups[j].Date)
133+
return backups[i].Date.After(backups[j].Date)
134134
})
135135
return backups[keep:]
136136
}

utils_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@ func timeParse(s string) time.Time {
1919
func TestGetBackupsToDelete(t *testing.T) {
2020
testData := []Backup{
2121
Backup{Name: "three", Date: timeParse("2019-03-28T19-50-12")},
22+
Backup{Name: "one", Date: timeParse("2019-01-28T19-50-12")},
2223
Backup{Name: "five", Date: timeParse("2019-05-28T19-50-12")},
2324
Backup{Name: "two", Date: timeParse("2019-02-28T19-50-12")},
24-
Backup{Name: "one", Date: timeParse("2019-01-28T19-50-12")},
2525
Backup{Name: "four", Date: timeParse("2019-04-28T19-50-12")},
2626
}
2727
expectedData := []Backup{
28-
Backup{Name: "four", Date: timeParse("2019-04-28T19-50-12")},
29-
Backup{Name: "five", Date: timeParse("2019-05-28T19-50-12")},
28+
Backup{Name: "two", Date: timeParse("2019-02-28T19-50-12")},
29+
Backup{Name: "one", Date: timeParse("2019-01-28T19-50-12")},
3030
}
3131
assert.Equal(t, expectedData, GetBackupsToDelete(testData, 3))
3232
assert.Equal(t, []Backup{}, GetBackupsToDelete([]Backup{testData[0]}, 3))

0 commit comments

Comments
 (0)