feat: allow migration from awesome-copilot to github source types

fix: resolve lint errors in source type migration files

Author: gblanc-1a

apps/vscode-extension/src/adapters/github-adapter.ts

@@ -560,7 +560,7 @@ export class GitHubAdapter extends RepositoryAdapter {
       manifest = await this.fetchManifestWithCache(manifestAsset.url, manifestAsset.name);
     } catch (manifestError) {
       this.logger.warn(`Failed to fetch manifest for ${release.tag_name}: ${manifestError}`);
-      // Continue without manifest data - use fallback values
+      return null;
     }
 
     // Locate the README release asset by the filename recorded in the manifest.

apps/vscode-extension/src/services/hub-manager.ts

@@ -47,6 +47,9 @@ import {
   SchemaValidator,
   ValidationResult,
 } from './schema-validator';
+import {
+  SourceTypeReconciler,
+} from './source-type-reconciler';
 
 const execAsync = promisify(exec);
 
@@ -904,7 +907,7 @@ export class HubManager {
       this.logger.info(`Found ${hubSources.length} sources in hub ${hubId}`);
 
       // Get existing sources to avoid duplicates
-      const existingSources = await this.registryManager.listSources();
+      let existingSources = await this.registryManager.listSources();
 
       let addedCount = 0;
       let skippedCount = 0;
@@ -963,6 +966,42 @@ export class HubManager {
           continue;
         }
 
+        // @migration-cleanup(source-type-migration): Remove this block once all sources have migrated
+        // Detect awesome-copilot → github type change by URL match
+        const typeChangedSource = SourceTypeReconciler.detectTypeChange(hubSource, existingSources);
+        if (typeChangedSource) {
+          this.logger.info(
+            `Detected source type change: ${typeChangedSource.id} (${typeChangedSource.type}) → ${hubSource.type} for URL ${hubSource.url}`
+          );
+
+          try {
+            const reconciler = new SourceTypeReconciler(
+              this.registryManager,
+              this.registryManager.getStorage(),
+              this.storage
+            );
+
+            const reconcileResult = await reconciler.reconcile(
+              typeChangedSource,
+              hubSource,
+              hubId,
+              sourceId
+            );
+
+            existingSources = await this.registryManager.listSources();
+            if (reconcileResult.bundleResults.some((r) => r.success)) {
+              updatedCount++;
+            }
+          } catch (error) {
+            this.logger.error(
+              `Failed to reconcile source type change for ${hubSource.url}`,
+              error as Error
+            );
+          }
+
+          continue;
+        }
+
         // Add new source
         this.logger.info(`Adding new hub source: ${sourceId} (${hubSource.name})`);
 

apps/vscode-extension/src/services/registry-manager.ts

@@ -56,6 +56,7 @@ import {
 } from '../types/settings';
 import {
   BundleIdentityMatcher,
+  extractGitHubMetadata,
 } from '../utils/bundle-identity-matcher';
 import {
   CONCURRENCY_CONSTANTS,
@@ -457,11 +458,36 @@ export class RegistryManager {
     }
 
     const sourceType: SourceType = (installed.sourceType as SourceType) ?? 'local';
-    return BundleIdentityMatcher.matches(
+    const primaryMatch = BundleIdentityMatcher.matches(
       installed.bundleId,
       latest.id,
       sourceType
     );
+
+    if (primaryMatch) {
+      return true;
+    }
+
+    // @migration-cleanup(source-type-migration): Remove this fallback
+    if (sourceType === 'awesome-copilot') {
+      return this.matchesCrossTypeFallback(installed.bundleId, latest);
+    }
+
+    return false;
+  }
+
+  // @migration-cleanup(source-type-migration): Remove with the fallback call sites
+  private matchesCrossTypeFallback(installedBundleId: string, candidate: Bundle): boolean {
+    const source = this.sourcesCache.find((s) => s.id === candidate.sourceId);
+    if (source?.type !== 'github') {
+      return false;
+    }
+    const metadata = source.url ? extractGitHubMetadata(source.url) : undefined;
+    return BundleIdentityMatcher.matchesAwesomeCopilotToGithub(
+      installedBundleId,
+      candidate.id,
+      metadata
+    );
   }
 
   /**
@@ -470,7 +496,8 @@ export class RegistryManager {
    * @param latestBundles
    */
   private findMatchingLatestBundle(installedBundle: InstalledBundle, latestBundles: Bundle[]): Bundle | undefined {
-    return latestBundles.find((lb) => {
+    // Primary match: same source type
+    const primaryMatch = latestBundles.find((lb) => {
       if (installedBundle.sourceType === 'github') {
         return BundleIdentityMatcher.matches(
           installedBundle.bundleId,
@@ -484,6 +511,17 @@ export class RegistryManager {
         return installedBaseId === latestBaseId;
       }
     });
+
+    if (primaryMatch) {
+      return primaryMatch;
+    }
+
+    // @migration-cleanup(source-type-migration): Remove this fallback
+    if (installedBundle.sourceType === 'awesome-copilot') {
+      return latestBundles.find((lb) => this.matchesCrossTypeFallback(installedBundle.bundleId, lb));
+    }
+
+    return undefined;
   }
 
   /**