You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add the o3r eslint config to a monorepo containing an app and a lib, via the following command: ng add @o3r/[email protected].
Run this command 3 times:
In the app.
In the lib.
At root level.
Current result
The lint script is missing from both the app and the lib package.json files. As a result, running npm run lint at root level does not lint anything (because it runs a lerna run lint, which does not find the packages scripts).
The lintFilePatterns values in angular.json are set to "[...]/src/**/*.ts", which results in linting only .ts files.
The generated root tsconfig.eslint.json file extends ./tsconfig, but in my case the base tsconfig file is ./tsconfig.base.
In the package.json file, the following generated dep uses "latest" version: "yaml-eslint-parser": "latest".
Expected result
We should generate a lint script in each app and lib to which we add the eslint config, containing "lint": "ng lint <package-name>".
We should set the lintFilePatterns values in angular.json to the following value:
Package name
eslint-config-otter
Package version
11.6.0-rc.2
Reproduction steps
Add the o3r eslint config to a monorepo containing an app and a lib, via the following command:
ng add @o3r/[email protected]
.Run this command 3 times:
Current result
lint
script is missing from both the app and the libpackage.json
files. As a result, runningnpm run lint
at root level does not lint anything (because it runs alerna run lint
, which does not find the packages scripts).lintFilePatterns
values inangular.json
are set to"[...]/src/**/*.ts"
, which results in linting only.ts
files.tsconfig.eslint.json
file extends./tsconfig
, but in my case the base tsconfig file is./tsconfig.base
.package.json
file, the following generated dep uses "latest" version:"yaml-eslint-parser": "latest"
.Expected result
lint
script in each app and lib to which we add the eslint config, containing"lint": "ng lint <package-name>"
.lintFilePatterns
values inangular.json
to the following value:tsconfig.eslint.json
file extend it, instead of hard coding./tsconfig
?"yaml-eslint-parser": "^1.2.2"
.Additional comments
No response
The text was updated successfully, but these errors were encountered: