feat(renovate): split trunk-base and release branches strategies #2743
Conversation
kpanot
force-pushed
the
feature/renovate-branching-model
branch
from
3819087 to
3462963
Compare
|
View your CI Pipeline Execution ↗ for commit 3d917d0.
☁️ Nx Cloud last updated this comment at |
| "packageRules": [ | ||
| { | ||
| // TODO: replace the following matchers to `matchManagers` when https://github.com/renovatebot/renovate/issues/21760 is fixed | ||
| "matchDatasources": [ |
There was a problem hiding this comment.
Why do we remove these lines from the preset?
There was a problem hiding this comment.
It is not exactly removed, it is part of rules on node-version in release-branches.json
.renovaterc.json5
Outdated
| }, | ||
| { | ||
| // TODO: replace the following matchers to `matchManagers` when https://github.com/renovatebot/renovate/issues/21760 is fixed | ||
| "matchDatasources": [ | ||
| "node-version" | ||
| ], | ||
| "matchFileNames": [ | ||
| "**/.github/workflows/**/*.y{a,}ml", | ||
| "**/__dot__github/workflows/**/*.y{a,}ml", | ||
| "**/__empty__.github/workflows/**/*.y{a,}ml", | ||
| "**/action.y{a,}ml" | ||
| ], | ||
| "enable": true |
There was a problem hiding this comment.
why do we need that in our config, does that mean it's needed for all applications using our presets ?
There was a problem hiding this comment.
Not needed indeed, I moved it here temporary and forgot to re-update this file :S
There was a problem hiding this comment.
isn't it still needed in the preset release-branches though? if we want the node upgrades on main branch
There was a problem hiding this comment.
we no longer have an issue with renovatebot/renovate#21760 ?
There was a problem hiding this comment.
Still have it but as the I prefer to keep the release-branches as JSON (to not enforce the user to add the extension), I will add a point in a readme file instead
kpanot
force-pushed
the
feature/renovate-branching-model
branch
from
3462963 to
0e584ca
Compare
feat(renovate): register node-version update in base
kpanot
force-pushed
the
feature/renovate-branching-model
branch
from
0e584ca to
3d917d0
Compare
There was a problem hiding this comment.
not necessarily linked to this PR but it would be nice to group this upgrade and the npm upgrade of @types/node in the same group
Proposed change
feat(renovate): split trunk-base and release branches strategies
feat(renovate): register node-version update in base
Related issues
github-node-version.json5rule to thebaserule #2712