forked from microsoft/FluidFramework
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathlayerGraph.ts
524 lines (454 loc) · 18.6 KB
/
layerGraph.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
/*!
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License.
*/
import { strict as assert } from "assert";
import { logVerbose } from "../common/logging";
import { Package, Packages } from "../common/npmPackage";
import { EOL as newline } from "os";
import * as path from "path";
interface ILayerInfo {
deps?: string[];
packages?: string[];
dirs?: string[];
dev?: true;
dot?: false;
dotSameRank?: true;
};
interface ILayerGroupInfo {
dot?: false;
dotSameRank?: true;
dotGroup?: false;
layers: { [key: string]: ILayerInfo }
}
interface ILayerInfoFile {
[key: string]: ILayerGroupInfo
};
class BaseNode {
constructor(public readonly name: string) { }
public get dotName() {
return this.name.replace(/-/g, "_").toLowerCase();
}
};
class LayerNode extends BaseNode {
public packages = new Set<PackageNode>();
private allowedDependentPackageNodes = new Set<PackageNode>();
private allowedDependentLayerNodes: LayerNode[] = [];
constructor(
name: string,
public readonly layerInfo: ILayerInfo,
private readonly groupNode: GroupNode
) {
super(name);
}
public get doDot() {
if (this.layerInfo.dot !== undefined) { return this.layerInfo.dot; }
return !this.isDev && this.groupNode.doDot;
}
private get dotSameRank() {
// default to false
return this.layerInfo.dotSameRank ?? false;
}
public get isDev() {
// default to false
return this.layerInfo.dev ?? false;
}
/**
* Record that the given package is part of this layer
*/
public addPackage(packageNode: PackageNode) {
this.packages.add(packageNode);
}
/**
* Record that packages in this layer are allowed to depend on the given package
*/
public addAllowedDependentPackageNode(dep: PackageNode) {
this.allowedDependentPackageNodes.add(dep);
}
/**
* Record that packages in this layer are allowed to depend on packages in the given layer
*/
public addAllowedDependentLayerNode(dep: LayerNode) {
this.allowedDependentLayerNodes.push(dep);
}
public generateDotSubgraph() {
if (!this.doDot) { return ""; }
const nodes = Array.from(this.packages.values(), packageNode => `"${packageNode.dotName}"`);
if (this.packages.size < 2) {
return `\n ${nodes.join("\n ")}`;
}
const sameRank = this.dotSameRank ? "\n rank=\"same\"" : "";
return `
subgraph cluster_${this.dotName} {
label = "${this.dotName}"${sameRank}
${nodes.join("\n ")}
}`;
}
/**
* Verify that this layer is allowed to depend on the given PackageNode
*/
public verifyDependent(dep: PackageNode) {
if (this.packages.has(dep)) {
logVerbose(`Found: ${dep.name} in ${this.name}`);
return true;
}
if (this.allowedDependentPackageNodes.has(dep)) {
logVerbose(`Found: ${dep.name} in ${this.name}`);
return true;
}
for (const node of this.allowedDependentLayerNodes) {
logVerbose(`Traversing: ${this.name} -> ${node.name}`);
if (node.verifyDependent(dep)) {
return true;
}
}
return false;
}
};
/** Used for traversing the layer dependency graph */
type LayerDependencyNode = { node: LayerNode, childrenToVisit: (LayerNode | undefined)[], orderedChildren: LayerNode[] };
class GroupNode extends BaseNode {
public layerNodes: LayerNode[] = [];
constructor(name: string, private readonly groupInfo: ILayerGroupInfo) {
super(name);
}
public get doDot() {
// default to true
return this.groupInfo.dot ?? true;
}
private get dotSameRank() {
// default to false
return this.groupInfo.dotSameRank ?? false;
}
private get dotGroup() {
// default to true
return this.groupInfo.dotGroup ?? true;
}
public createLayerNode(name: string, layerInfo: ILayerInfo) {
const layerNode = new LayerNode(name, layerInfo, this);
this.layerNodes.push(layerNode);
return layerNode;
}
public generateDotSubgraph() {
const sameRank = this.dotSameRank ? "\n rank=\"same\"" : "";
const subGraphs = this.layerNodes.map(layerNode => layerNode.generateDotSubgraph()).join("");
if (!this.dotGroup) {
return subGraphs;
}
return `
subgraph cluster_group_${this.dotName} {
label = "${this.dotName}"${sameRank}
${subGraphs}
}`;
}
};
class PackageNode extends BaseNode {
private _pkg: Package | undefined;
private readonly _childDependencies: PackageNode[] = [];
private readonly depParents: PackageNode[] = [];
private _indirectDependencies: Set<PackageNode> | undefined;
private _level: number | undefined;
constructor(name: string, public readonly layerNode: LayerNode) {
super(name);
}
public get layerName() {
return this.layerNode.name;
}
public get isDev() {
return this.layerNode.isDev;
}
public get doDot() {
return this.layerNode.doDot;
}
public verifyDependent(dep: PackageNode) {
return this.layerNode.verifyDependent(dep);
}
public get dotName() {
return this.name.replace(/@fluidframework\//i, "").replace(/@fluid-internal\//i, "");
}
public get pkg() {
if (!this._pkg) { throw new Error(`ERROR: Package missing from PackageNode ${this.name}`); }
return this._pkg;
}
public set pkg(pkg: Package) {
if (this._pkg) { throw new Error(`ERROR: Package assigned twice to a PackageNode ${this.name}`); }
this._pkg = pkg;
}
public initializedDependencies(packageNodeMap: Map<string, PackageNode>) {
for (const dep of this.pkg.dependencies) {
const depPackageNode = packageNodeMap.get(dep);
if (depPackageNode) {
this._childDependencies.push(depPackageNode);
depPackageNode.depParents.push(this);
}
}
}
/** Packages this package is directly dependent upon */
public get childDependencies(): Readonly<PackageNode[]> {
return this._childDependencies;
}
/** Packages this package is indirectly dependent upon */
public get indirectDependencies(): Set<PackageNode> {
if (this._indirectDependencies === undefined) {
// NOTE: recursive isn't great, but the graph should be small enough
this._indirectDependencies = this._childDependencies.reduce<Set<PackageNode>>((accum, childPackage) => {
childPackage.childDependencies.forEach(pkg => accum.add(pkg));
childPackage.indirectDependencies.forEach(pkg => accum.add(pkg));
return accum;
}, new Set<PackageNode>());
}
return this._indirectDependencies;
}
public get level(): number {
if (this._level === undefined) {
this._level = this._childDependencies.reduce<number>((accum, childPackage) => {
return Math.max(accum, childPackage.level + 1);
}, 0);
}
return this._level;
}
};
export class LayerGraph {
private groupNodes: GroupNode[] = [];
private layerNodeMap = new Map<string, LayerNode>();
private packageNodeMap = new Map<string, PackageNode>();
private dirMapping: { [key: string]: LayerNode } = {};
private createPackageNode(name: string, layer: LayerNode) {
if (this.packageNodeMap.get(name)) {
throw new Error(`ERROR: Duplicate package layer entry ${name}`);
}
const packageNode = new PackageNode(name, layer);
this.packageNodeMap.set(name, packageNode);
layer.addPackage(packageNode);
return packageNode;
}
private constructor(root: string, layerInfo: ILayerInfoFile, packages: Packages) {
this.initializeLayers(root, layerInfo);
this.initializePackages(packages);
}
private initializeLayers(root: string, layerInfo: ILayerInfoFile) {
// First pass get the layer nodes
for (const groupName of Object.keys(layerInfo)) {
const groupInfo = layerInfo[groupName];
const groupNode = new GroupNode(groupName, groupInfo);
this.groupNodes.push(groupNode);
for (const layerName of Object.keys(groupInfo.layers)) {
const layerInfo = groupInfo.layers[layerName];
const layerNode = groupNode.createLayerNode(layerName, layerInfo);
this.layerNodeMap.set(layerName, layerNode);
if (layerInfo.dirs) {
layerInfo.dirs.forEach(dir => this.dirMapping[path.resolve(root, dir)] = layerNode);
}
if (layerInfo.packages) {
layerInfo.packages.forEach(pkg => this.createPackageNode(pkg, layerNode));
}
}
}
// Wire up the allowed dependents
for (const groupNode of this.groupNodes) {
for (const layerNode of groupNode.layerNodes) {
if (!layerNode.layerInfo.deps) { continue; }
for (const depName of layerNode.layerInfo.deps) {
const depLayer = this.layerNodeMap.get(depName);
if (depLayer) {
layerNode.addAllowedDependentLayerNode(depLayer);
} else {
const depPackage = this.packageNodeMap.get(depName);
if (depPackage === undefined) {
throw new Error(`Missing package entry for dependency ${depName} in ${layerNode.name}`);
}
layerNode.addAllowedDependentPackageNode(depPackage);
}
}
}
}
}
private initializePackages(packages: Packages) {
this.initializePackageMatching(packages);
this.initializeDependencies();
}
private initializePackageMatching(packages: Packages) {
// Match the packages to the node if it is not explicitly specified
for (const pkg of packages.packages) {
const packageNode = this.packageNodeMap.get(pkg.name);
if (packageNode) {
packageNode.pkg = pkg;
continue;
}
let matched = false;
for (const dir of Object.keys(this.dirMapping)) {
if (pkg.directory.startsWith(dir)) {
const layerNode = this.dirMapping[dir];
logVerbose(`${pkg.nameColored}: matched with ${layerNode.name} (${dir})`);
const packageNode = this.createPackageNode(pkg.name, layerNode);
packageNode.pkg = pkg;
matched = true;
break;
}
}
if (!matched) {
throw new Error(`${pkg.nameColored}: ERROR: Package doesn't match any directories. Unable to do dependency check`);
}
}
}
private initializeDependencies() {
for (const packageNode of this.packageNodeMap.values()) {
packageNode.initializedDependencies(this.packageNodeMap);
}
}
private forEachDependencies(exec: (src: PackageNode, dest: PackageNode) => boolean) {
let success = true;
// Go thru the packages and check for dependency violation
for (const packageNode of this.packageNodeMap.values()) {
for (const depPackageNode of packageNode.childDependencies) {
if (!exec(packageNode, depPackageNode)) {
success = false;
}
}
}
return success;
}
public verify() {
return this.forEachDependencies((packageNode, depPackageNode) => {
if (packageNode.isDev) {
// Don't check dependency on test packages
return true;
}
let success = true;
if (depPackageNode.isDev) {
console.error(`${packageNode.pkg.nameColored}: error: dev packages appearing in package dependencies instead of devDependencies - ${depPackageNode.name}, `);
success = false;
}
logVerbose(`${packageNode.pkg.nameColored}: checking ${depPackageNode.name} from ${packageNode.layerName}`);
if (!packageNode.verifyDependent(depPackageNode)) {
console.error(`${packageNode.pkg.nameColored}: error: Dependency layer violation ${depPackageNode.name}, "${packageNode.layerName}" -> "${depPackageNode.layerName}"`);
success = false;
}
return success;
});
}
public generateDotGraph() {
const dotEdges: string[] = [];
this.forEachDependencies((packageNode, depPackageNode) => {
if (packageNode.doDot && !packageNode.indirectDependencies.has(depPackageNode)) {
const suffix = packageNode.indirectDependencies.has(depPackageNode) ? " [constraint=false color=lightgrey]" :
(packageNode.layerNode != depPackageNode.layerNode && packageNode.level - depPackageNode.level > 3) ? " [constraint=false]" : "";
dotEdges.push(`"${packageNode.dotName}"->"${depPackageNode.dotName}"${suffix}`);
}
return true;
});
const dotGraph =
`strict digraph G { graph [ newrank=true; ranksep=2; compound=true ]; ${this.groupNodes.map(group => group.generateDotSubgraph()).join("")}
${dotEdges.join("\n ")}
}`;
return dotGraph;
}
private padArraysToSameLength(a: string[], b: string[], val: string) {
while (a.length !== b.length) {
if (a.length < b.length) {
a.push(val);
}
else {
b.push(val);
}
}
}
/**
* The root is a layer with no unvisited child dependencies.
* We'll add it to orderedLayers, and remove it from all other layers'
* childrenToVisit, to uncover new roots and recurse.
* Nothing is returned, but orderedLayers grows with each recursive call.
*/
private traverseSubgraph(
root: LayerDependencyNode,
allLayers: LayerDependencyNode[],
orderedLayers: LayerDependencyNode[],
) {
// Prevent re-entrancy
if (orderedLayers.find((l) => l.node.name === root.node.name)) {
return;
}
orderedLayers.push(root);
// Move this root from childrenToVisit to orderedChildren if present
// This will create at least one new root (i.e. it has no unvisited dependencies)
allLayers
.forEach((l) => {
const foundIdx = l.childrenToVisit.findIndex((child) => child?.name === root.node.name);
if (foundIdx >= 0) {
l.orderedChildren.push(l.childrenToVisit[foundIdx]!);
l.childrenToVisit[foundIdx] = undefined;
}
});
// Recurse for every layer with no more unvisited dependencies itself (i.e. now a root itself)
allLayers
.filter((l) => l.childrenToVisit.every((c) => !c)) // Also accepts empty childrenToVisit
.forEach((newRoot) => this.traverseSubgraph(newRoot, allLayers, orderedLayers));
}
/**
* Returns the list of all layers, ordered such that
* all dependencies for a given layer appear earlier in the list.
*/
private traverseLayerDependencyGraph() {
const layers: LayerDependencyNode[] = []
for (const groupNode of this.groupNodes) {
for (const layerNode of groupNode.layerNodes) {
const childLayers: Set<LayerNode> = new Set();
for (const packageNode of [...layerNode.packages]) {
packageNode.childDependencies.forEach((p) => childLayers.add(p.layerNode));
}
layers.push({
node: layerNode,
childrenToVisit: [...childLayers].filter((l) => l.name !== layerNode.name),
orderedChildren: [],
});
}
}
// We'll traverse in order of least dependencies so orderedLayers will reflect that ordering
const orderedLayers: LayerDependencyNode[] = [];
// Take any "roots" (layers with no child dependencies) and traverse those subgraphs,
// building up orderedLayers as we go
layers
.filter((l) => l.childrenToVisit.length === 0)
.forEach((root) => this.traverseSubgraph(root, layers, orderedLayers));
return orderedLayers;
}
/**
* Generate a markdown-formated list of layers listing their packages and dependencies
*/
public generatePackageLayersMarkdown(repoRoot: string) {
const lines: string[] = [];
let packageCount: number = 0;
for (const layerDepNode of this.traverseLayerDependencyGraph()) {
const layerNode = layerDepNode.node;
lines.push(`### ${layerNode.name}${newline}`);
const packagesInCell: string[] = [];
for (const packageNode of [...layerNode.packages]) {
++packageCount;
const dirRelativePath = "/" + path.relative(repoRoot, packageNode.pkg.directory).replace(/\\/g, "/");
const ifPrivate = packageNode.pkg.isPublished ? "" : " (private)";
packagesInCell.push(`- [${packageNode.name}](${dirRelativePath})${ifPrivate}`);
}
const layersInCell: string[] = [];
for (const childLayer of layerDepNode.orderedChildren) {
layersInCell.push(`- [${childLayer.name}](#${childLayer.name})`);
}
this.padArraysToSameLength(packagesInCell, layersInCell, " ");
lines.push(`| Packages | Layer Dependencies |`);
lines.push(`| --- | --- |`);
lines.push(`| ${packagesInCell.join("</br>")} | ${layersInCell.join("</br>")} |${newline}`);
}
assert(packageCount === this.packageNodeMap.size, "ERROR: Did not find all packages while traversing layers");
const packagesMdContents: string =
`# Package Layers
[//]: <> (This file is generated, please don't edit it manually!)
_These are the logical layers into which our packages are grouped.
The dependencies between layers are enforced by the layer-check command._
${lines.join(newline)}
`;
return packagesMdContents;
}
public static load(root: string, packages: Packages, info?: string) {
const layerInfoFile = require(info ?? path.join(__dirname, "..", "..", "data", "layerInfo.json"));
return new LayerGraph(root, layerInfoFile, packages);
}
};