fix: try to unmarshal notify.url and use it when needed
#750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the
first path segment in URL cannot contain colonwhen passing notifier to scrutiny throughenvvariables.Per the doc, environment-given notifier URLs should be contained in a json array. However, this feature does not work at the time.
To fix this issue, I added a
json.unmarshalonnotify.urlsconfig string. The configuration string is only replaced if the unmarshal has no error, ensuring backward compatibility.Note: I only tested this feature with the docker image, and not the binary. Ensuring the binary work before merging would be best.
This PR closes #745.
Also, thanks for the good work !