Skip to content

Commit 16c19c5

Browse files
authored
Merge branch 'main' into add-image-input-facade
2 parents cf73f41 + 4fc38d1 commit 16c19c5

File tree

3 files changed

+13
-6
lines changed

3 files changed

+13
-6
lines changed

.github/workflows/pull_request.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ name: Build the app
22

33
on:
44
push:
5-
branches: [ master ]
5+
branches: [ main ]
66
pull_request:
7-
branches: [ master ]
7+
branches: [ main ]
88

99
concurrency:
1010
# Only run once for latest commit per ref and cancel other (previous) runs.
@@ -36,4 +36,4 @@ jobs:
3636
run: CI=true sbt +compile
3737

3838
- name: Run tests
39-
run: CI=true sbt +test
39+
run: CI=true sbt +test

build.sbt

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ val sttp = "3.5.0"
3232
val anorm = "2.7.0"
3333
val scalaTestPlusPlay = "6.0.0-M6"
3434
val scalaTestPlusMockito = "3.2.15.0"
35-
val reactAdmin = "4.14.3"
35+
val reactAdmin = "4.14.4"
3636

3737
val consoleDisabledOptions = Seq("-Xfatal-warnings", "-Ywarn-unused", "-Ywarn-unused-import")
3838

spra-web/src/main/scala/net/wiringbits/spra/ui/web/components/ListGuesser.scala

+9-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ object ListGuesser {
2020
val component: FunctionalComponent[Props] = FunctionalComponent[Props] { props =>
2121
val fields = ResponseGuesser.getTypesFromResponse(props.response)
2222

23-
def defaultField(reference: String, source: String)(children: ReactElement*): ReactElement =
23+
def defaultField(reference: String, source: String)(children: ReactElement): ReactElement =
2424
ReferenceField(reference = reference, source = source)(children)
2525

2626
val widgetFields: Seq[ReactElement] = fields.map { field =>
@@ -49,7 +49,14 @@ object ListGuesser {
4949
case ColumnType.Image => Fragment()
5050
case ColumnType.Number => NumberInput(source = field.name)
5151
case ColumnType.Reference(reference, source) =>
52-
defaultField(reference, field.name)(TextField(source = source))
52+
ReferenceInput(
53+
source = field.name,
54+
reference = reference
55+
)(
56+
SelectInput(
57+
optionText = props.response.referenceDisplayField.getOrElse(source)
58+
)
59+
)
5360
}
5461
}
5562

0 commit comments

Comments
 (0)