Fix broken icons on dice (#2806)

Fixes 2805. Checks for null text values.

Author: 96LawDawg

client/js/symbols.js

@@ -352,23 +352,24 @@ function generateSymbolsDiv(target, width, height, symbols, text, defaultScale,
   let iconsHeight = height;
   let textWidth = width;
   let textHeight = height;
-  text = String(text);
-  if(text) {
+  const hasText = text !== undefined && text !== null && text !== '';
+  const normalizedText = hasText ? String(text) : '';
+  if(hasText) {
     outerWrapper.classList.add('withText');
     if(width/height >= 2) {
       outerWrapper.classList.add('textRight');
       iconsWidth = iconsHeight;
       textWidth = width - iconsWidth
     } else {
       outerWrapper.classList.add('textBottom');
-      iconsHeight = iconsHeight / (text.indexOf('\n') != -1 ? 3 : 2);
+      iconsHeight = iconsHeight / (normalizedText.indexOf('\n') != -1 ? 3 : 2);
       textHeight = height - iconsHeight
     }
     wrapper.style.setProperty('--width', `${iconsWidth}px`);
     wrapper.style.setProperty('--height', `${iconsHeight}px`);
     $('.symbolText', outerWrapper).style.setProperty('--color', `${defaultColor}`);
     $('.symbolText', outerWrapper).style.setProperty('--hoverColor', `${defaultHoverColor}`);
-    setTextAndAdjustFontSize($('.symbolText', outerWrapper), text, textWidth, textHeight);
+    setTextAndAdjustFontSize($('.symbolText', outerWrapper), normalizedText, textWidth, textHeight);
   }
   const maxSize = optimalSquareSize(asArray(symbols).length, iconsWidth, iconsHeight);
 
@@ -441,4 +442,4 @@ function generateSymbolsDiv(target, width, height, symbols, text, defaultScale,
   }
 
   return outerWrapper;
-}
+}