Adding the option to not-animate/animate the selection #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When opening the menu, you want to have the option already displayed (and not displayed and than scroll to as currently), therefor the option animated = false is better... this is a non-breaking change
- Previously, when using .top, the bottom was not handled, but in case you are using topOffset to open the menu offseted, the menu could have been opened offscreen... this handles the situation - added support for respecting the safeArea, as the 20 constant was outdated
Improving the .top display, respecting the safeArea margins and keyboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening the menu, you want to have the dropdown options already displayed (and not displayed and than scroll to as currently), therefor the option animated = false is better...
this is a non-breaking change