fix: make diagnostics instrumentation fail open

Author: Astro-Han

packages/app/src/pages/session.tsx

@@ -133,6 +133,9 @@ export default function Page() {
       partCount: messages.reduce((count, message) => count + countMessageParts(message), 0),
     }
   })
+  const emitDiagnostics = (event: Parameters<typeof emitRendererDiagnostic>[0]) => {
+    void emitRendererDiagnostic(event).catch(() => undefined)
+  }
 
   createEffect(
     on(
@@ -153,7 +156,7 @@ export default function Page() {
         }
       },
       (state) => {
-        void emitRendererDiagnostic({
+        emitDiagnostics({
           name: "session.view.state",
           route_session_id: state.routeSessionID,
           visible_session_id: state.visibleSessionID,
@@ -190,7 +193,7 @@ export default function Page() {
         ) {
           return
         }
-        void emitRendererDiagnostic({
+        emitDiagnostics({
           name: "session.identity.transition",
           route_session_id: next.routeSessionID,
           visible_session_id: next.visibleSessionID,

packages/app/src/pages/session/use-session-refresh-effects.ts

@@ -20,26 +20,30 @@ export function useSessionRefreshEffects(input: {
   let todoTimer: number | undefined
 
   const emitRefresh = (event: RendererDiagnosticInput) => {
-    void input.emitRendererDiagnostic?.(event)
+    try {
+      const pending = input.emitRendererDiagnostic?.(event)
+      void Promise.resolve(pending).catch(() => undefined)
+    } catch {}
   }
 
   const syncSessionWithDiagnostics = (id: string, options: { force?: boolean } | undefined, cachePresent: boolean) => {
     const startedAt = performance.now()
+    const visibleSessionID = input.timelineSessionID()
     const phase = options?.force ? "message_force" : "message"
     emitRefresh({
       name: "session.data.refresh",
       route_session_id: id,
-      visible_session_id: input.timelineSessionID(),
-      timeline_session_id: input.timelineSessionID(),
+      visible_session_id: visibleSessionID,
+      timeline_session_id: visibleSessionID,
       data: { phase: `${phase}_start`, cache_present: cachePresent },
     })
     void Promise.resolve(input.syncSession(id, options))
       .then(() => {
         emitRefresh({
           name: "session.data.refresh",
           route_session_id: id,
-          visible_session_id: input.timelineSessionID(),
-          timeline_session_id: input.timelineSessionID(),
+          visible_session_id: visibleSessionID,
+          timeline_session_id: visibleSessionID,
           data: {
             phase: `${phase}_end`,
             duration_ms: Math.round(performance.now() - startedAt),
@@ -51,8 +55,8 @@ export function useSessionRefreshEffects(input: {
         emitRefresh({
           name: "session.data.refresh",
           route_session_id: id,
-          visible_session_id: input.timelineSessionID(),
-          timeline_session_id: input.timelineSessionID(),
+          visible_session_id: visibleSessionID,
+          timeline_session_id: visibleSessionID,
           data: {
             phase: `${phase}_failed`,
             duration_ms: Math.round(performance.now() - startedAt),
@@ -64,10 +68,11 @@ export function useSessionRefreshEffects(input: {
 
   const syncTodoWithDiagnostics = (id: string, options: { force?: boolean } | undefined, cachePresent: boolean) => {
     const startedAt = performance.now()
+    const routeSessionID = input.routeSessionID()
     const phase = options?.force ? "todo_force" : "todo"
     emitRefresh({
       name: "session.data.refresh",
-      route_session_id: input.routeSessionID(),
+      route_session_id: routeSessionID,
       visible_session_id: id,
       timeline_session_id: id,
       data: { phase: `${phase}_start`, cache_present: cachePresent },
@@ -76,7 +81,7 @@ export function useSessionRefreshEffects(input: {
       .then(() => {
         emitRefresh({
           name: "session.data.refresh",
-          route_session_id: input.routeSessionID(),
+          route_session_id: routeSessionID,
           visible_session_id: id,
           timeline_session_id: id,
           data: {
@@ -89,7 +94,7 @@ export function useSessionRefreshEffects(input: {
       .catch(() => {
         emitRefresh({
           name: "session.data.refresh",
-          route_session_id: input.routeSessionID(),
+          route_session_id: routeSessionID,
           visible_session_id: id,
           timeline_session_id: id,
           data: {

packages/desktop-electron/src/main/ipc.ts

@@ -33,6 +33,7 @@ const pickerFilters = (ext?: string[]) => {
 const MAX_ATTACHMENT_BYTES = 20 * 1024 * 1024
 // Picker approvals are short-lived because they authorize a renderer to request file bytes from main.
 const ATTACHMENT_APPROVAL_TTL_MS = 30 * 60 * 1000
+const RENDERER_DIAGNOSTICS_TIMEOUT_MS = 5_000
 const MAX_APPROVED_ATTACHMENT_PATHS = 1000
 
 function normalizeAttachmentPath(filepath: unknown) {
@@ -359,10 +360,20 @@ export function registerIpcHandlers(deps: Deps) {
       let rendererDiagnostics: RendererDiagnosticsSlice
       try {
         const win = BrowserWindow.fromWebContents(event.sender)
-        rendererDiagnostics = await deps.rendererDiagnosticsSlice({
-          sessionID,
-          windowID: win?.id,
-          maxBytes: SESSION_EXPORT_RENDERER_DIAGNOSTICS_MAX_BYTES,
+        let timeout: ReturnType<typeof setTimeout> | undefined
+        rendererDiagnostics = await Promise.race([
+          deps.rendererDiagnosticsSlice({
+            sessionID,
+            windowID: win?.id,
+            maxBytes: SESSION_EXPORT_RENDERER_DIAGNOSTICS_MAX_BYTES,
+          }),
+          new Promise<RendererDiagnosticsSlice>((_, reject) => {
+            timeout = setTimeout(() => {
+              reject(new Error("renderer diagnostics timed out"))
+            }, RENDERER_DIAGNOSTICS_TIMEOUT_MS)
+          }),
+        ]).finally(() => {
+          if (timeout !== undefined) clearTimeout(timeout)
         })
       } catch {
         rendererDiagnostics = emptyRendererDiagnosticsSlice("write_failed", new Date())