Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoDeployManager optimizing by using grouped order #103

Open
dnqbob opened this issue Jan 16, 2021 · 2 comments
Open

AutoDeployManager optimizing by using grouped order #103

dnqbob opened this issue Jan 16, 2021 · 2 comments

Comments

@dnqbob
Copy link

dnqbob commented Jan 16, 2021

OpenRA seems to have performance problem on parsing order, queue order one by one is much slower than queue an single order to a group of actors, and so upstream added group order for player long ago. Group order can have great improvement on performance when I apply them on my AI logic (at least 4 FPS in my PC), which is very obvious on Fastest game speed. Therefore, I think we can use group order in AutoDeployManager.

@GraionDilach
Copy link

I'm not convinced. Deploying isn't really something which can end up grouped as an AI order, because only damage-triggering on a huge AoE would lead to a group AutoDeploy trigger. Additionally, the source of the slowness is because the manager needs to look up which is the deploy trait on the current actor and you can't group Transform orders with GrantConditionOnDeploy for example.

@dnqbob
Copy link
Author

dnqbob commented Jan 16, 2021

Understood.

But we could classify those orders, and giving out each grouped orders by certain kind of order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants