Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on compilation of SpectrogramFlatView/UIColor+intermediate.swift for macOS #83

Closed
mahal opened this issue Mar 18, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@mahal
Copy link
Contributor

mahal commented Mar 18, 2024

macOS Version(s) Used to Build

macOS 13 Ventura

Xcode Version(s)

Xcode 14

Description

Swift Test of Pull Request #82 failed:
AudioKitUI/AudioKitUI/Sources/AudioKitUI/Visualizations/SpectrogramFlatView/UIColor+intermediate.swift:4:8

error: no such module 'UIKit'
import UIKit

Needs some NSColor alternative to UIColor.

Crash Logs, Screenshots or Other Attachments (if applicable)

https://github.com/AudioKit/AudioKitUI/actions/runs/8328777809/job/22793681000?pr=82

@mahal mahal added the bug Something isn't working label Mar 18, 2024
@mahal
Copy link
Contributor Author

mahal commented Mar 18, 2024

Or alternatively mark SpectrogramFlatView as not compatible with macOS.

@mahal
Copy link
Contributor Author

mahal commented Mar 18, 2024

UIImage and NSImage are very much interchangable, as are UIColor and NSColor. But the tricky part is the rendering with UIGraphicsImageRenderer, that would have to be rewritten for macOS using CoreGraphics.

@mahal
Copy link
Contributor Author

mahal commented Mar 19, 2024

Fixed with PR #85

@mahal mahal closed this as completed Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant