chore: resolve merge conflicts from branch dev

* 'dev' of github.com:Autodesk/synthesis: (227 commits)
  chore: fix ci
  fix: biome lint and toasts ui
  Fix Drag Mode During Gizmo Move (#1480)
  chore: remove unneeded jsx fragments (#1474)
  Update Tabs Indicator on Content Size Change (#1428)
  Fix Configuration Input Selection (#1460)
  refactor: create useHoldPhysicsPause hook
  style: ran formatter
  Improved 2024 Field Collisions
  fix: make cancelling work and make endgame reset
  fix: use start time delay for autonomous
  feat: make match mode timer time-based
  feat: improve match result modal styling
  refactor: use null instead of explicit fallback value for camera selection
  refactor: use string UUIDs instead of incrementing integers
  fix: update array bracket formatting
  chore: refactor out new build parts functionality
  chore: update comments
  feat: obj mesh reduction fix
  feat: glTF dense meshes extra rung
  ...

Author: BrandonPacewic

.github/workflows/NixTest.yml

@@ -0,0 +1,43 @@
+name: Test Nix
+
+on:
+  push:
+  pull_request:
+
+jobs:
+  nix-flake-check:
+    name: Nix Flake Check
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v7
+
+      - uses: cachix/install-nix-action@v31
+
+      - name: Nix Flake Check
+        run: nix flake check
+
+  fission-playwright:
+    name: Fission Playwright
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v7
+
+      - uses: cachix/install-nix-action@v31
+
+      - name: Cache Node Dependencies
+        uses: actions/cache@v6
+        with:
+          key: "${{runner.os}}-npm-fission-${{hashFiles('fission/bun.lock')}}"
+          path: "fission/node_modules"
+          restore-keys: |
+            ${{runner.os}}-npm-fission-
+            ${{runner.os}}-npm
+
+      - name: Install Dependencies
+        working-directory: "fission"
+        run: nix develop .#fission --command bash -c "bun install --frozen-lockfile"
+      
+      - name: Run Playwright Tests
+        working-directory: "fission"
+        run: |
+          nix develop .#fission --command bash -c "bun run test run ./src/test/APSTesting.test.ts"

.github/workflows/slack/github.ts

@@ -228,6 +228,17 @@ const parseImages = (body: string): ParsedBody => {
     return { text, images }
 }
 
+const COMMENT = /<!--[\s\S]*?-->[ \t]*\r?\n?/g
+const BODY_LIMIT = 1000
+
+/**
+ * Truncates text to a character limit, appending an ellipsis
+ *
+ * @return string
+ */
+const truncate = (text: string, limit: number): string =>
+    text.length > limit ? `${text.slice(0, limit).trimEnd()}…` : text
+
 const SUGGESTION = /```suggestion\r?\n(.*?)```/gs
 
 /**
@@ -248,14 +259,17 @@ const jiraSection = (pr: PullRequest): Block => {
 }
 
 /**
- * Renders the PR body as a text section plus any inline images
+ * Renders the PR body as a text section plus any inline images, dropping
+ * template comments and capping length
  *
  * @return Block[]
  */
 const prBodyBlocks = (body: string | null): Block[] => {
     if (!body) return []
-    const { text, images } = parseImages(body)
-    return [...(text ? [section(mrkdwn(text))] : []), ...images]
+    // strip comments first so images inside them don't get extracted
+    const { text, images } = parseImages(body.replace(COMMENT, ""))
+    const capped = truncate(text, BODY_LIMIT)
+    return [...(capped ? [section(mrkdwn(capped))] : []), ...images]
 }
 
 /**

.github/workflows/slack/pr_review.ts

@@ -61,27 +61,45 @@ const send = async () => {
     const repo_owner = github.repository_owner
     const repo_name = github.event.repository.name
     const pr_number = github.event.pull_request.number
+    const pr_url = `https://api.github.com/repos/${repo_owner}/${repo_name}/pulls/${pr_number}`
 
     if (github.event_name === "pull_request_review_comment") {
         const event = reviewCommentEventFromContext(github)
-
+        const review_id = github.event.comment.pull_request_review_id
         const reply_to_id = github.event.comment.in_reply_to_id
-        if (reply_to_id) {
-            const url = `https://api.github.com/repos/${repo_owner}/${repo_name}/pulls/${pr_number}/comments?per_page=100`
-            const res = await ghGet(url)
+
+        // real review renders this comment in its collapsible
+        if (review_id) {
+            const res = await ghGet(`${pr_url}/reviews/${review_id}`)
+
+            if (res.ok) {
+                const review: any = await res.json()
+                if (review.body || review.state?.toLowerCase() !== "commented")
+                    process.exit(0)
+            }
+        }
+
+        if (review_id || reply_to_id) {
+            const res = await ghGet(`${pr_url}/comments?per_page=100`)
 
             if (res.ok) {
                 const all: any[] = await res.json()
-                // in_reply_to_id = thread root; want newest reply before mine
+                const siblings = all.filter(
+                    (c) => c.pull_request_review_id === review_id,
+                )
+                // wrapper holds one comment; more = batched review
+                if (siblings.length > 1) process.exit(0)
+                // in_reply_to_id = thread root; want newest before mine
                 const parent = all
                     .filter(
                         (c) =>
-                            (c.id === reply_to_id || c.in_reply_to_id === reply_to_id) &&
+                            (c.id === reply_to_id ||
+                                c.in_reply_to_id === reply_to_id) &&
                             c.id !== github.event.comment.id,
                     )
                     .sort((a, b) => a.id - b.id)
                     .at(-1)
-                if (parent?.user && parent.body != null) {
+                if (reply_to_id && parent?.user && parent.body != null) {
                     event.replyTo = { author: parent.user.login, body: parent.body }
                 }
             }
@@ -99,13 +117,14 @@ const send = async () => {
     if (github.event.action !== "dismissed") {
         const review_id = github.event.review.id
 
-        const url = `https://api.github.com/repos/${repo_owner}/${repo_name}/pulls/${pr_number}/reviews/${review_id}/comments?per_page=100`
-        const comments_res = await ghGet(url)
+        const comments_res = await ghGet(
+            `${pr_url}/reviews/${review_id}/comments?per_page=100`,
+        )
 
         comments = await comments_res.json()
     }
 
-    // lone bodyless comment = single/reply wrapper, already sent; batches (>1) kept
+    // lone bodyless comment = wrapper, already sent; batches kept
     if (
         github.event.review.state === "commented" &&
         !github.event.review.body &&
@@ -116,17 +135,22 @@ const send = async () => {
 
     const event = reviewEventFromContext(github)
 
-    // dismiss message isn't in the payload; pull it from the timeline
+    // dismiss message isn't in the payload
     if (github.event.action === "dismissed") {
         const url = `https://api.github.com/repos/${repo_owner}/${repo_name}/issues/${pr_number}/timeline?per_page=100`
         const res = await ghGet(url)
 
         if (res.ok) {
             const events: any[] = await res.json()
             const dismissal = events
-                .filter(e => e.event === "review_dismissed" && e.dismissed_review?.review_id === github.event.review.id)
+                .filter(
+                    (e) =>
+                        e.event === "review_dismissed" &&
+                        e.dismissed_review?.review_id === github.event.review.id,
+                )
                 .at(-1)
-            if (dismissal?.dismissed_review?.dismissal_message) event.review.body = dismissal.dismissed_review.dismissal_message
+            if (dismissal?.dismissed_review?.dismissal_message)
+                event.review.body = dismissal.dismissed_review.dismissal_message
         }
     }
 

NOTICE.txt

@@ -18,4 +18,8 @@ This product bundles the following third-party sound assets:
 
    For more information, contact FIRST Robotics or refer to your licensing agreement.
 
-This product also includes Autodesk brand marks. See MARKS-LICENSE.md for more information.
+3. Files licensed from WPILib:
+   - simulation/SyntheSimJava/src/main/java/com/autodesk/synthesis/cscore/CameraServer.java
+   - simulation/SyntheSimJava/src/main/java/com/autodesk/synthesis/cscore/CvSink.java
+
+This product also includes Autodesk brand marks. See MARKS-LICENSE.md for more information.

exporter/SynthesisFusionAddin/src/Parser/SynthesisParser/Materials.py

@@ -8,6 +8,9 @@
 
 OPACITY_RAMPING_CONSTANT = 14.0
 
+# Appearances with this name are exported fully transparent
+FULLY_TRANSPARENT_APPEARANCE_NAME = ["air", "polycarbonate (clear)", "glass (clear)"]
+
 # Update tables as needed for UX and needed materials
 STATIC_FRICTION_COEFFS = {
     "Aluminum": 1.1,
@@ -239,6 +242,18 @@ def getMaterialAppearance(
     if construct_info_result.is_err():
         return construct_info_result
 
+    # Make the transparent material actually transparent
+    if fusionAppearance.name.lower() in FULLY_TRANSPARENT_APPEARANCE_NAME:
+        appearance.roughness = 0.5
+        appearance.metallic = 0.0
+        appearance.specular = 0.0
+        color = appearance.albedo
+        color.R = 255
+        color.G = 255
+        color.B = 255
+        color.A = 0
+        return Ok(None)
+
     appearance.roughness = 0.9
     appearance.metallic = 0.3
     appearance.specular = 0.5

fission/biome.json

@@ -1,5 +1,5 @@
 {
-  "$schema": "https://biomejs.dev/schemas/2.2.0/schema.json",
+  "$schema": "https://biomejs.dev/schemas/2.5.6/schema.json",
   "vcs": {
     "enabled": true,
     "clientKind": "git",
@@ -26,15 +26,16 @@
       "react": "all"
     },
     "rules": {
-      "recommended": false,
+      "preset": "none",
       "complexity": {
         "noAdjacentSpacesInRegex": "error",
         "noBannedTypes": "error",
         "noExtraBooleanCast": "error",
         "noUselessCatch": "error",
         "noUselessEscapeInRegex": "error",
         "noUselessThisAlias": "error",
-        "noUselessTypeConstraint": "error"
+        "noUselessTypeConstraint": "error",
+        "noUselessFragments": "error"
       },
       "correctness": {
         "noConstAssign": "error",
@@ -72,8 +73,9 @@
         "useAsConstAssertion": "error",
         "useComponentExportOnlyModules": "warn",
         "useImportType": "warn",
+        "useConsistentArrayType": "error",
         "useNamingConvention": {
-          "level": "warn",
+          "level": "error",
           "options": {
             "strictCase": false,
             "requireAscii": true,
@@ -120,7 +122,7 @@
                   "kind": "function"
                 },
                 "match": "([^_]*)",
-                "formats": ["camelCase"]
+                "formats": ["camelCase", "PascalCase"]
               },
               {
                 "selector": {
@@ -238,7 +240,8 @@
         "noUnsafeNegation": "error",
         "noWith": "error",
         "useGetterReturn": "error",
-        "noTsIgnore": "error"
+        "noTsIgnore": "error",
+        "noArrayIndexKey": "warn"
       }
     },
     "includes": ["src/**/*.{ts,tsx,js,json}", "./*.{ts,js,json,html}"]
@@ -264,6 +267,11 @@
       "selfCloseVoidElements": "always"
     }
   },
+  "css": {
+    "parser": {
+      "tailwindDirectives": true
+    }
+  },
   "overrides": [
     {
       "includes": ["*.json"],

fission/bun.lock

@@ -12,6 +12,7 @@
     "dev": "vite --open",
     "test": "vitest",
     "test:coverage": "vitest run --coverage",
+    "test:asan": "sh ./scripts/test-asan.sh",
     "build": "tsc && vite build",
     "build:prod": "tsc && vite build --base=/fission/ --outDir dist/prod",
     "build:dev": "tsc && vite build --base=/fission-closed/ --outDir dist/dev",
@@ -30,7 +31,7 @@
     "postinstall": "bun run lockfile:clean | bun x dev-null"
   },
   "dependencies": {
-    "@biomejs/biome": "^2.2.0",
+    "@biomejs/biome": "^2.5.6",
     "@haensl/google-analytics": "^1.2.2",
     "@mui/base": "^5.0.0-beta.70",
     "@mui/icons-material": "^5.18.0",
@@ -46,6 +47,7 @@
     "fuse.js": "^7.1.0",
     "jszip": "^3.10.1",
     "lygia": "^1.3.3",
+    "meshoptimizer": "^1.2.0",
     "msw": "^2.10.5",
     "notistack": "^3.0.2",
     "peerjs": "^1.5.5",

fission/package.json

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:061fafcd3d10472aa7bbb30258da152dc587ed90a6774715e0b9c51b9726c8e0
-size 47162091
+oid sha256:346732c52aeb501ca834604abd1e709b37739e411167f65966948c397c42b9b3
+size 41776228