Post notifications when requested with invalid authentication (#703)

* Post notifications when requested with invalid authentication

* Fix Swift unit tests compiling issues

* Add `WpAppNotifier` argument

* Fix the Swift example project

* Remove a unused notification constant

Author: crazytonyli

native/swift/Example/Example/WordPressAPI+Extensions.swift

@@ -20,7 +20,7 @@ extension WordPressAPI {
             return WordPressAPI(
                urlSession: .shared,
                apiRootUrl: apiRootUrl,
-               authenticationStategy: loginCredentials
+               authentication: loginCredentials
            )
         }
     }

native/swift/Sources/wordpress-api/AppNotifier.swift

@@ -0,0 +1,8 @@
+import Foundation
+import WordPressAPIInternal
+
+class EmptyAppNotifier: @unchecked Sendable, WpAppNotifier {
+    func requestedWithInvalidAuthentication() async {
+        // no-op
+    }
+}

native/swift/Sources/wordpress-api/JetpackConnectionClient+Extensions.swift

@@ -10,15 +10,16 @@ extension JetpackConnectionClient {
         apiRootUrl: ParsedUrl,
         urlSession: URLSession,
         authentication: WpAuthentication,
-        middlewarePipeline: MiddlewarePipeline = .default
+        middlewarePipeline: MiddlewarePipeline = .default,
+        appNotifier: WpAppNotifier? = nil
     ) {
         self.init(
             apiRootUrl: apiRootUrl,
             delegate: .init(
                 authProvider: .staticWithAuth(auth: authentication),
                 requestExecutor: WpRequestExecutor(urlSession: urlSession),
                 middlewarePipeline: middlewarePipeline,
-                appNotifier: NoopAppNotifier()
+                appNotifier: appNotifier ?? EmptyAppNotifier()
             )
         )
     }

native/swift/Sources/wordpress-api/WordPressAPI.swift

@@ -11,33 +11,54 @@ public actor WordPressAPI {
         case unableToParseResponse
     }
 
-    private let internalExecutor: SafeRequestExecutor
+    private let apiClientDelegate: WpApiClientDelegate
     package let requestBuilder: UniffiWpApiClient
 
-    public init(urlSession: URLSession, apiRootUrl: ParsedUrl, authenticationStategy: WpAuthentication) {
+    public init(
+        urlSession: URLSession,
+        apiRootUrl: ParsedUrl,
+        authentication: WpAuthentication,
+        middlewarePipeline: MiddlewarePipeline = .default
+    ) {
+        self.init(
+            apiRootUrl: apiRootUrl,
+            authenticationProvider: .staticWithAuth(auth: authentication),
+            executor: WpRequestExecutor(urlSession: urlSession),
+            middlewarePipeline: middlewarePipeline
+        )
+    }
+
+    public init(
+        urlSession: URLSession,
+        apiRootUrl: ParsedUrl,
+        authenticationProvider: WpAuthenticationProvider,
+        middlewarePipeline: MiddlewarePipeline = .default,
+        appNotifier: WpAppNotifier? = nil
+    ) {
         self.init(
             apiRootUrl: apiRootUrl,
-            authenticationStategy: authenticationStategy,
-            executor: WpRequestExecutor(urlSession: urlSession)
+            authenticationProvider: authenticationProvider,
+            executor: WpRequestExecutor(urlSession: urlSession),
+            middlewarePipeline: middlewarePipeline
         )
     }
 
     init(
         apiRootUrl: ParsedUrl,
-        authenticationStategy: WpAuthentication,
+        authenticationProvider: WpAuthenticationProvider,
         executor: SafeRequestExecutor,
-        middlewarePipeline: MiddlewarePipeline = .default
+        middlewarePipeline: MiddlewarePipeline,
+        appNotifier: WpAppNotifier? = nil
     ) {
-        self.internalExecutor = executor
-
+        self.apiClientDelegate = WpApiClientDelegate(
+            authProvider: authenticationProvider,
+            requestExecutor: executor,
+            middlewarePipeline: middlewarePipeline,
+            appNotifier: appNotifier ?? EmptyAppNotifier()
+        )
         self.requestBuilder = UniffiWpApiClient(
             apiRootUrl: apiRootUrl,
-            delegate: .init(
-                authProvider: .staticWithAuth(auth: authenticationStategy),
-                requestExecutor: executor,
-                middlewarePipeline: middlewarePipeline,
-                appNotifier: NoopAppNotifier()
-            )
+            delegate: self.apiClientDelegate
         )
     }
 
@@ -170,9 +191,3 @@ public extension ParsedUrl {
         try parse(input: url.absoluteString)
     }
 }
-
-class NoopAppNotifier: @unchecked Sendable, WpAppNotifier {
-    func requestedWithInvalidAuthentication() async {
-        // Do nothing.
-    }
-}

native/swift/Tests/wordpress-api/Endpoints/Users.swift

@@ -40,8 +40,9 @@ struct UsersTests {
 
         let api = try WordPressAPI(
             apiRootUrl: ParsedUrl.parse(input: "https://wordpress.org/wp-json"),
-            authenticationStategy: .none,
-            executor: stubs
+            authenticationProvider: .none(),
+            executor: stubs,
+            middlewarePipeline: .default
         )
         let user = try await api.users.retrieveWithViewContext(userId: 1)
         #expect(user.data.name == "User Name")

native/swift/Tests/wordpress-api/HttpTests.swift

@@ -10,8 +10,9 @@ class HTTPErrorTests {
 
         let api = try WordPressAPI(
             apiRootUrl: ParsedUrl.parse(input: "https://wordpress.org/wp-json"),
-            authenticationStategy: .none,
-            executor: stubs
+            authenticationProvider: .none(),
+            executor: stubs,
+            middlewarePipeline: .default
         )
 
         await #expect(throws: WpApiError.self, performing: {

native/swift/Tests/wordpress-api/WordPressAPITests.swift

@@ -44,8 +44,9 @@ struct WordPressAPITests {
         let stubs = try createStubs()
         let api = try WordPressAPI(
             apiRootUrl: ParsedUrl.parse(input: "https://wordpress.org/wp-json"),
-            authenticationStategy: .none,
-            executor: stubs
+            authenticationProvider: .none(),
+            executor: stubs,
+            middlewarePipeline: .default
         )
         let user = try await api.users.retrieveWithViewContext(userId: 1)
         #expect(user.data.name == "User Name")
@@ -57,7 +58,7 @@ struct WordPressAPITests {
         let counter = CounterMiddleware()
         let api = try WordPressAPI(
             apiRootUrl: ParsedUrl.parse(input: "https://wordpress.org/wp-json"),
-            authenticationStategy: .none,
+            authenticationProvider: .none(),
             executor: stubs,
             middlewarePipeline: .init(middlewares: [counter])
         )