Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMPROVEMENT: Move app volume slider to media player #42

Closed
mbeps opened this issue Mar 12, 2023 · 2 comments
Closed

IMPROVEMENT: Move app volume slider to media player #42

mbeps opened this issue Mar 12, 2023 · 2 comments

Comments

@mbeps
Copy link

mbeps commented Mar 12, 2023

Currently, the volume slider is shown next to the standard system volume slider making it messy the settings messy and unclear. It would be way more clear which app the volume slider belongs to if it was integrated into the appropriate volume slider.

Current Implementation
image

Suggested Implementation
Screenshot from 2023-03-12 11-58-37

@Aylur
Copy link
Owner

Aylur commented Mar 12, 2023

I would have done it this way, but there is no way to associate these two everytime. The one on the buttom uses the MPRIS interface which applications fully or partially implement. For example Spotify implements volume control, loop, shuffle control and everything else and so it can be controlled through mpris alone, but playing youtube on firefox only implements play-pause next and previous actions. The one under the system volume slider uses Gvc and anything that plays sound, even the system sounds are going to show up there. The issue is that they don't necessarily have a common id or something which you can use to pair them, and even if there were, there would be still complications, for example having two videos playing in firefox will display two sliders for them but the mpris one would still only show one.

@mbeps
Copy link
Author

mbeps commented Mar 12, 2023

Make sense however there is still a way to make the slider look better and more neat. Currently, it the slider section looks cluttered and it would be nice if they were grouped together, for example an expandable section only for app volume. Or maybe add the app volumes into the main volume slider.
Thanks for your work it is much appreciated.

@Aylur Aylur closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants