Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player icon missing after updating to 20. #43

Closed
axelvanherle opened this issue Mar 16, 2023 · 7 comments
Closed

Player icon missing after updating to 20. #43

axelvanherle opened this issue Mar 16, 2023 · 7 comments

Comments

@axelvanherle
Copy link

axelvanherle commented Mar 16, 2023

missing icon

After updating the player icon is missing.

Im on Linux pop-os 6.2.0-76060200-generic.
I have a theme applied, no other extensions should be interfering.

@Aylur
Copy link
Owner

Aylur commented Mar 16, 2023

Weird, I didn't touch anything releated to this from v19.
What is your gnome version?
What application doesn't show an icon? And how was that app installed flatpak/deb?

@axelvanherle
Copy link
Author

I'm on GNOME Shell 42.5.

The application is Spotify, installed via flatpak.

@Aylur
Copy link
Owner

Aylur commented Mar 16, 2023

Seems like I had an icon pack applied when I was working on this and haven't encountered this issue.
I get the icon name from the MPRIS entry property which is 'spotify' in both the flatpak and non flatpak versions.
But the icon provided in flatpak is not spotify.svg but com.spotify.Client.svg. There is no way to check what version is running through MPRIS. I will add a generic fallback icon.
What you can do is apply an icon pack which provides spotify.svg for the colored version and spotify-symbolic for the noncolored version of the icon.
Or try installing spotify as a deb, though I am not sure if there is one or if it provides these icons.

@axelvanherle
Copy link
Author

Thanks for the quick responses, for now i have just disabled the icon from showing, probably will keep it like that.

Thanks again for your help, and for your work on the extension.

@stpnwf
Copy link

stpnwf commented Mar 16, 2023

Happens to me as well. Strangely enough the only icon that shows up for me is Spotify (flatpak) if and only if I have my custom icon pack applied. In every other situation I get this:
Librewolf (Flatpak)
Screenshot from 2023-03-16 19-56-50
I am on Fedora 37 (Gnome 43.3)

I didn't know it was possible to enable the icon to show up like that. The icon suddenly started showing up after an update (v18 or 19 I think) and I noticed that it only worked for Spotify... Now that I know it is a feature, I love it.


UPDATE: Seems to be an issue with applications installed via Flatpak (except Spotify) , as a symbolic icon shows up for apps installed via DNF (Firefox and Totem)
Firefox (dnf)
Screenshot from 2023-03-16 20-29-17

BTW what type of icon is supposed to show up? Full on icons or symbolic ones? Dnf apps show a symbolic icon, but Spotify shows the full colored icon.

@Aylur
Copy link
Owner

Aylur commented Mar 18, 2023

It is based on the MPRIS entry property, for example on firefox this entry is firefox so it looks for firefox and firefox-symbolic icons based on your settings in the extension Media Player > Track Button > Colored Player Icon. For spotify it is spotify and spotify-symbolic.
The issue is that apps from flatpak provide icons named like com.spotify.Client or something but the entry is still spotify.

@stpnwf
Copy link

stpnwf commented Mar 18, 2023

Hmm, I see. I think I personally slightly prefer the full on icons to show up, but regardless it is strange only Spotify shows up for me and not other flatpak icons, either full on or symbolic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants