Skip to content

Commit 42e9d36

Browse files
Update linting rule to enforce to use semicolon (#91)
* enforce to use semicolon * fix lint
1 parent c288e85 commit 42e9d36

File tree

13 files changed

+30
-27
lines changed

13 files changed

+30
-27
lines changed

.eslintrc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
{
5757
"max": 1
5858
}
59-
]
59+
],
60+
"semi": ["error", "always"]
6061
}
6162
}

src/AzureAppConfigurationImpl.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,7 @@ export class AzureAppConfigurationImpl implements AzureAppConfiguration {
481481
if (index >= 0) {
482482
this.#onRefreshListeners.splice(index, 1);
483483
}
484-
}
484+
};
485485
return new Disposable(remove);
486486
}
487487

src/JsonKeyValueAdapter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,4 +54,4 @@ function isJsonContentType(contentTypeValue: string): boolean {
5454
}
5555

5656
return typeParts[1].split("+").includes("json");
57-
}
57+
}

src/load.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ function getClientOptions(options?: AzureAppConfigurationOptions): AppConfigurat
9494
const defaultRetryOptions = {
9595
maxRetries: MaxRetries,
9696
maxRetryDelayInMs: MaxRetryDelayInMs,
97-
}
97+
};
9898
const retryOptions = Object.assign({}, defaultRetryOptions, options?.clientOptions?.retryOptions);
9999

100100
return Object.assign({}, options?.clientOptions, {

src/requestTracing/utils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export function listConfigurationSettingsWithTrace(
4040
customHeaders: {
4141
[CORRELATION_CONTEXT_HEADER_NAME]: createCorrelationContextHeader(appConfigOptions, initialLoadCompleted)
4242
}
43-
}
43+
};
4444
}
4545

4646
return client.listConfigurationSettings(actualListOptions);
@@ -64,7 +64,7 @@ export function getConfigurationSettingWithTrace(
6464
customHeaders: {
6565
[CORRELATION_CONTEXT_HEADER_NAME]: createCorrelationContextHeader(appConfigOptions, initialLoadCompleted)
6666
}
67-
}
67+
};
6868
}
6969

7070
return client.getConfigurationSetting(configurationSettingId, actualGetOptions);

test/clientOptions.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ describe("custom client options", function () {
3737

3838
afterEach(() => {
3939
nock.restore();
40-
})
40+
});
4141

4242
it("should retry 2 times by default", async () => {
4343
const countPolicy = new HttpRequestCountPolicy();
@@ -49,7 +49,7 @@ describe("custom client options", function () {
4949
position: "perRetry"
5050
}]
5151
}
52-
})
52+
});
5353
};
5454
let error;
5555
try {
@@ -74,7 +74,7 @@ describe("custom client options", function () {
7474
maxRetries
7575
}
7676
}
77-
})
77+
});
7878
};
7979

8080
let error;
@@ -109,7 +109,7 @@ describe("custom client options", function () {
109109
position: "perRetry"
110110
}]
111111
}
112-
})
112+
});
113113
};
114114
let error;
115115
try {
@@ -120,4 +120,4 @@ describe("custom client options", function () {
120120
expect(error).not.undefined;
121121
expect(countPolicy.count).eq(3);
122122
});
123-
})
123+
});

test/featureFlag.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@ describe("feature flags", function () {
6565

6666
after(() => {
6767
restoreMocks();
68-
})
68+
});
69+
6970
it("should load feature flags if enabled", async () => {
7071
const connectionString = createMockedConnectionString();
7172
const settings = await load(connectionString, {

test/json.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ describe("json", function () {
1717

1818
afterEach(() => {
1919
restoreMocks();
20-
})
20+
});
2121

2222
it("should load and parse if content type is application/json", async () => {
2323
mockAppConfigurationClientListConfigurationSettings([jsonKeyValue]);
@@ -86,4 +86,4 @@ describe("json", function () {
8686
expect(settings.get("json.settings.emptyString")).eq("", "is empty string");
8787
expect(settings.get("json.settings.illegalString")).eq("[unclosed", "is illegal string");
8888
});
89-
})
89+
});

test/keyvault.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,4 +111,4 @@ describe("key vault reference", function () {
111111
expect(settings.get("TestKey")).eq("SecretValue");
112112
expect(settings.get("TestKey2")).eq("SecretValue2");
113113
});
114-
})
114+
});

test/load.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ describe("load", function () {
8585

8686
after(() => {
8787
restoreMocks();
88-
})
88+
});
89+
8990
it("should load data from config store with connection string", async () => {
9091
const connectionString = createMockedConnectionString();
9192
const settings = await load(connectionString);

0 commit comments

Comments
 (0)