acr: show scope map delete warnings

Author: SakoPak

src/azure-cli/azure/cli/command_modules/acr/scope_map.py

@@ -5,11 +5,14 @@
 
 from enum import Enum
 from azure.cli.core.util import CLIError
+from knack.log import get_logger
 from ._utils import (
     get_resource_group_name_by_registry_name,
     parse_scope_map_actions
 )
 
+logger = get_logger(__name__)
+
 
 class RepoScopeMapActions(Enum):
     CONTENT_DELETE = 'content/delete'
@@ -26,6 +29,19 @@ class GatewayScopeMapActions(Enum):
     MESSAGES_WRITE = 'message/write'
 
 
+def _get_warning_response_hook():
+    """Create an SDK response hook that emits each LRO warning once."""
+    displayed_warnings = set()
+
+    def _show_warning(response):
+        warning = response.http_response.headers.get('x-ms-warning')
+        if warning and warning not in displayed_warnings:
+            logger.warning('%s', warning)
+            displayed_warnings.add(warning)
+
+    return _show_warning
+
+
 def acr_scope_map_create(cmd,
                          client,
                          registry_name,
@@ -70,7 +86,12 @@ def acr_scope_map_delete(cmd,
             return None
 
     resource_group_name = get_resource_group_name_by_registry_name(cmd.cli_ctx, registry_name, resource_group_name)
-    return client.begin_delete(resource_group_name, registry_name, scope_map_name)
+    return client.begin_delete(
+        resource_group_name,
+        registry_name,
+        scope_map_name,
+        raw_response_hook=_get_warning_response_hook()
+    )
 
 
 def acr_scope_map_update(cmd,

src/azure-cli/azure/cli/command_modules/acr/tests/latest/test_acr_commands_mock.py

@@ -39,6 +39,7 @@
     acr_helm_delete,
     acr_helm_push
 )
+from azure.cli.command_modules.acr.scope_map import acr_scope_map_delete
 from azure.cli.command_modules.acr._docker_utils import (
     get_login_credentials,
     get_access_credentials,
@@ -64,6 +65,54 @@
 
 class AcrMockCommandsTests(unittest.TestCase):
 
+    @mock.patch('azure.cli.command_modules.acr.scope_map.logger')
+    @mock.patch(
+        'azure.cli.command_modules.acr.scope_map.'
+        'get_resource_group_name_by_registry_name'
+    )
+    def test_scope_map_delete_surfaces_warning_once(
+            self, mock_get_resource_group, mock_logger):
+        mock_get_resource_group.return_value = 'testresourcegroup'
+        client = mock.MagicMock()
+        client.begin_delete.return_value = mock.sentinel.poller
+
+        result = acr_scope_map_delete(
+            self._setup_cmd(),
+            client,
+            'testregistry',
+            'testscopemap',
+            yes=True
+        )
+
+        self.assertIs(result, mock.sentinel.poller)
+        client.begin_delete.assert_called_once_with(
+            'testresourcegroup',
+            'testregistry',
+            'testscopemap',
+            raw_response_hook=mock.ANY
+        )
+
+        response_hook = client.begin_delete.call_args.kwargs[
+            'raw_response_hook'
+        ]
+        response = mock.MagicMock()
+        response.http_response.headers = {}
+        response_hook(response)
+        mock_logger.warning.assert_not_called()
+
+        warning = (
+            "Could not find the authorization entity for token(s): "
+            "'testtoken'."
+        )
+        response.http_response.headers = {
+            'x-ms-warning': warning
+        }
+
+        response_hook(response)
+        response_hook(response)
+
+        mock_logger.warning.assert_called_once_with('%s', warning)
+
     @mock.patch('azure.cli.command_modules.acr.repository.get_access_credentials', autospec=True)
     @mock.patch('requests.request', autospec=True)
     def test_repository_list(self, mock_requests_get, mock_get_access_credentials):