Skip to content

Commit e94e781

Browse files
Bharat PurwarCopilot
andcommitted
fix(backup): validate Azure Files registration routing
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent b31f1a5 commit e94e781

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

‎src/azure-cli/azure/cli/command_modules/backup/custom_base.py‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -515,6 +515,9 @@ def register_container(cmd, client, vault_name, resource_group_name, workload_ty
515515
if workload_type is None:
516516
raise RequiredArgumentMissingError(
517517
"--workload-type is required with --backup-management-type AzureWorkload.")
518+
if workload_type.lower() in ["azurefiles", "azurefileshare"]:
519+
raise InvalidArgumentValueError(
520+
"--workload-type AzureFileShare requires --backup-management-type AzureStorage.")
518521
if resource_id is None:
519522
raise RequiredArgumentMissingError(
520523
"--resource-id is required with --backup-management-type AzureWorkload.")

‎src/azure-cli/azure/cli/command_modules/backup/tests/latest/test_custom_afs.py‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,12 @@ def test_register_container_rejects_afs_arguments_for_azure_workload(self):
2828
Mock(), Mock(), "vault", "rg", "MSSQL",
2929
resource_id="resource-id", **arguments)
3030

31+
def test_register_container_rejects_afs_workload_for_azure_workload(self):
32+
with self.assertRaises(InvalidArgumentValueError):
33+
custom_base.register_container(
34+
Mock(), Mock(), "vault", "rg", "AzureFileShare",
35+
resource_id="resource-id")
36+
3137
@patch("azure.cli.command_modules.backup.custom_base.register_wl_container")
3238
def test_register_container_preserves_azure_workload_default(self, register_wl_container):
3339
cmd = Mock()

0 commit comments

Comments
 (0)