fix

Author: xfz11

src/azure-cli/azure/cli/command_modules/serviceconnector/_params.py

@@ -194,7 +194,7 @@ def add_connstr_props_argument(context):
 def add_no_recreate_arguments(context):
     context.argument('no_recreate', options_list=['--no-recreate'],
                      arg_type=get_three_state_flag(), default=False,
-                     help='Skip executing creation operation when no updates to an existing connection')
+                     help='Skip executing creation operation when no updates to an existing connection.')
 
 
 def add_target_type_argument(context, source):

src/azure-cli/azure/cli/command_modules/serviceconnector/_utils.py

@@ -597,7 +597,7 @@ def has_meaningful_changes(new_value, existing_value):
             return False
         if isinstance(new_value, dict) and existing_value is None:
             for value in new_value.values():
-                if value is not None or value != "":
+                if value is not None and value != "":
                     return True
             return False
 

src/azure-cli/azure/cli/command_modules/serviceconnector/custom.py

@@ -540,7 +540,7 @@ def connection_create_func(cmd, client,  # pylint: disable=too-many-locals,too-m
             logger.warning('Connection provisioningState is Accepted, please retry later to avoid conflict.')
             return linker
         if linker is not None and linker.get('provisioningState') == 'Succeeded' and \
-                not compare_properties_changed(parameters, linker) and no_recreate is True:
+                not compare_properties_changed(parameters, linker) and no_recreate:
             logger.warning(
                 'Connection exists and no property to be updated, skip the update operation.')
             return linker