Fix tests

Author: liliankasem

src/Cli/func/Actions/HostActions/StartHostAction.cs

@@ -546,7 +546,7 @@ void ThrowCliException(string suffix)
 
                 if (string.Equals(HostRuntime, "default", StringComparison.OrdinalIgnoreCase))
                 {
-                    ThrowCliException($"The provided value is only valid for the worker runtime '{WorkerRuntime.DotnetIsolated}'.");
+                    ThrowCliException($"The provided value is only valid for the worker runtime '{WorkerRuntime.DotnetIsolated.ToString().ToLowerInvariant}'.");
                 }
 
                 if (isInproc8ArgumentValue && !await validateDotNet8ProjectEnablement())
@@ -560,7 +560,7 @@ void ThrowCliException(string suffix)
             }
             else if (isInproc8ArgumentValue || isInproc6ArgumentValue)
             {
-                ThrowCliException($"The provided value is only valid for the worker runtime '{WorkerRuntime.Dotnet}'.");
+                ThrowCliException($"The provided value is only valid for the worker runtime '{WorkerRuntime.Dotnet.ToString().ToLowerInvariant}'.");
             }
 
             PrintVerboseForHostSelection(HostRuntime);

src/Cli/func/Actions/LocalActions/InitAction.cs

@@ -199,7 +199,7 @@ private async Task InitFunctionAppProject()
                 if (!supportedProgrammingModels.Contains(ResolvedProgrammingModel))
                 {
                     throw new CliArgumentsException(
-                        $"The {ResolvedProgrammingModel.ToString()} programming model is not supported for worker runtime {ResolvedWorkerRuntime.ToString()}. Supported programming models for worker runtime {ResolvedWorkerRuntime.ToString()} are:\n{EnumerationHelper.Join<ProgrammingModel>("\n", supportedProgrammingModels)}");
+                        $"The {ResolvedProgrammingModel.ToString().ToLowerInvariant} programming model is not supported for worker runtime {ResolvedWorkerRuntime.ToString().ToLowerInvariant}. Supported programming models for worker runtime {ResolvedWorkerRuntime.ToString().ToLowerInvariant} are:\n{EnumerationHelper.Join("\n", supportedProgrammingModels)}");
                 }
             }
 
@@ -367,7 +367,7 @@ private void ValidateTargetFramework()
 
             if (!supportedFrameworks.Contains(TargetFramework, StringComparer.InvariantCultureIgnoreCase))
             {
-                throw new CliArgumentsException($"Unable to parse target framework {TargetFramework} for worker runtime {ResolvedWorkerRuntime}. Valid options are {string.Join(", ", supportedFrameworks)}");
+                throw new CliArgumentsException($"Unable to parse target framework {TargetFramework} for worker runtime {ResolvedWorkerRuntime.ToString().ToLowerInvariant}. Valid options are {string.Join(", ", supportedFrameworks)}");
             }
             else if (ResolvedWorkerRuntime != Helpers.WorkerRuntime.DotnetIsolated && ResolvedWorkerRuntime != Helpers.WorkerRuntime.Dotnet)
             {

src/Cli/func/Extensions/GenericExtensions.cs

@@ -14,7 +14,7 @@ public static TTarget MergeWith<TTarget, TSource, TSelected>(this TTarget target
         {
             object selectedSource = null;
 
-            if (source is null && selector is not null)
+            if (source != null && selector != null)
             {
                 selectedSource = selector(source);
             }

test/Azure.Functions.Cli.Tests/E2E/StartTests.cs

@@ -257,7 +257,7 @@ await CliTester.Run(new RunConfiguration[]
                             p.Kill();
                             await Task.Delay(TimeSpan.FromSeconds(2));
                             result.Should().Be("Hello, Test. This HTTP triggered function executed successfully.", because: "response from default function should be 'Hello, {name}. This HTTP triggered function executed successfully.'");
-                            
+
                             if (_output is Xunit.Sdk.TestOutputHelper testOutputHelper)
                             {
                                 testOutputHelper.Output.Should().Contain($".NET 6 is no longer supported. Please consider migrating to a supported version. For more information, see https://aka.ms/azure-functions/dotnet/net8-in-process. If you intend to target .NET 8 on the in-process model, make sure that '{Constants.InProcDotNet8EnabledSetting}' is set to '1' in {Constants.LocalSettingsJsonFileName}.");
@@ -1115,7 +1115,7 @@ await CliTester.Run(new RunConfiguration[]
                     },
                     ExpectExit = false,
                     ExitInError = true,
-                    ErrorContains = ["The runtime argument value provided, 'default', is invalid. The provided value is only valid for the worker runtime 'dotnetIsolated'."],
+                    ErrorContains = ["The runtime argument value provided, 'default', is invalid. The provided value is only valid for the worker runtime 'dotnetisolated'."],
                     Test = async (workingDir, p, _) =>
                     {
                         using (var client = new HttpClient() { BaseAddress = new Uri($"http://localhost:{_funcHostPort}") })
@@ -1149,7 +1149,7 @@ await CliTester.Run(new RunConfiguration[]
                     },
                     ExpectExit = false,
                     ExitInError = true,
-                    ErrorContains = ["The runtime argument value provided, 'default', is invalid. The provided value is only valid for the worker runtime 'dotnetIsolated'."],
+                    ErrorContains = ["The runtime argument value provided, 'default', is invalid. The provided value is only valid for the worker runtime 'dotnetisolated'."],
                     Test = async (workingDir, p, _) =>
                     {
                         using (var client = new HttpClient() { BaseAddress = new Uri($"http://localhost:{_funcHostPort}") })
@@ -1896,7 +1896,7 @@ await CliTester.Run(new RunConfiguration[]
                             var response = await client.GetAsync("/api/HttpTrigger?name=Test");
                             var result = await response.Content.ReadAsStringAsync();
                             p.Kill();
-                            
+
                             if (_output is Xunit.Sdk.TestOutputHelper testOutputHelper)
                             {
                                 testOutputHelper.Output.Should().Contain($".NET 6 is no longer supported. Please consider migrating to a supported version. For more information, see https://aka.ms/azure-functions/dotnet/net8-in-process. If you intend to target .NET 8 on the in-process model, make sure that '{Constants.InProcDotNet8EnabledSetting}' is set to '1' in {Constants.LocalSettingsJsonFileName}.");
@@ -1965,4 +1965,4 @@ public async Task DisposeAsync()
             await Task.CompletedTask;
         }
     }
-}
+}