Fix all style issues in src/Cli/func (#4380)

* Fix style in Common/ (#4370)
* Fix style in Actions/ (part 1) (#4371)
* Fix style in Actions/ (part 2) (#4372)
* Fix style in Arm/ (#4373)
* Fix style in Helpers/ (#4374)
* Fix style in Exceptions/, Extensions/ and Interfaces/ (#4375)
* Fix style in Telemetry/ (#4377)
* Fix style in Models, ContainerApps, Diagnostics and misc (#4378)
* Fix style in func root, broken tests, and errors in host (#4379)
* Fix style in Kubernetes/ (#4376)

Author: liliankasem

src/Cli/func/ActionAttribute.cs

@@ -1,9 +1,10 @@
-using System;
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the MIT License. See LICENSE in the project root for license information.
 
 namespace Azure.Functions.Cli
 {
     [AttributeUsage(AttributeTargets.Class, AllowMultiple = true)]
-    sealed class ActionAttribute : Attribute
+    internal sealed class ActionAttribute : Attribute
     {
         public Context Context { get; set; }
 

src/Cli/func/ActionType.cs

@@ -1,13 +1,16 @@
-using System;
-using System.Collections.Generic;
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the MIT License. See LICENSE in the project root for license information.
 
 namespace Azure.Functions.Cli
 {
     internal class ActionType
     {
         public Type Type { get; set; }
+
         public IEnumerable<Context> Contexts { get; set; }
+
         public IEnumerable<Context> SubContexts { get; set; }
+
         public IEnumerable<string> Names { get; set; }
     }
-}
+}

src/Cli/func/Actions/AzureActions/AddStorageAccountSettingAction.cs

@@ -1,13 +1,12 @@
-using System;
-using System.Linq;
-using System.Threading.Tasks;
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the MIT License. See LICENSE in the project root for license information.
+
+using Azure.Functions.Cli.Common;
+using Azure.Functions.Cli.Helpers;
+using Azure.Functions.Cli.Interfaces;
 using Colors.Net;
 using Fclp;
-using Azure.Functions.Cli.Arm;
-using Azure.Functions.Cli.Interfaces;
 using static Azure.Functions.Cli.Common.OutputTheme;
-using Azure.Functions.Cli.Common;
-using Azure.Functions.Cli.Helpers;
 
 namespace Azure.Functions.Cli.Actions.AzureActions
 {
@@ -17,14 +16,14 @@ internal class AddStorageAccountSettingAction : BaseAzureAction
         private readonly ISettings _settings;
         private readonly ISecretsManager _secretsManager;
 
-        public string StorageAccountName { get; set; }
-
         public AddStorageAccountSettingAction(ISettings settings, ISecretsManager secretsManager)
         {
             _settings = settings;
             _secretsManager = secretsManager;
         }
 
+        public string StorageAccountName { get; set; }
+
         public override ICommandLineParserResult ParseArgs(string[] args)
         {
             if (args.Any())
@@ -33,7 +32,8 @@ public override ICommandLineParserResult ParseArgs(string[] args)
             }
             else
             {
-                throw new CliArgumentsException("Must specify storage account name.",
+                throw new CliArgumentsException(
+                    "Must specify storage account name.",
                     new CliArgument { Name = nameof(StorageAccountName), Description = "Storage Account Name" });
             }
 

src/Cli/func/Actions/AzureActions/BaseAzureAction.cs

@@ -1,40 +1,40 @@
-using System;
-using System.IO;
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the MIT License. See LICENSE in the project root for license information.
+
 using System.Runtime.InteropServices;
 using System.Text;
-using System.Threading.Tasks;
-using Azure.Functions.Cli.Arm;
 using Azure.Functions.Cli.Common;
-using static Azure.Functions.Cli.Common.OutputTheme;
 using Azure.Functions.Cli.Interfaces;
 using Colors.Net;
 using Fclp;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
-using static Colors.Net.StringStaticMethods;
-using Azure.Functions.Cli.Helpers;
+using static Azure.Functions.Cli.Common.OutputTheme;
 
 namespace Azure.Functions.Cli.Actions.AzureActions
 {
-    abstract class BaseAzureAction : BaseAction, IInitializableAction
+    internal abstract class BaseAzureAction : BaseAction, IInitializableAction
     {
         // Az is the Azure PowerShell module that works in both PowerShell Core and Windows PowerShell
-        private const string _azProfileModuleName = "Az.Accounts";
+        private const string AzProfileModuleName = "Az.Accounts";
 
         // AzureRm is the Azure PowerShell module that only works on Windows PowerShell
-        private const string _azureRmProfileModuleName = "AzureRM.Profile";
+        private const string AzureRmProfileModuleName = "AzureRM.Profile";
 
         // PowerShell Core is version 6.0 and higher that is cross-platform
-        private const string _powerShellCoreExecutable = "pwsh";
+        private const string PowerShellCoreExecutable = "pwsh";
 
         // Windows PowerShell is PowerShell version 5.1 and lower that only works on Windows
-        private const string _windowsPowerShellExecutable = "powershell";
+        private const string WindowsPowerShellExecutable = "powershell";
 
-        private const string _defaultManagementURL = Constants.DefaultManagementURL;
+        private const string DefaultManagementURL = Constants.DefaultManagementURL;
 
         public string AccessToken { get; set; }
+
         public bool ReadStdin { get; set; }
+
         public string ManagementURL { get; set; }
+
         public string Subscription { get; private set; }
 
         public override ICommandLineParserResult ParseArgs(string[] args)
@@ -73,6 +73,7 @@ public async Task Initialize()
                 {
                     AccessToken = accessToken;
                 }
+
                 if (string.IsNullOrEmpty(AccessToken))
                 {
                     throw new CliException("Unable to set access token from stdin.");
@@ -101,14 +102,15 @@ private async Task<string> GetManagementURL()
             {
                 // TODO: Try with Poweshell if az is non-existent or if the call fails
                 // For now, let's default this out
-                managementURL = _defaultManagementURL;
+                managementURL = DefaultManagementURL;
             }
+
             // Having a trailing slash could cause issues later when we attach it to function IDs
             // It's easier to remove now, than to do that before every ARM call.
-            return managementURL.EndsWith("/") ? managementURL.Substring(0, managementURL.Length - 1) : managementURL;
+            return managementURL.EndsWith("/") ? managementURL[..^1] : managementURL;
         }
 
-        private async Task<(bool, string)> TryGetAzCLIManagementURL()
+        private async Task<(bool AzCliSucceeded, string ManagementURL)> TryGetAzCLIManagementURL()
         {
             try
             {
@@ -120,24 +122,33 @@ private async Task<string> GetManagementURL()
                 {
                     ColoredConsole.WriteLine(WarningColor("Unable to retrieve the resource manager URL from az CLI"));
                 }
+
                 return (false, null);
             }
         }
 
         private async Task<string> GetAccessToken()
         {
             (bool cliSucceeded, string cliToken) = await TryGetAzCliToken();
-            if (cliSucceeded) return cliToken;
+
+            if (cliSucceeded)
+            {
+                return cliToken;
+            }
 
             (bool powershellSucceeded, string psToken) = await TryGetAzPowerShellToken();
-            if (powershellSucceeded) return psToken;
+
+            if (powershellSucceeded)
+            {
+                return psToken;
+            }
 
             if (TryGetTokenFromTestEnvironment(out string envToken))
             {
                 return envToken;
             }
 
-            throw new CliException($"Unable to connect to Azure. Make sure you have the `az` CLI or `{_azProfileModuleName}` PowerShell module installed and logged in and try again");
+            throw new CliException($"Unable to connect to Azure. Make sure you have the `az` CLI or `{AzProfileModuleName}` PowerShell module installed and logged in and try again");
         }
 
         private bool TryGetTokenFromTestEnvironment(out string token)
@@ -146,7 +157,7 @@ private bool TryGetTokenFromTestEnvironment(out string token)
             return !string.IsNullOrEmpty(token);
         }
 
-        private async Task<(bool succeeded, string token)> TryGetAzCliToken()
+        private async Task<(bool Succeeded, string Token)> TryGetAzCliToken()
         {
             try
             {
@@ -158,6 +169,7 @@ private bool TryGetTokenFromTestEnvironment(out string token)
                 {
                     ColoredConsole.WriteLine(WarningColor("Unable to fetch access token from az CLI"));
                 }
+
                 return (false, null);
             }
         }
@@ -168,13 +180,15 @@ private async Task<string> RunAzCLICommand(string param)
             {
                 throw new CliException("az CLI not found");
             }
+
             var az = RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
                 ? new Executable("cmd", $"/c az {param}")
                 : new Executable("az", param);
 
             var stdout = new StringBuilder();
             var stderr = new StringBuilder();
             var exitCode = await az.RunAsync(o => stdout.AppendLine(o), e => stderr.AppendLine(e));
+
             if (exitCode == 0)
             {
                 return stdout.ToString().Trim(' ', '\n', '\r', '"');
@@ -185,18 +199,18 @@ private async Task<string> RunAzCLICommand(string param)
                 {
                     ColoredConsole.WriteLine(VerboseColor($"Unable to run az CLI command `az {param}`. Error: {stderr.ToString().Trim(' ', '\n', '\r')}"));
                 }
+
                 throw new CliException("Error running Az CLI command");
             }
         }
 
-        private async Task<(bool succeeded, string token)> TryGetAzPowerShellToken()
+        private async Task<(bool Succeeded, string Token)> TryGetAzPowerShellToken()
         {
             // PowerShell Core can only use Az so we can check that it exists and that the Az module exists
-            if (CommandChecker.CommandExists(_powerShellCoreExecutable) &&
-                await CommandChecker.PowerShellModuleExistsAsync(_powerShellCoreExecutable, _azProfileModuleName))
+            if (CommandChecker.CommandExists(PowerShellCoreExecutable) &&
+                await CommandChecker.PowerShellModuleExistsAsync(PowerShellCoreExecutable, AzProfileModuleName))
             {
-                var az = new Executable(_powerShellCoreExecutable,
-                    $"-NonInteractive -o Text -NoProfile -c {GetPowerShellAccessTokenScript(_azProfileModuleName)}");
+                var az = new Executable(PowerShellCoreExecutable, $"-NonInteractive -o Text -NoProfile -c {GetPowerShellAccessTokenScript(AzProfileModuleName)}");
 
                 var stdout = new StringBuilder();
                 var stderr = new StringBuilder();
@@ -215,18 +229,18 @@ await CommandChecker.PowerShellModuleExistsAsync(_powerShellCoreExecutable, _azP
             }
 
             // Windows PowerShell can use Az or AzureRM so first we check if powershell.exe is available
-            if (CommandChecker.CommandExists(_windowsPowerShellExecutable))
+            if (CommandChecker.CommandExists(WindowsPowerShellExecutable))
             {
                 string moduleToUse;
 
                 // depending on if Az.Profile or AzureRM.Profile is available, we need to change the prefix
-                if (await CommandChecker.PowerShellModuleExistsAsync(_windowsPowerShellExecutable, _azProfileModuleName))
+                if (await CommandChecker.PowerShellModuleExistsAsync(WindowsPowerShellExecutable, AzProfileModuleName))
                 {
-                    moduleToUse = _azProfileModuleName;
+                    moduleToUse = AzProfileModuleName;
                 }
-                else if (await CommandChecker.PowerShellModuleExistsAsync(_windowsPowerShellExecutable, _azureRmProfileModuleName))
+                else if (await CommandChecker.PowerShellModuleExistsAsync(WindowsPowerShellExecutable, AzureRmProfileModuleName))
                 {
-                    moduleToUse = _azureRmProfileModuleName;
+                    moduleToUse = AzureRmProfileModuleName;
                 }
                 else
                 {
@@ -235,6 +249,7 @@ await CommandChecker.PowerShellModuleExistsAsync(_powerShellCoreExecutable, _azP
                     {
                         ColoredConsole.WriteLine(VerboseColor("Unable to find Az.Profile or AzureRM.Profile."));
                     }
+
                     return (false, null);
                 }
 
@@ -255,24 +270,25 @@ await CommandChecker.PowerShellModuleExistsAsync(_powerShellCoreExecutable, _azP
                     }
                 }
             }
+
             return (false, null);
         }
 
         // Sets the prefix of the script in case they have Az.Profile or AzureRM.Profile
         private static string GetPowerShellAccessTokenScript(string module)
         {
             string prefix;
-            if (module == _azProfileModuleName)
+            if (module == AzProfileModuleName)
             {
                 prefix = "Az";
             }
-            else if (module == _azureRmProfileModuleName)
+            else if (module == AzureRmProfileModuleName)
             {
                 prefix = "AzureRM";
             }
             else
             {
-                throw new ArgumentException($"Expected module to be '{_azProfileModuleName}' or '{_azureRmProfileModuleName}'");
+                throw new ArgumentException($"Expected module to be '{AzProfileModuleName}' or '{AzureRmProfileModuleName}'");
             }
 
             // This PowerShell script first grabs the Azure context, fetches the profile client and requests an accesstoken.

src/Cli/func/Actions/AzureActions/BaseFunctionAppAction.cs

@@ -1,11 +1,12 @@
-using System.Linq;
-using Azure.Functions.Cli.Arm;
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the MIT License. See LICENSE in the project root for license information.
+
 using Azure.Functions.Cli.Common;
 using Fclp;
 
 namespace Azure.Functions.Cli.Actions.AzureActions
 {
-    abstract class BaseFunctionAppAction : BaseAzureAction
+    internal abstract class BaseFunctionAppAction : BaseAzureAction
     {
         public string FunctionAppName { get; set; }
 
@@ -25,7 +26,9 @@ public override ICommandLineParserResult ParseArgs(string[] args)
             }
             else
             {
-                throw new CliArgumentsException("Must specify functionApp name.", base.ParseArgs(args),
+                throw new CliArgumentsException(
+                    "Must specify functionApp name.",
+                    base.ParseArgs(args),
                     new CliArgument { Name = nameof(FunctionAppName), Description = "Function App name" });
             }
 

src/Cli/func/Actions/AzureActions/DeprecatedAzureActions.cs

@@ -1,4 +1,6 @@
-using System.Threading.Tasks;
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the MIT License. See LICENSE in the project root for license information.
+
 using Azure.Functions.Cli.Common;
 
 namespace Azure.Functions.Cli.Actions.AzureActions
@@ -22,4 +24,4 @@ public override Task RunAsync()
             throw new CliException("This command has been removed. Please use az-cli (https://docs.microsoft.com/en-us/cli/azure/install-azure-cli) or Azure Powershell (https://docs.microsoft.com/en-us/powershell/azure/overview) for management commands.");
         }
     }
-}
+}

src/Cli/func/Actions/AzureActions/FetchAppSettingsAction.cs

@@ -1,18 +1,18 @@
-using System;
-using System.Threading.Tasks;
-using Colors.Net;
-using Azure.Functions.Cli.Arm;
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the MIT License. See LICENSE in the project root for license information.
+
+using Azure.Functions.Cli.Helpers;
 using Azure.Functions.Cli.Interfaces;
+using Colors.Net;
 using static Azure.Functions.Cli.Common.OutputTheme;
-using Azure.Functions.Cli.Helpers;
 
 namespace Azure.Functions.Cli.Actions.AzureActions
 {
     [Action(Name = "fetch-app-settings", Context = Context.Azure, SubContext = Context.FunctionApp, HelpText = "Retrieve App Settings from your Azure-hosted Function App and store locally")]
     [Action(Name = "fetch", Context = Context.Azure, SubContext = Context.FunctionApp, HelpText = "Retrieve App Settings from your Azure-hosted Function App and store locally")]
     internal class FetchAppSettingsAction : BaseFunctionAppAction
     {
-        private ISecretsManager _secretsManager;
+        private readonly ISecretsManager _secretsManager;
 
         public FetchAppSettingsAction(ISecretsManager secretsManager)
         {
@@ -37,9 +37,8 @@ public override async Task RunAsync()
                 foreach (var connectionString in functionApp.ConnectionStrings)
                 {
                     ColoredConsole.WriteLine($"Loading {connectionString.Key} = *****");
-                    _secretsManager.SetConnectionString(connectionString.Key, connectionString.Value.value);
+                    _secretsManager.SetConnectionString(connectionString.Key, connectionString.Value.Value);
                 }
-
             }
             else
             {