Fix release build and prep for new version (#3153)

Author: David R. Williamson

SDK v2 migration guide.md

@@ -286,12 +286,16 @@ What was a loose affiliation of separate clients is now a consolidated client wi
 - The `Message` class no longer requires disposal!
 - `FeedbackReceiver` is now a callback assigned to the `MessageFeedbackProcessor` property.
 - `GetFileNotificationReceiver(...)` is now a callback assigned to `FileUploadNotificationProcessor` property. These methods return a callback value.
+- `FileUploadNotification.BlobUriPath` was a string and is now of type `System.Uri`.
 
 #### Notable additions
 
 - The library now includes `IIotHubServiceRetryPolicy` implementations: `IotHubServiceExponentialBackoffRetryPolicy`, `IotHubServiceFixedDelayRetryPolicy`, `IotHubServiceIncrementalDelayRetryPolicy` and `IotHubServiceNoRetry`,
  which can be set via `IotHubServiceClientOptions.RetryPolicy`.
  - `DirectMethodClientResponse` now has a method `TryGetValue<T>` to deserialize the payload to a type of your choice.
+ - Added `ImportJobError` class to help deserialize errors from device/module/configuration import job.
+   - Use the `ImportErrorsBlobName` to load the output errors file, if it exists, in the blob container specified in `ImportJobProperties.InputBlobContainerUri`.
+- `IsFinished` convenience property now exists on `CloudToDeviceMethodScheduledJob`, `ScheduledJob`, and `TwinScheduledJob` which is **true** when `Status` is `Completed`, `Failed`, or `Cancelled`.
 
 #### API mapping
 

iothub/device/src/Microsoft.Azure.Devices.Client.csproj

@@ -28,7 +28,7 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <Version>2.0.0-preview003</Version>
+    <Version>2.0.0-preview004</Version>
     <Title>Microsoft Azure IoT Device Client SDK</Title>
     <IncludeSource>True</IncludeSource>
     <IncludeSymbols>True</IncludeSymbols>

iothub/service/samples/how to guides/CleanupDevicesSample/CleanupDevicesSample.csproj

@@ -18,12 +18,6 @@
     <PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
   </ItemGroup>
 
-  <ItemGroup>
-    <None Update="csharp_devices_list.csv">
-      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
-    </None>
-  </ItemGroup>
-
   <!--<ItemGroup Condition="'$(Configuration)' == 'Release'">
     <PackageReference Include="Microsoft.Azure.Devices" Version="2.0.0-preview001" />
   </ItemGroup>-->

iothub/service/src/Amqp/AmqpCbsSessionHandler.cs

@@ -12,7 +12,9 @@ namespace Microsoft.Azure.Devices.Amqp
     /// Handles a single CBS session (for SAS token renewal) including the inital authentication and scheduling all subsequent
     /// authentication attempts.
     /// </summary>
+#pragma warning disable CA1852 // used in debug for unit test mocking
     internal class AmqpCbsSessionHandler : IDisposable
+#pragma warning restore CA1852
     {
         // There is no AmqpSession object to track here because it is encapsulated by the AmqpCbsLink class.
         private readonly IotHubConnectionProperties _credential;

iothub/service/src/Amqp/AmqpConnectionHandler.cs

@@ -21,7 +21,9 @@ namespace Microsoft.Azure.Devices.Amqp
     /// <remarks>
     /// This class intentionally abstracts away details about sessions and links for simplicity at the service client level.
     /// </remarks>
+#pragma warning disable CA1852 // used in debug for unit test mocking
     internal class AmqpConnectionHandler : IDisposable
+#pragma warning restore CA1852
     {
         private static readonly AmqpVersion s_amqpVersion_1_0_0 = new(1, 0, 0);
 

iothub/service/src/Amqp/AmqpSessionHandler.cs

@@ -13,7 +13,9 @@ namespace Microsoft.Azure.Devices.Amqp
     /// Handles a single AMQP session that holds the sender or receiver link that does the "work"
     /// for the AMQP connection (receiving file upload notification, sending cloud to device messages, etc).
     /// </summary>
+#pragma warning disable CA1852 // used in debug for unit test mocking
     internal class AmqpSessionHandler
+#pragma warning restore CA1852
     {
         private readonly AmqpSendingLinkHandler _sendingLinkHandler;
         private readonly AmqpReceivingLinkHandler _receivingLinkHandler;

iothub/service/src/Authentication/IotHubTokenCredentialProperties.cs

@@ -12,7 +12,9 @@ namespace Microsoft.Azure.Devices
     /// <summary>
     /// The properties required for authentication to IoT hub using a token credential.
     /// </summary>
+#pragma warning disable CA1852 // used in debug for unit test mocking
     internal class IotHubTokenCredentialProperties : IotHubConnectionProperties
+#pragma warning restore CA1852
     {
         private const string TokenType = "Bearer";
         private static readonly string[] s_iotHubAadTokenScopes = new string[] { "https://iothubs.azure.net/.default" };

iothub/service/src/Microsoft.Azure.Devices.csproj

@@ -27,7 +27,7 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <Version>2.0.0-preview003</Version>
+    <Version>2.0.0-preview004</Version>
     <Title>Microsoft Azure IoT Service Client SDK</Title>
     <IncludeSource>True</IncludeSource>
     <IncludeSymbols>True</IncludeSymbols>

iothub/service/src/Registry/Models/ImportJobError.cs

@@ -12,7 +12,7 @@ namespace Microsoft.Azure.Devices
     /// Any errors that occur during a bulk import job can be deserialized with this class from a blob file named "importErrors.log"
     /// in the container specified during import.
     /// </remarks>
-    public class ImportJobError
+    public sealed class ImportJobError
     {
         /// <summary>
         /// The name of the blob file that contains the import errors.

provisioning/device/src/Microsoft.Azure.Devices.Provisioning.Client.csproj

@@ -26,7 +26,7 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <Version>2.0.0-preview003</Version>
+    <Version>2.0.0-preview004</Version>
     <Title>Microsoft Azure IoT Provisioning Device Client SDK</Title>
     <IncludeSource>True</IncludeSource>
     <IncludeSymbols>True</IncludeSymbols>