Az.StorageSync HotFix | Turn EnableMIChecking false in Az.StorageSync (#25956)

* Turn EnableMIChecking false in Az.StorageSync

* Update ChangeLog.md

Author: ankushbindlish2

src/StorageSync/StorageSync.Test/Common/MockSyncServerRegistrationClientBase.cs

@@ -36,7 +36,7 @@ namespace Commands.StorageSync.Interop.Clients
     /// <seealso cref="Commands.StorageSync.Interop.Interfaces.ISyncServerRegistration" />
     public abstract class MockSyncServerRegistrationClientBase : ISyncServerRegistration
     {
-        public bool EnableMIChecking { get; protected set; } = false; // enable it in v19 azure file sync agent
+        public bool EnableMIChecking { get; protected set; } = false; // enable it in v20 azure file sync agent
 
         /// <summary>
         /// The m is disposed

src/StorageSync/StorageSync/ChangeLog.md

@@ -18,6 +18,8 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Fixed the bug in server registration
+* Improved the error message for Set-AzStorageSyncServiceIdentity cmdlet
 
 ## Version 2.3.0
 * Fixed the Register-AzStorageSyncServer with Azure FileSync Agent v17

src/StorageSync/StorageSync/Interop/ManagedIdentity/ServerManagedIdentityProvider.cs

@@ -23,7 +23,7 @@ public class ServerManagedIdentityProvider : IServerManagedIdentityProvider , ID
 
         public ServerManagedIdentityProvider(Action<string, EventLevel> traceLog = null)
         {
-            EnableMIChecking = true;
+            EnableMIChecking = false;
             this.TraceLog = new Action<string, EventLevel>((message, e) => {
                 if (traceLog != null)
                 {
@@ -43,7 +43,7 @@ public LocalServerType GetServerType(IEcsManagement ecsManagement)
         {
             TraceLog($"{nameof(EnableMIChecking)} is {EnableMIChecking}.", EventLevel.Informational);
 
-            // TODO: this should be removed once MI is fullly functional
+            // TODO: this should be removed once MI is fully functional
             if (!EnableMIChecking)
             {
                 return LocalServerType.HybridServer;

src/StorageSync/StorageSync/StorageSyncService/SetStorageSyncServiceIdentityCommand.cs

@@ -189,7 +189,7 @@ public override void ExecuteCmdlet()
 
                     if(candidateServersLookup.Count == 0)
                     {
-                        throw new PSArgumentException("No server found which is available for migration.");
+                        throw new PSArgumentException("No server found which can be configured to use a managed identity.");
                     }
 
                     StorageSyncClientWrapper.VerboseLogger.Invoke($"Found {candidateServersLookup.Count} servers out of {registeredServers.Count(s => s.ServerRole != ServerRoleType.ClusterName.ToString())} total servers to migrate");