Skip to content

Minimal changes for 2024-04-01-preview API version with suppressions#42647

Open
ransinha1989 wants to merge 3 commits intoAzure:mainfrom
ransinha1989:dev-ranjanasinha-trafficmanager
Open

Minimal changes for 2024-04-01-preview API version with suppressions#42647
ransinha1989 wants to merge 3 commits intoAzure:mainfrom
ransinha1989:dev-ranjanasinha-trafficmanager

Conversation

@ransinha1989
Copy link
Copy Markdown
Member

@ransinha1989 ransinha1989 commented Apr 24, 2026

  • Add @@clientName for Endpoints.updateV2 and Profiles.updateV2 to preserve Update method name in SDKs
  • Add sdk-suppressions.yaml for .NET ApiCompat breaking change on parameter type

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@ransinha1989
Fix SDK breaking change: rename updateV2 to update and add suppressions
886b9fe 
- Add @@clientName for Endpoints.updateV2 and Profiles.updateV2 to preserve Update method name in SDKs
- Add sdk-suppressions.yaml for .NET ApiCompat breaking change on parameter type

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2026 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the VersioningReviewRequired label.
  • ❌ This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired).
    To unblock this PR, either a) introduce a new API version with these changes instead of modifying an existing API version, or b) follow the process at aka.ms/brch.
  • ❌ The required check named Swagger Avocado has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@github-actions github-actions Bot added ARMReview resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 24, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2026 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.Network

Comment generated by After APIView workflow run.

ransinha1989 and others added 2 commits April 27, 2026 14:08
@ransinha1989
Remove separate PATCH models - use Endpoint/Profile for all API versions
26ad354 
Reverts the updateV2 operation split and removes EndpointUpdate,
ProfileUpdate, and ProfilePropertiesUpdate models. PATCH operations
now use the original Endpoint/Profile resource models across all
API versions, eliminating SDK breaking changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ransinha1989
Add suppressions to readme.md
9fd186a 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ransinha1989 ransinha1989 changed the title Fix SDK breaking change: rename updateV2 to update and add suppressions Minimal changes for 2024-04-01-preview API version with suppressions Apr 28, 2026
@github-actions github-actions Bot added VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required NotReadyForARMReview and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ARMReview Network - Traffic Manager NotReadyForARMReview resource-manager SuppressionReviewRequired TypeSpec Authored with TypeSpec VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ransinha1989