From d40b136bf2dc23415e7901e659a711801c8739f0 Mon Sep 17 00:00:00 2001 From: Ray Chen Date: Fri, 24 Apr 2026 16:16:30 -0700 Subject: [PATCH] Add TriggerSource parameter to mark SDK PRs as ready for review When spec-gen-sdk pipeline is triggered by the release-plan-app, create the SDK pull request in 'ready for review' state instead of draft. A new 'TriggerSource' parameter (default: 'unspecified') is added to differentiate callers. Related: https://github.com/Azure/azure-sdk-tools/issues/15209 Related: https://github.com/Azure/azure-sdk-tools/issues/15294 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- eng/pipelines/spec-gen-sdk.yml | 5 +++++ eng/pipelines/templates/stages/archetype-spec-gen-sdk.yml | 7 +++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/eng/pipelines/spec-gen-sdk.yml b/eng/pipelines/spec-gen-sdk.yml index 3a811357e11f..3239463ff96f 100644 --- a/eng/pipelines/spec-gen-sdk.yml +++ b/eng/pipelines/spec-gen-sdk.yml @@ -37,6 +37,10 @@ parameters: type: number default: 0 displayName: 'Release plan work item id' + - name: TriggerSource + type: string + default: 'unspecified' + displayName: 'Trigger source' trigger: none @@ -53,3 +57,4 @@ extends: CreatePullRequest: ${{ parameters.CreatePullRequest }} ForceCreateEvenWithFailures: ${{ parameters.ForceCreateEvenWithFailures }} ReleasePlanWorkItemId: ${{ parameters.ReleasePlanWorkItemId }} + TriggerSource: ${{ parameters.TriggerSource }} diff --git a/eng/pipelines/templates/stages/archetype-spec-gen-sdk.yml b/eng/pipelines/templates/stages/archetype-spec-gen-sdk.yml index 4b98646d6c41..c8811cc9944c 100644 --- a/eng/pipelines/templates/stages/archetype-spec-gen-sdk.yml +++ b/eng/pipelines/templates/stages/archetype-spec-gen-sdk.yml @@ -34,6 +34,9 @@ parameters: - name: ReleasePlanWorkItemId type: number default: 0 + - name: TriggerSource + type: string + default: 'unspecified' stages: - stage: ${{ iif(eq(parameters.SpecBatchTypes, ''), 'Build', format('Build_{0}', replace(parameters.SpecBatchTypes, '-', '_'))) }} @@ -339,7 +342,7 @@ stages: -AuthToken "$(azuresdk-github-pat)" -PRTitle "$(PrTitle)-generated-from-$(Build.DefinitionName)-$(Build.BuildId)" -PRBody "$(GeneratedSDKInformation) $(ReleasePlanInfo)" - -OpenAsDraft $true + -OpenAsDraft $${{ ne(parameters.TriggerSource, 'release-plan-app') }} - ${{ if ne(parameters.ReleasePlanWorkItemId, 0) }}: @@ -347,7 +350,7 @@ stages: $prUrl = "https://github.com/Azure/$(SdkRepoName)/pull/$(Submitted.PullRequest.Number)" Write-Host "Pull request created: $prUrl" Write-Host "##vso[task.setvariable variable=PullRequestUrl]$prUrl" - $prStatus = "draft" + $prStatus = "${{ iif(eq(parameters.TriggerSource, 'release-plan-app'), 'ready for review', 'draft') }}" Write-Host "##vso[task.setvariable variable=SdkPrStatus]$prStatus" condition: and(succeeded(), eq(variables['HasChanges'], 'true'), ne(variables['Build.Reason'], 'PullRequest'), not(endsWith(variables['SdkRepoName'], '-pr'))) displayName: "Set pull request URL variable"